1525233 - [snappy][Ubuntu 16.04 GNOME][CSD] Right-click context menu incorrectly positioned in non-maximized window with Adwaita theme

Status: RESOLVED WORKSFORME

(Core :: Widget: Gtk, defect)

Description

[Kestrel]

Attachment: misplaced-context-menu.png

The beta Snap package on Ubuntu 18.10 has misaligned context menus that cause unwanted actions when the right mouse button is clicked rather than held down. Does not happen with maximized windows, non-remote content (eg about:support), mozilla.widget.use-argb-visuals = false, native titlebar enabled, WebRender or layers acceleration.

Most likely caused by Bug 1521012.

Comment 1

[Kestrel]

[Tracking Requested - why for this release]:

Context menu in wrong location making interaction difficult and triggers unwanted actions, caused by CSD which is now enabled by default in 66 (Bug 1490344).

Comment 2

[Martin Stránský [:stransky] (ni? me)]

This is a dupe of Bug 1521175

Comment 3

[Kestrel]

(In reply to Martin Stránský [:stransky] from comment #2)

This is a dupe of Bug 1521175

This doesn't happen with WebRender though and there is no rendering issue, cursor matches up perfectly with content, only the right-click context menu and autoscroll icon are misplaced.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Sorry, wrong bug, it's Bug 1523721

Comment 5

[Kestrel]

I tested the Snap package 66.0b6 build 20190207161357 which has the fix for Bug 1523721 but the problem still remains.

Comment 6

[Kestrel]

This happens with Adwaita theme but also affects the Ubuntu 18.10 default Yaru theme and others since the Snap package cannot use them and falls back to Adwaita.

Problem does not occur with the Ambiance theme.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Please try latest nightly package from mozilla if you still can reproduce there. Thanks.

Comment 8

[Kestrel]

I only see this in the Snap package which does not have a channel for Nightly (Bug 1451694).

Errors also appear in terminal when cursor passes over titlebar region (with Ambiance theme as well).

(firefox:29495): Gtk-CRITICAL **: gtk_widget_get_style_context: assertion 'GTK_IS_WIDGET (widget)' failed
(firefox:29495): Gtk-CRITICAL **: gtk_style_context_get_state: assertion 'GTK_IS_STYLE_CONTEXT (context)' failed
(firefox:29495): Gtk-CRITICAL **: gtk_style_context_set_state: assertion 'GTK_IS_STYLE_CONTEXT (context)' failed
(firefox:29495): Gtk-CRITICAL **: gtk_render_background: assertion 'GTK_IS_STYLE_CONTEXT (context)' failed
(firefox:29495): Gtk-CRITICAL **: gtk_render_frame: assertion 'GTK_IS_STYLE_CONTEXT (context)' failed

Comment 9

[Kestrel]

I can reproduce this with latest Nightly 67 on Ubuntu 16.04 (Snap build environment) with ubuntu-gnome-desktop installed and Adwaita theme.

On Nightly 67 it does not occur with mozilla.widget.use-argb-visuals defined regardless of value.
On Beta 66.0b6 it does not occur with mozilla.widget.use-argb-visuals = false.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1c227ac918eb1ab0b702d4424603faeb836f2b1c&tochange=64d38928ff5a59fb8214a0ee2472dccd6f16705d

Regressed by Bug 1521012.

I created Bug 1526867 for the terminal errors.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

(In reply to Kestrel from comment #8)

I only see this in the Snap package which does not have a channel for
Nightly (Bug 1451694).

Errors also appear in terminal when cursor passes over titlebar region (with
Ambiance theme as well).

(firefox:29495): Gtk-CRITICAL **: gtk_widget_get_style_context: assertion 'GTK_IS_WIDGET (widget)' failed
(firefox:29495): Gtk-CRITICAL **: gtk_style_context_get_state: assertion 'GTK_IS_STYLE_CONTEXT (context)' failed
(firefox:29495): Gtk-CRITICAL **: gtk_style_context_set_state: assertion 'GTK_IS_STYLE_CONTEXT (context)' failed
(firefox:29495): Gtk-CRITICAL **: gtk_render_background: assertion 'GTK_IS_STYLE_CONTEXT (context)' failed
(firefox:29495): Gtk-CRITICAL **: gtk_render_frame: assertion 'GTK_IS_STYLE_CONTEXT (context)' failed

Looks like the GTK+ styles are not loaded so the decoration offset is incorrectly calculated (perhaps as zero).

The regression from Bug 1521012 is that we switched from window manager decoration styles to client decorations (CSD) and we need to calculate the decoration offset here.

So it's needed to fix Bug 1526867 to get correct offset or disable default hidden titlebar when running under snappy.

Comment 11

[Kestrel]

This has been fixed on Ubuntu 16.04 with GNOME desktop by Bug 1529713.