1527347 - vanilla activity stream breakpoints causing wonkiness in discovery stream

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Scott [:thecount] Downe]

If you start to reduce the horizontal screen size, some weird things start to happen, pretty sure it's due to old breakpoints on main, I'll investigate.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4786

Comment 2

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/6d9b468951ce

Comment 3

[Kate Hudson :k88hudson]

Would you be able to verify that the breakpoints are working as expected in nightly? Thanks!

Comment 4

[Wolasi :wolasi]

Looks like there are still breakpoints on the search bar so it starts to jump around when the window width goes below 1024ox. Everything else looks good.

Comment 5

[Kate Hudson :k88hudson]

https://hg.mozilla.org/mozilla-central/rev/abe819688f32

Comment 6

[Kate Hudson :k88hudson]

Hey, can you re-verify this now that the search issue has been fixed?

Comment 7

[Wolasi :wolasi]

I have verified this in Nightly 67.0a1 on Mac OS 10.14.3

Comment 8

[Kate Hudson :k88hudson]

Attachment: Bug 1527347 - Remove breakpoints for Discovery Stream

Comment 9

[Tim Spurway [:tspurway]]

Comment on attachment 9044256 [details]
Bug 1527347 - Remove breakpoints for Discovery Stream

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

wonky resizing of visual elements on the new tab page

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

Yes

If yes, steps to reproduce

1. set browser.newtabpage.activity-stream.discoverystream.config = {"enabled":false,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=basic"}
2. navigate to about:home or about:newtab and resize horizontally

You should see no elements 'jump' on the screen (ie. resizing should look smooth)

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

This is a very simple and small change - mostly css

String changes made/needed

none

Comment 10

[Liz Henry (:lizzard)]

Comment on attachment 9044256 [details]
Bug 1527347 - Remove breakpoints for Discovery Stream

Planned work for pocket/new tab. Verified in Nightly.
OK for beta uplift, should land for beta 9.
Landing order: bug 1519879, bug 1525494, bug 1526861, bug 1524669, bug 1527195, bug 1525391, bug 1527347, bug 1525366, bug 1527626, bug 1527397, bug 1518258, bug 1527701, bug 1527370.

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6462ee7b5df4

Comment 12

[Camelia Badau [:cbadau], Desktop Test Engineering]

(In reply to Wolasi from comment #7)

I have verified this in Nightly 67.0a1 on Mac OS 10.14.3

Can you please verify this issue on Firefox 66 Beta 9 (https://archive.mozilla.org/pub/firefox/candidates/66.0b9-candidates/build1/)?

Comment 13

[Wolasi :wolasi]

I have verified that the breakpoint issues have been resolved in Beta 66.0b9 on Mac OS 10.14.3

Comment 14

[Camelia Badau [:cbadau], Desktop Test Engineering]

(In reply to Wolasi from comment #13)

I have verified that the breakpoint issues have been resolved in Beta 66.0b9
on Mac OS 10.14.3

Thanks for verifying this!