vanilla activity stream breakpoints causing wonkiness in discovery stream

VERIFIED FIXED in Firefox 66

Status

()

defect
P1
normal
VERIFIED FIXED
6 months ago
2 months ago

People

(Reporter: thecount, Assigned: thecount)

Tracking

({github-merged, regression})

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66+ verified, firefox67 verified)

Details

Attachments

(2 attachments)

If you start to reduce the horizontal screen size, some weird things start to happen, pretty sure it's due to old breakpoints on main, I'll investigate.

Assignee: nobody → sdowne
Summary: vanilla activity stream breakpoints causing wonkiness in activity stream → vanilla activity stream breakpoints causing wonkiness in discovery stream
Priority: -- → P1
Blocks: 1527504
Iteration: --- → 67.2 - Feb 11 - 24
Status: NEW → RESOLVED
Closed: 6 months ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Would you be able to verify that the breakpoints are working as expected in nightly? Thanks!

Flags: needinfo?(wkonu)

Looks like there are still breakpoints on the search bar so it starts to jump around when the window width goes below 1024ox. Everything else looks good.

Flags: needinfo?(wkonu)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 1528119
Status: REOPENED → RESOLVED
Closed: 6 months ago6 months ago
Resolution: --- → FIXED

Hey, can you re-verify this now that the search issue has been fixed?

Flags: needinfo?(wkonu)

I have verified this in Nightly 67.0a1 on Mac OS 10.14.3

Flags: needinfo?(wkonu)

Comment on attachment 9044256 [details]
Bug 1527347 - Remove breakpoints for Discovery Stream

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

None

User impact if declined

wonky resizing of visual elements on the new tab page

Is this code covered by automated tests?

Yes

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

Yes

If yes, steps to reproduce

  1. set browser.newtabpage.activity-stream.discoverystream.config = {"enabled":false,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=basic"}
  2. navigate to about:home or about:newtab and resize horizontally

You should see no elements 'jump' on the screen (ie. resizing should look smooth)

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

This is a very simple and small change - mostly css

String changes made/needed

none

Attachment #9044256 - Flags: approval-mozilla-beta?
Status: RESOLVED → VERIFIED

Comment on attachment 9044256 [details]
Bug 1527347 - Remove breakpoints for Discovery Stream

Planned work for pocket/new tab. Verified in Nightly.
OK for beta uplift, should land for beta 9.
Landing order: bug 1519879, bug 1525494, bug 1526861, bug 1524669, bug 1527195, bug 1525391, bug 1527347, bug 1525366, bug 1527626, bug 1527397, bug 1518258, bug 1527701, bug 1527370.

Attachment #9044256 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

(In reply to Wolasi from comment #7)

I have verified this in Nightly 67.0a1 on Mac OS 10.14.3

Can you please verify this issue on Firefox 66 Beta 9 (https://archive.mozilla.org/pub/firefox/candidates/66.0b9-candidates/build1/)?

Flags: qe-verify+
Flags: needinfo?(wkonu)

I have verified that the breakpoint issues have been resolved in Beta 66.0b9 on Mac OS 10.14.3

Flags: needinfo?(wkonu)

(In reply to Wolasi from comment #13)

I have verified that the breakpoint issues have been resolved in Beta 66.0b9
on Mac OS 10.14.3

Thanks for verifying this!

Flags: qe-verify+
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.