1527397 - [Hero] Update layout for full-width hero

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Wolasi :wolasi]

Update layout per Figma Spec
https://www.figma.com/file/HAk87Z6QBcu6YxBIoXN6LJcU/Firefox-Home-Modules?node-id=15%3A0

Please note the changes to the line clamping for the title and excerpt for the primary/first story in the hero, they change based on the size of the hero unit. Ping me @wolasi on slack if further details are required

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4788

Comment 2

[Wolasi :wolasi]

Any chance you could make the source for the first story in the hero align to the bottom of the container using flexbox?

Comment 3

[Kate Hudson :k88hudson]

https://hg.mozilla.org/mozilla-central/rev/abe819688f32

Comment 4

[Kate Hudson :k88hudson]

Can you add some steps for this and ask Wolasi to take a look possibly?

Comment 5

[Kate Hudson :k88hudson]

Attachment: Bug 1527397 - Update layout for full-width hero in Discovery Stream

Comment 6

[Jessilyn Davis]

Gavin, Can you add some QA steps for this?

Wolasi can you QA?

Comment 7

[Gavin Suntop [:gvn] (they/them)]

Wolasi has already QA'd this and it's gone through code review. I don't believe it needs further QA.

Comment 8

[Wolasi :wolasi]

I have verified in Nightly 67.0a1 on Mac OS 10.14.3, the full-width hero layout has been updated as spec'ed.

Comment 9

[Gavin Suntop [:gvn] (they/them)]

Comment on attachment 9044273 [details]
Bug 1527397 - Update layout for full-width hero in Discovery Stream

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1527397

User impact if declined

Hero component will display in a sub-optimal way in which sub-items will be below the hero graphic.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Primarily CSS changes with very minimal HTML tweaks.

String changes made/needed

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9044273 [details]
Bug 1527397 - Update layout for full-width hero in Discovery Stream

Planned work for pocket/new tab. Verified in Nightly.
OK for beta uplift, should land for beta 9.
Landing order: bug 1519879, bug 1525494, bug 1526861, bug 1524669, bug 1527195, bug 1525391, bug 1527347, bug 1525366, bug 1527626, bug 1527397, bug 1518258, bug 1527701, bug 1527370.

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/afb752a4525c

Comment 12

[Camelia Badau [:cbadau], Desktop Test Engineering]

(In reply to Wolasi from comment #8)

I have verified in Nightly 67.0a1 on Mac OS 10.14.3, the full-width hero
layout has been updated as spec'ed.

Can you please verify this issue on Firefox 66 Beta 9 (https://archive.mozilla.org/pub/firefox/candidates/66.0b9-candidates/build1/)?

Comment 13

[Wolasi :wolasi]

I have verified in Beta v66.0b9 on Mac OS 10.14.3, the full-width hero layout has been updated as spec'ed.

Comment 14

[Camelia Badau [:cbadau], Desktop Test Engineering]

(In reply to Wolasi from comment #13)

I have verified in Beta v66.0b9 on Mac OS 10.14.3, the full-width hero
layout has been updated as spec'ed.

Thanks for verifying this!