1558482 - Support clipping to the visibleRect and applying scaling from CSS transforms to OOP-iframes

Status: RESOLVED FIXED

(Core :: Graphics, task, P3)

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1558482 - Add visibleRect and scaling to EffectsInfo and compute them when using layers. r?mattwoodrow

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: Bug 1558482 - Apply visibleRect and scaling when painting. r?mattwoodrow

visibleRect should affect both WR/layers, and scaling will only affect
layers.

Depends on D34523

Comment 3

[Ryan Hunt [:rhunt]]

Attachment: Bug 1558482 - Split off the code that forces a repaint from visibility and use it for invalidating EffectsInfo updates. r?mattwoodrow

This is suboptimal for when we simply change the visibleRect of an OOP-iframe,
which could happen when scrolling over a very tall iframe, but is very easy
to make sure is working correctly.

Depends on D34525

Comment 4

[Ryan Hunt [:rhunt]]

Attachment: Bug 1558482 - Only initialize the root displayport for the cross process root content document. r?kats

The root displayport has some assumptions built into it about being positioned at
the origin and sized to the composition bounds that seem like they only apply to
the cross process root content document. This commit changes us to avoid taking
this code path for OOP-iframes.

Depends on D34526

Comment 5

[Ryan Hunt [:rhunt]]

Attachment: Bug 1558482 - Restrict the composition size to the visibleRect for OOP-iframes. r?kats

Even if we don't have a root displayport, the composition size is still used for
displayport margins calculations. For extremely tall iframes, this will create
a displayport that is way to big. We should instead report a composition size that
is equivalent to the visible rect for OOP-iframes.

Depends on D34527

Comment 6

[Ryan Hunt [:rhunt]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f779c8be1e85d4f47ee18e8acd872a5354bac8e0

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3f2d2748314
Add visibleRect and scaling to EffectsInfo and compute them when using layers. r=mattwoodrow
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e2f26c4072b
Apply visibleRect and scaling when painting. r=mattwoodrow
https://hg.mozilla.org/integration/mozilla-inbound/rev/c024e5eced2c
Only initialize the root displayport for the cross process root content document. r=kats
https://hg.mozilla.org/integration/mozilla-inbound/rev/94b369f38c53
Restrict the composition size to the visibleRect for OOP-iframes. r=kats

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/e3f2d2748314
https://hg.mozilla.org/mozilla-central/rev/8e2f26c4072b
https://hg.mozilla.org/mozilla-central/rev/c024e5eced2c
https://hg.mozilla.org/mozilla-central/rev/94b369f38c53

Comment 9

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732