Closed Bug 1558482 Opened 6 months ago Closed 6 months ago

Support clipping to the visibleRect and applying scaling from CSS transforms to OOP-iframes

Categories

(Core :: Graphics, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla69
Fission Milestone M4
Tracking Status
firefox69 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

References

(Regressed 2 open bugs)

Details

Attachments

(4 files, 1 obsolete file)

No description provided.
Assignee: nobody → rhunt
Priority: -- → P3
Depends on: 1519546

visibleRect should affect both WR/layers, and scaling will only affect
layers.

Depends on D34523

This is suboptimal for when we simply change the visibleRect of an OOP-iframe,
which could happen when scrolling over a very tall iframe, but is very easy
to make sure is working correctly.

Depends on D34525

The root displayport has some assumptions built into it about being positioned at
the origin and sized to the composition bounds that seem like they only apply to
the cross process root content document. This commit changes us to avoid taking
this code path for OOP-iframes.

Depends on D34526

Even if we don't have a root displayport, the composition size is still used for
displayport margins calculations. For extremely tall iframes, this will create
a displayport that is way to big. We should instead report a composition size that
is equivalent to the visible rect for OOP-iframes.

Depends on D34527

Attachment #9071297 - Attachment is obsolete: true
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3f2d2748314
Add visibleRect and scaling to EffectsInfo and compute them when using layers. r=mattwoodrow
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e2f26c4072b
Apply visibleRect and scaling when painting. r=mattwoodrow
https://hg.mozilla.org/integration/mozilla-inbound/rev/c024e5eced2c
Only initialize the root displayport for the cross process root content document. r=kats
https://hg.mozilla.org/integration/mozilla-inbound/rev/94b369f38c53
Restrict the composition size to the visibleRect for OOP-iframes. r=kats
Regressions: 1405083
Regressions: 1539615
Regressions: 1559211
Regressions: 1559518
Regressions: 1559557
Regressions: 1560082
Regressions: 1560272
Regressions: 1559875
See Also: → 1561003

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.