Mail drag-and-drop action is "copy" (not "move") on Wayland
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
People
(Reporter: acc-bugz-mozilla, Unassigned)
References
Details
User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0
Steps to reproduce:
- Install Fedora 30 with Wayland 1.17 (and GNOME 3.32.2) and Thunderbird 60.7.2 (or, equivalently, the Fedora package thunderbird-wayland)
- Start a Wayland GNOME session and start thunderbird.
- Click and drag a mail from one (local or IMAP) folder to another (local or IMAP) folder.
Actual results:
During drag, the cursor indicates a "+" for copy action and, in fact, the message is copied.
Expected results:
The default drag-and-drop action should be move.
Why? This used to be the case in Fedora 29 with Wayland 1.16, GNOME 3.30.2 and Thunderbird 60.7.0. And it's still the case with Fedora 30 and a GNOME Xorg session!
By the way, ctrl+click and shift+click behave as expected.
|
||
Comment 2•5 years ago
|
||
Can you reproduce anything like this on Firefox, like dragging a bookmark? TB relies on Mozilla platform code for such things and if there's a problem with Wayland in general, they'll have to fix it.
This issue does not apply to Firefox ESR (60.7.2) or current Firefox (67.0.4) running on the same setup when dragging bookmarks in the bookmark library under chrome://browser/content/places/places.xul
Furthermore, I just found that this issue does NOT apply to Thunderbird 60.7.1 when run on the same setup! So this issue has been introduced from Thunderbird 60.7.1 to 60.7.2 and is NOT related to the Firefox base.
Okay, I confused myself with too many Firefox versions: In fact, a similar behavior CAN be observed with Firefox 67.0.4 in the bookmark library under chrome://browser/content/places/places.xul as has similarly been reported in https://bugzilla.mozilla.org/show_bug.cgi?id=1532618 and https://bugzilla.mozilla.org/show_bug.cgi?id=1466444. However, it does NOT apply to Firefox ESR 60.7.2, even though it DOES affect Thunderbird 60.7.2.
|
|
||
Comment 5•5 years ago
|
||
(In reply to tuxor from comment #3)
Furthermore, I just found that this issue does NOT apply to Thunderbird 60.7.1 when run on the same setup! So this issue has been introduced from Thunderbird 60.7.1 to 60.7.2 and is NOT related to the Firefox base.
Look, there were ZERO changes to the comm-esr60 codebase between 60.7.1 and 60.7.2:
https://hg.mozilla.org/releases/comm-esr60/pushloghtml?fromchange=THUNDERBIRD_60_7_1_RELEASE&tochange=THUNDERBIRD_60_7_2_RELEASE
60.7.2 was a pure security release to pick up a fix to Mozilla's JS engine.
60.7.1 was built on m-esr60: 560efdce1d072281398a98244e2ec43ab1f92186
60.7.2 was build on m-esr60: 32bd10cdfd752729f878cf18b9f72634e74772ba
https://hg.mozilla.org/releases/mozilla-esr60/pushloghtml?fromchange=560efdce1d072281398a98244e2ec43ab1f92186&tochange=32bd10cdfd752729f878cf18b9f72634e74772ba
It is really quite impossible that the behaviour changed between those two versions.
Whatever the case my be, to my knowledge Wayland is not a supported platform yet, see all the dependents of bug 635134, also https://www.mozilla.org/en-US/firefox/67.0/system-requirements/.
We're not going to go and fix anything in TB 60.x now given that the new ESR version TB 68 will be released this months, or in August the latest.
If it's not fix by bug 1532618, please let us know.
|
||
Comment 7•5 years ago
|
||
This was properly fixed in Firefox 70 (bug 1576268). Given that Thunderbird won't have a stable release until the next esr version and the simplicity of the patch, I would greatly appreciate to see it backported to 68.
|
||
Comment 8•5 years ago
|
||
That seems reasonable to me. Martin, could you request uplift of bug 1576268? I would, but it's probably better coming from someone who knows what they're talking about.
|
|
||
Comment 9•5 years ago
|
||
Or we can put it onto our branch.
|
||
Comment 10•5 years ago
|
||
I think Fedora is the only distro which ships thunderbird-wayland so I'd rather include it there first. Also I'm not entirely sure the patch fixes the mail movement - I'll test that first.
|
|
||
Comment 11•5 years ago
|
||
(In reply to Martin Stránský [:stransky] from comment #10)
I think Fedora is the only distro which ships thunderbird-wayland so I'd rather include it there first. Also I'm not entirely sure the patch fixes the mail movement - I'll test that first.
Added to thunderbird-68.3.0-2.fc30 and thunderbird-68.3.0-2.fc31
|
|
||
Comment 12•5 years ago
|
||
Yes, a patch from Bug 1576268 fixes it.
|
|
||
Comment 13•5 years ago
|
||
AFAIK Fedora is the only distro which ships thunderbird-wayland and it's fixed locally in Fedora build so there's no need to uplift it to ESR/Upstream right now. But the patch is pretty small and harmless so it's possible to uplift it when someone needs it.
|
||
Comment 14•5 years ago
|
||
I am still experiencing this on version 68.5.0 on GNOME 3.34.4 (wayland) using Arch Linux. I have a touchscreen laptop and dragging with a finger on the touchscreen outright crashes Thunderbird.
Should I file a separate bug or does it concern this one?
|
||
Comment 16•5 years ago
|
||
(In reply to Martin Stránský [:stransky] from comment #13)
AFAIK Fedora is the only distro which ships thunderbird-wayland
Is this still true?
And if not, is Wayland so popular that we should take a patch locally for 68 - which won't be EOL until Sept/October?
|
|
||
Comment 17•5 years ago
|
||
The Wayland backend still has some issues and is under constant development. But if you want to backport some DnD fixes, you'd likely want https://phabricator.services.mozilla.com/D60853 from bug 1604048
|
||
Comment 18•5 years ago
|
||
Given it's not far from 78, I'm not sure. OTOH, bug 1576268 should be a safe fix to uplift.
Description
•