1562651 - My Dashboard broken, reporting "Failed to load last changes from Bugzilla"

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: MyDashboard, defect)

Description

[Tomislav Jovanovic :zombie]

Attachment: bz-err.png

Since this Friday, I've been getting this error when trying to expand any bug on My Dashboard.

I've tried logging out and back in, tried a clean profile, and both current Firefox Beta and Nightly, same error.

Comment 1

[Kohei Yoshino [:kohei]]

Can reproduce the issue. Will figure out why.

Comment 2

[Kohei Yoshino [:kohei]]

But I cannot reproduce the issue on my local server… Did we perhaps change any server config last week?

Comment 3

[Chris Kolosiwsky [:ckolos] (ckolos has left the building)]

Yes, there was a deploy on Friday morning, per :dkl - https://bugzilla.mozilla.org/show_bug.cgi?id=1562237 . You(kohei) did the verification.

Comment 4

[Kohei Yoshino [:kohei]]

The Friday release was a hotfix for Bug 1562139 so the code change seems unrelated. Did the Thursday release change something in the server config?

Comment 5

[David Lawrence [:dkl]]

This is working on production for me. I am not able to reproduce the error message. I would say for the reporter to clear their cookies and other related BMO data/cache but he already stated he tried with a fresh profile.

@kohei, can you look in the network debugger when you get the error and see what other information can be pulled out to track down the error?

Comment 6

[David Lawrence [:dkl]]

No code related to the dashboard extension has changed in a long time. The only thing maybe possible related is bug 1559988.

Comment 7

[Kohei Yoshino [:kohei]]

Attachment: mydashboard-error-netmonitor.png

The error appears only when you click the triangle icon on each row to show the last change to the bug. I can reproduce the issue even after clearing cookies and also with my another account (MoCo email). Here’s a screenshot of the net monitor.

Comment 8

[David Lawrence [:dkl]]

(In reply to Kohei Yoshino [:kohei] (Bugzilla UX) (FxSiteCompat) from comment #7)

Created attachment 9075214 [details]
mydashboard-error-netmonitor.png

The error appears only when you click the triangle icon on each row to show the last change to the bug. I can reproduce the issue even after clearing cookies and also with my another account (MoCo email). Here’s a screenshot of the net monitor.

Yeah I am also clicking on the triangle and I see the last change content that is expected. Just curious, when you look at the network data, under the Params tab, does the data look proper? For example I see:

{"version":"1.1","method":"MyDashboard.run_last_changes","params":{"bug_id":1562694,"changeddate_api":"2019-07-01 18:30:23","Bugzilla_api_token":"xxxxx"}}

I can also look at the stackdriver logs to see if any other error messages are ending up there.

Comment 9

[Kohei Yoshino [:kohei]]

The same:

{"version":"1.1","method":"MyDashboard.run_last_changes","params":{"bug_id":1562364,"changeddate_api":"2019-06-29 03:48:36","Bugzilla_api_token":"xxxxx"}}

Comment 10

[Kohei Yoshino [:kohei]]

What we talked on Slack yesterday: This issue might be regressed by Bug 1560245 but I’m not sure because I cannot reproduce it locally. We’ll see if the removal of the legacy JSON-RPC code in Bug 1380437 would solve the issue.

Comment 11

[Tomislav Jovanovic :zombie]

There doesn't seem to be much activity in bug 1380437, is it possible to revert changes from bug 1560245 until this is figured out?

I'm almost unable to get any work done because of this.

Comment 12

[Kohei Yoshino [:kohei]]

We are going to ship the fix for Bug 1380437 as soon as possible.

By the way, is this feature useful? It will be removed in the future once we get rid of the old YUI table. UX-wise, the last change is not the most important change and is just a CC or minor change in many cases.

Comment 13

[Tomislav Jovanovic :zombie]

For someone who doesn't want to use (a limited, generic UI) email as a way to interact with a website, this feature is essential in being able to keep up with updates to bugs I care about.

And yes, the feature is not ideal, but that should be a reason to improve it, not get rid of it, people obviously use and depend on it.

Comment 15

[Dão Gottwald [:dao]]

(In reply to Tomislav Jovanovic :zombie from comment #13)

For someone who doesn't want to use (a limited, generic UI) email as a way to interact with a website, this feature is essential in being able to keep up with updates to bugs I care about.

And yes, the feature is not ideal, but that should be a reason to improve it, not get rid of it, people obviously use and depend on it.

I can second this. I prefer the dashboard over bugmail, and this bug makes it significantly more cumbersome to keep up with bugs.

Comment 16

[Kohei Yoshino [:kohei]]

As a UX designer, my long-term goal is reducing bugmail overload by offering more personalized features on the site, but as I said earlier, this particular feature only shows the last change, not all the unread changes, so you may miss important changes if you rely solely on this. I don’t have a plan to improve the current My Dashboard.

My PR for Bug 1380437 has been merged to master and will be pushed to production probably later next week, so let’s see if it solves the issue.

Comment 17

[Dão Gottwald [:dao]]

(In reply to Kohei Yoshino [:kohei] (Bugzilla UX) (FxSiteCompat) from comment #16)

As a UX designer, my long-term goal is reducing bugmail overload by offering more personalized features on the site, but as I said earlier, this particular feature only shows the last change, not all the unread changes, so you may miss important changes if you rely solely on this. I don’t have a plan to improve the current My Dashboard.

I can still load the bug if I think there might be more updates worthy my attention. This is a trade-off I've been willing to make and that has worked pretty well for me in the last few years. (Needless to say, it would be even better if the dashboard ignored CC list changes.) As a UX designer please try to sympathize with different individual workflows that may differ from what you'd consider the ideal workflow.

Comment 18

[Dão Gottwald [:dao]]

(In reply to Kohei Yoshino [:kohei] (Bugzilla UX) (FxSiteCompat) from comment #16)

My PR for Bug 1380437 has been merged to master and will be pushed to production probably later next week, so let’s see if it solves the issue.

Seems like it didn't?

Comment 19

[Kohei Yoshino [:kohei]]

I’ll ask to do a release tomorrow.

Comment 20

[Kohei Yoshino [:kohei]]

Hmm, now I can reproduce the issue locally. Bug 1380437 didn’t fix the issue; the REST API still returns an error. I’ll try to debug it.

Comment 21

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request

Comment 22

[Kohei Yoshino [:kohei]]

It doesn’t look like a recent regression, and I still don’t know why it only happens to some people, but I could figure out the cause and develop a solution.

Comment 23

[Dão Gottwald [:dao]]

(In reply to Kohei Yoshino [:kohei] (Bugzilla UX) (FxSiteCompat) from comment #22)

It doesn’t look like a recent regression, and I still don’t know why it only happens to some people, but I could figure out the cause and develop a solution.

Thanks!

Comment 24

[Kohei Yoshino [:kohei]]

Merged to master.

Comment 25

[colormatch]

Still not working here.

Comment 26

[Kohei Yoshino [:kohei]]

This will be fixed on production later today.

Comment 27

[Kohei Yoshino [:kohei]]

The fixed deployed a couple of minutes ago.