1570878 - (fennec-onboarding-signin) Add a sign-in button to each Fennec onboarding card

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: First Run, enhancement, P1)

Description

[Chris Peterson [:cpeterson]]

Attachment: UX_sketch.png

Project plan: https://docs.google.com/document/d/1njMzQ4NGCN___ms2a2dkgVC4fi1OkWIaqxp3Y-vZLYw/edit
PI request: https://jira.mozilla.com/browse/PI-227

1. Add sign-in button and call-to-action to every onboarding card.
2. UX team will re-examine content and apply onboarding principles (make actionable, provide value).

Will we need new UI strings to be translated?

Comment 1

[Chris Peterson [:cpeterson]]

New UX design screenshots and strings for onboarding cards:
https://docs.google.com/document/d/1RF-h7po7YFqpHYeYwt-oYFvSU8Hypn9pAVHF7x_njcM/edit

Adding [fennec68.1.x] whiteboard tag because we'll want to ship this in a Fennec ESR 68.1.x dot release in mid-September. We won't be ready in time to ship in Fennec ESR 68.1 on September 3.

Comment 2

[Vlad Baicu]

Attachment: Bug 1570878 - Add sign-in buttons to onboarding. r=petru

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cb44232fce2
Add sign-in buttons to onboarding. r=petru

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3cb44232fce2

Comment 5

[Eliza Balazs]

Verified as fixed on 71.0a1 (2019-09-10) with

• Samsung Galaxy Tab S3 (Android 8; Tablet);
• Huawei Honor 8 (Android 7.0);
• OnePlus 5T (Android 9);
• Google Pixel XL (Android Q).
  I will mark this as verified on Firefox 71.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Did this actually get uplifted to ESR68? Can you request uplift if you're intending it to go into the next ESR?

Comment 7

[Chris Peterson [:cpeterson]]

(In reply to Liz Henry (:lizzard) from comment #6)

Did this actually get uplifted to ESR68? Can you request uplift if you're intending it to go into the next ESR?

This bug hasn't been uplifted yet because we there were some string changes and maybe some upcoming UI design tweaks. We think it's best to uplift all the patches together.

Comment 8

[Vlad Baicu]

Yes, we're currently waiting for the UI resources for the new onboarding panels. These patches should all be uplifted at the same time

Comment 9

[Chris Peterson [:cpeterson]]

(In reply to Vlad Baicu from comment #8)

Yes, we're currently waiting for the UI resources for the new onboarding panels. These patches should all be uplifted at the same time

Sean posted SVG images for the Onboarding panels in Slack:

https://mozilla.slack.com/files/U4DCXTFL5/FNJ52JWCD/fennec_firstrun_illustrations.zip

Comment 10

[Vlad Baicu]

Attachment: Bug 1570878 - Update fenenc onboarding content.r=petru

Comment 11

[Vlad Baicu]

Comment on attachment 9090689 [details]
Bug 1570878 - Add sign-in buttons to onboarding. r=petru

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Part of the new sign up buttons feature
• User impact if declined: The sign up feature cannot be shipped without this patch
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This new feature will be validated with a PI request and has already undergone some testing.
• String or UUID changes made by this patch:

Comment 12

[Vlad Baicu]

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1576170#c23 for the landing order of the sign up button feature patches.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9090689 [details]
Bug 1570878 - Add sign-in buttons to onboarding. r=petru

New Fennec awesomescreen work targeting 68.2. Approved for Fennec 68.2b6.

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/78c3d1054080
https://hg.mozilla.org/releases/mozilla-esr68/rev/749f9c937ab9

Comment 15

[Chris Peterson [:cpeterson]]

Resolving as fixed because the Onboarding buttons landed on ESR 68 in comment 14.

Comment 16

[Eliza Balazs]

Verified as fixed on RC 68.2.0 build 2, ESR 68.2b7 with

• Samsung Galaxy Tab S3 (Android 8);
• OnePlus 5T (Android 9);
• Prestigio Grace X5 (Android 4.4.2).

I will mark this as verified. Thanks!