1581377 - Address bar one-off search button container doesn't hide when disabling all one-off engines after landing patch from bug #1577181

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug.png

STR:

1. Have only 1 active One-Click Search Engine in Search tab ( about:preferences#search ) in Options ( about:preferences )
2. In Address Bar write "test"
   and see that there is useless empty white space below urlbar dropdown when one-off buttons are hidden.

Kinda similar to bug #1569478.

Regression caused by:
Bug #1577181 - Fix one off search button overflow layout in the urlbar. r=harry

Differential Revision:
https://phabricator.services.mozilla.com/D45826

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: no bug.png

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1581377 - Let display:flex not override the hidden attribute on the one off search button container. r=mak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7b4285cc245
Let display:flex not override the hidden attribute on the one off search button container. r=harry

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a7b4285cc245

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 71.0a1 (2019-09-18), so I'm marking this bug as VERIFIED.
Thank you very much for instant fix! \o/

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 9093222 [details]
Bug 1581377 - Let display:flex not override the hidden attribute on the one off search button container. r=mak

Beta/Release Uplift Approval Request

• User impact if declined: see comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: bug 1577181
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial fix
• String changes made/needed:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9093222 [details]
Bug 1581377 - Let display:flex not override the hidden attribute on the one off search button container. r=mak

Visual fixup for the one off search buttons in the urlbar. Approved for 70.0b8.

Comment 10

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/5a0bc7ae7930