Closed Bug 1599979 Opened 2 years ago Closed 2 months ago

[meta] Enable LSNG on Release

Categories

(Core :: Storage: localStorage & sessionStorage, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
93 Branch
Fission Milestone MVP
Tracking Status
firefox92 --- fixed
firefox93 --- fixed

People

(Reporter: janv, Assigned: janv)

References

(Depends on 2 open bugs, Blocks 6 open bugs, Regressed 1 open bug)

Details

(Keywords: meta, Whiteboard: fission-hard-blocker)

Attachments

(1 file)

No description provided.
Depends on: 1482662

We are still working on fixing/reducing storage initialization failures (required for enabling LSNG on release), but it will take some time. So I'm not working on a patch for enabling LSNG on release right now.

Assignee: jvarga → nobody
Blocks: 1445464
Blocks: 1341070
Blocks: 1670644
Depends on: 1711922

We want to soft-enable LSNG now during the 90 and 91 release lifetime via experimenter. The other dependencies here are not expected to be blocking ones for this staged rollout.

Bug 1482662 is to be considered sufficiently covered. The remaining failures are mostly things we cannot really influence and are monitored by bug 1702411. This will be an effort that continues also after release.

For bug 1683401 we want to enable QM_TRY telemetry in order to have a better understanding of frequency and nature. Until then we consider it to be non-blocking based on the lack of other reports from nightly/early beta.

Tracking LSNG for Fission's MVP milestone. LSNG fixes some Fission localStorage issues, so LSNG is tentatively a blocker for Fission. We plan to auto-enable LSNG when Fission is enabled in bug 1720966.

Fission Milestone: --- → MVP

This bug is a hard blocker for Fission MVP.

Whiteboard: fission-hard-blocker

(In reply to Jens Stutte [:jstutte] from comment #2)

We want to soft-enable LSNG now during the 90 and 91 release lifetime via experimenter. The other dependencies here are not expected to be blocking ones for this staged rollout.

After that bug 1717990 landed we registered a significant improvement of the success rate for temporary storage (which was always the concerning number that prevented us from shipping), these numbers are now confirming also on the early-beta channel 91b (>= 99.98% success rate). Given this and the incompatibility of our current preference with the way experimenter handles staged rollouts, we decided to let LSNG just ride the trains to FF 92 and instead of fixing the staged rollout to invest in bug 1722668.

we decided to let LSNG just ride the trains to FF 92 and instead of fixing the staged rollout to invest in bug 1722668.

Awesome news. If LSNG is riding the trains with FF 92, then the Fission team won't need to force-enable LSNG for Fission users (bug 1720966).

See Also: → 1720966
Assignee: nobody → jvarga
Status: NEW → ASSIGNED

FYI, I'm finishing work on the storage cleanup and if it doesn't land before the merge next week, we will request an uplift to beta.

Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e165d93f022c
Enable LSNG on Release; r=dom-storage-reviewers,jari,jstutte
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

Comment on attachment 9235016 [details]
Bug 1599979 - Enable LSNG on Release; r=#dom-storage

Beta/Release Uplift Approval Request

  • User impact if declined: Fission experiments on beta/release need LSNG enabled.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): LSNG has been enabled on Nightly and early beta for long time The telemetry for storage initialization success rate is now around 99.98% (high amount of storage initialization failures prevented LSNG from being enabled on Release in the past).
  • String changes made/needed: None
Attachment #9235016 - Flags: approval-mozilla-beta?

Comment on attachment 9235016 [details]
Bug 1599979 - Enable LSNG on Release; r=#dom-storage

Let's roll. Approved for 92.0b5.

Attachment #9235016 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Blocks: 1586812
Regressions: 1730419
You need to log in before you can comment on or make changes to this bug.