160001 - atsui display code show text incorrectly

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Frank Tang]

When I visit http://people.netscape.com/ftang/testscript/gb18030/gb18030.cgi?page=52
or some page similar to that. the text drawn by ATSUI change when I mouse over. 

The first part of change in 

http://bugzilla.mozilla.org/attachment.cgi?id=93064&action=view
seems solve this issue.e

Comment 1

[Frank Tang]

that patch is submitted in 111728. I do not agree with the 2nd part. but the
first part is very good to take. 

Comment 2

[Frank Tang]

Attachment: patch address the atsui issue

submitted by [e-mail] (Henri Sivonen) in bug 111728

Comment 3

[Frank Tang]

Comment on attachment 93201 [details] [diff] [review]
patch address the atsui issue

r=ftang

Comment 4

[Frank Tang]

ask sfraser to sr

Comment 5

[Simon Fraser [no longer active]]

Comment on attachment 93201 [details] [diff] [review]
patch address the atsui issue

sr=sfraser

Comment 6

[Greg K.]

PC/Mac OS X? I doubt it. Setting Platform to Mac.

Comment 7

[rbs]

> Re: bug 111728 comment 11 From Henri Sivonen  2002-07-27 15:25 -------
>
> non-MacRoman chars getting cached somewhere in such a way that the
> first-rendered char gets repeated when Mozilla is supposed to draw the next

The patch for bug 107146 fixes this bug by clearing the ATSUI cache. It turned
out during testing that the MathML metrics were incorrect (i.e., constant) and
shofield contacted Apple: ATSUI doesn't clear its cache if the pointer is the
same. So clearing the cache seems more intelligible and will bullet-proof
against other oddities that might be lurking there.

Comment 8

[Henri Sivonen (:hsivonen)]

I don't know what the implications of the different approaches are.

I tried to re-apply the style, because Apple suggests it in the docs:
http://developer.apple.com/techpubs/macosx/Carbon/text/ATSUI/Apple_Type_S_code_Imaging/Functions/Assigning_an_pdating_Text.html

Comment 9

[Henri Sivonen (:hsivonen)]

According to Apple's documentation, ATSUClearLayoutCache isn't available on Mac
OS 8.5.

Comment 10

[Frank Tang]

how about using ATSUClearLayoutCache  for TARGET carbon and use the current
patch for non Carbon?
Is ATSUClearLayoutCache  available on MacOS X?

Comment 11

[Henri Sivonen (:hsivonen)]

Accoding to the docs, ATSUClearLayoutCache is available on OS X.

If ATSUClearLayoutCache is called, should ATSUSetRunStyle be called nonetheless,
since the docs say it should be called after updating the text pointer? 

Comment 12

[Greg K.]

This seems to WorkForMe using FizzillaCFM/2002080303. The text doesn't change on
mouseover.

Comment 13

[Henri Sivonen (:hsivonen)]

It appears that this one got fixed along with the MathML landing. I haven't
tested what happends if you --disable-mathml, but disabling MathML is uncool
anyway. :-)

Comment 14

[Frank Tang]

mark it as fixed . it is really fixed by other bug (the mathml patch)

Comment 15

[Greg K.]

Not sure which MathML bug fixed it, so let's depend on the basic one.

Comment 16

[Yuying Long]

This is fixed in 09-16 trunk build, but I wonder why I still see this problem on
09-12 branch build, because the math bug 155703 was checked in quite a long time
ago.
Not sure if it is related with surrogate support checked-in trunk build.

I'm marking this as verified as fixed based on trunk build result.  Please
re-open if we should get this in branch.