1605359 - Page.getFrameTree has to return details for all frames in the current tab

Status: RESOLVED FIXED

(Remote Protocol :: CDP, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Right now we simply return a list of frames that gets constructed each time when Page.getFrameTree gets called. This is totally inefficient, and we should make it dynamic. Means it might have to handle the Page.frameAttached (bug 1599413) and Page.frameDetached (bug 1599773) events.

As Andreas mentioned to me maybe the browsing context class already has such a feature which we would only have to iterate over. It's worth a check.

But this is all Fission related.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Note that the current implementation also lives on the content side of Page.jsm. It would have to be moved to domains/parent/Page.jsm.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

To properly implement Page.frameAttached and Page.frameDetached I need an implementation of a frame tree class. As such we need this bug in our MVP, and bug 1601421 is moved to the backlog.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The dynamic handling of frames is actually implemented in Puppeteer, and that's not needed here. What we have to do is to return all the frames for the current tab, including nested and x-origin ones. This can easily be done now that we have the browsing context tree.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1605359 - [remote] Page.getFrameTree has to return details for all frames in the current tab.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3221bde9f2a
[remote] Page.getFrameTree has to return details for all frames in the current tab. r=remote-protocol-reviewers,maja_zf

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c3221bde9f2a