164323 - Do not use Ctrl+Enter in URL bar for new window

Status: VERIFIED DUPLICATE of bug 37867

(SeaMonkey :: Location Bar, enhancement)

Description

[http://tinymailto.com/oliversl]

If a user wants to open a new URL in a new Window, he can do this:
1. Press Ctrl+N or Ctrl+T
2. type www.yahoo.com (The focus of the new window should be in the URL Bar)
3. press ENTER

Ctrl+Enter can be used for other thinks.

Please note that I'm not asking auto-completion, so, no dot mark as
duplicate of bug #37867 nor bug #164309

This is only my sugestion, close if you want.

Comment 1

[http://tinymailto.com/oliversl]

Attachment: Patch for Ctrl+Enter like IE

Comment 2

[http://tinymailto.com/oliversl]

Ok, here is the patch.
This should replace the function BrowserLoadURL(aTriggeringEvent) in
seamonkey/source/xpfe/browser/resources/content/navigator.js

Thanks to biesi and sirLuxarot.

I have compiled only in my head, but it should work becouse it is
code from functions already in use.

Patch name: "Patch for Ctrl+Enter like IE"

Comment 3

[Daniel Wang]

original description is not a RFE:
- a perference already exists for not using it
- too vague, no actual feature or added behavior proposed
- see bug 97123: modifier+Enter in address field and go button should
  behave like modifier+click on link
- see also bug 120898: Ctrl-Click and Middle Mouse Button Click for
  new tabs should be separate options
- see also bug 37867: [RFE] Domain Guessing via keyboard shortcut
  (ctrl-enter)

Reporter, I am confused about the patch. Is it for treating Ctrl+Enter
as normal IE-like domain completion shortcut /if/ Ctrl+Enter is set
by Preferences not to be used for loading url in a new tab? OR is it
for loading url in a new tab and doing domain name completion if
neccessary?

btw, please help kill the RFE keyword. "enhancement" severity is
good enough.

Comment 4

[Jesse Ruderman]

When these bugs are fixed, it will be easier to open a specific address in a new
window using Ctrl+N,Ctrl+L, and Ctrl+Enter will become unnecessary.

 49141 New window performance
 55015 while opening a window, keys should not be accepted by the last active one.
125282 JS shouldn't steal focus when in URL bar
164339 address bar loses focus after Ctrl+N,Ctrl+L when home page loads

I'm ok with changing Ctrl+Enter now, without waiting for those bugs to be fixed.
 Making Enter in the address bar search rather than do domain completion is more
important than having Ctrl+Enter in the address bar open a new window rather
than do domain completion.

Comment 5

[http://tinymailto.com/oliversl]

Will post a new patch in .diff file soon

Comment 6

[http://tinymailto.com/oliversl]

Attachment: dns-autocorrect.patch

I tested this one in Mozilla 1.0.1 RC1 WinXP

Comment 7

[http://tinymailto.com/oliversl]

Ok,
the dns-autocorrect.patch is ready!
I try to modify the less prosible the original file
to get a small patch.

What this patch does?
It replace opening a new window when the user press Ctrl+Enter on the URL bar.

When the user press Ctrl+Enter, the url is passed to:
gURIFixup.createFixupURI(url,
Components.interfaces.nsIURIFixup.FIXUP_FLAGS_MAKE_ALTERNATE_URI);
This will autocomplete the domain.

All other functions are intact, like Alt+Enter or Shift+Enter.

I tested it in Mozilla 1.0.1RC1 on WinXP and works just fine! :-)

I created the patch like this:
diff -u navigator_old.js navigator.js > dns-autocorrect.patch

It is for the file:
http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/navigator.js

Also, the credits can be removed from the patch, but since this is my first
patch, I left it in the patch.

Comment 8

[Tim]

Comment on attachment 96505 [details] [diff] [review]
dns-autocorrect.patch

Fixed MIME type, marked it as a patch.

Comment 9

[http://tinymailto.com/oliversl]

Attachment: dns-autocorrect.diff

This is the same as dns-autocorrect.patch with cosmetic changes to the
comments.

Comment 10

[http://tinymailto.com/oliversl]

Attachment: dns-autocorrect-2.patch

Last cosmetic change. Converted tabs to spaces to match the original file
navigator.js. Also teting Attachments in Bugzilla. :-)

Comment 11

[http://tinymailto.com/oliversl]

Attachment: ctrl-enter-delete.patch

This patch is more consisten con the description of this bug

Comment 12

[http://tinymailto.com/oliversl]

Comment on attachment 96550 [details] [diff] [review]
ctrl-enter-delete.patch

This patch delete the new window creation whenpressing ctrl-enter in the URL
bar

Comment 13

[http://tinymailto.com/oliversl]

Hi,
I sumited this patch: ctrl-enter-delete.patch

The only thing this patch does is delete the Ctrl+Enter behaivior. So, pressing
Ctrl+Enter in the URL does nothing.

This patch is more consistent with this bug description.
The patch dns-autocorrect-2.patch is also working, but it adds
the dns-autocompletion feature, which is not asked in this bug.

I will rename dns-autocorrect-2.patch to dns-completion-ctrl-enter.patch
and post it to bug #37867, because there is where all this started.

Comment 14

[Jonas Jørgensen]

I am strongly opposed to this.

1) Not opening a new window/tab for Ctrl+Enter would be inconsistent (see bug
70501).

2) If I'm reading http://example.com/page1.html and I want to read page2.html
afterwards, I can hit Ctrl+L, change the "1" to "2", hit Ctrl+Enter, and the
page will load in a new background tab (currently it will actually load in the
foreground; that is bug 162189). If we do as is proposed in this bug, I would
have to:
   1) hit Ctrl+L
   2) hit Ctrl+C
   3) hit Ctrl+T or Ctrl+N
   4) hit Ctrl+V
   5) change the "1" to "2"
   6) hit Enter
   7) hit Alt+Tab or as many Ctrl+PageUp/PageDown's as required to focus the
      current tab.

3) The only reason for removing the Ctrl+Enter shortcut is to pave the way for
implementing bug 37867, which a) is widely regarded as being "bad for the web"
and b) might as well be done with *any* other keyboard combo than Ctrl+Enter
(no, consistency with IE doesn't matter much here -- if that was the case, we'd
also be changing Shift+Enter on links to open in a new window rather than saving).

I highly recommend WONTFIX.

Comment 15

[http://tinymailto.com/oliversl]

comment #14
Hi Jonas,
I have been talking in #mozillazine about this topic.
The main reason for keeping this Ctrl+Enter thing is beacuse of the Ctrl+Click,
as you say, to have more consistency in Mozilla.

But, there are more issues here, like this:
1.Ctrl+Enter is highly used in IE and will help IE users migrate to Mozilla
2.For the common "dumb" user, typing an URL and then having the page displayed
  on another window is strange. Even if the focus is changed to the new 
  window/tab.
  Is more easy to say, "type the URL in the window you want the page 
  to be displayed"
3.There are already 3 ways to open a new window: Ctrl+N, Ctrl+T, Ctrl+Shift+L
  Do we really need a 4th one? Even if we sacrify a commonlly used feature
  as dns-autocompletion?
4.If you are watching http://example.com/page1.html, I can bet there will
  be a link to page2.html inside page1.html

I understand that accepting this bug will change Mozilla behavior, but the 
person in charge of making this decision already agree with this bug.

I hope he can process this bug next week.

Also, the bug #164323 and bug #37867 are mutually exclusive and I think
a path should be taken and close one of these bug.

Comment 16

[http://tinymailto.com/oliversl]

Trying to build a dependency tree ...

Comment 17

[Sander]

I agree with comment 14, and want to second the request for WONTFIX.
Particularly point 2 describes why this would be a bad change. In fact, ctrl-L,
ctrl-enter is currently the closest people can get to the IE feature of opening
new pages with the same page loaded as the page from which it was opened. Though
I personally loathe that behaviour, many people are quite fond of it; removing
the closest appromiation to it would be a bad idea.

Comment 18

[http://tinymailto.com/oliversl]

One last resort to unite us all will be to make Ctrl+Enter an option in 
the preferences window.
The user decide. Something like this, using radio buttons:

Ctrl+Enter behaivior:
( ) open new window
( ) dns autocompletion

All patches for DNS autocompletion now goes to bug #37867

Comment 19

[Daniel Wang]

comment #1:
> Please note that I'm not asking auto-completion, so, no dot mark as
> duplicate of bug #37867 nor bug #164309

comment #7:
> What this patch does?
> It replace opening a new window when the user press Ctrl+Enter on
> the URL bar.
>
> When the user press Ctrl+Enter, the url is passed to:
> gURIFixup.createFixupURI(url,
> Components.interfaces.nsIURIFixup.FIXUP_FLAGS_MAKE_ALTERNATE_URI);
> This will autocomplete the domain.

The original description is not an enhancement request, and the
patches posted do what bug 37867 asks for. Please repost your patches
to bug 37867. If you disagree, please open a new bug, make reference
to bug 97123, bug 120898, and bug 120898, and make sure you are
consistant with yourself.

*** This bug has been marked as a duplicate of 37867 ***

Comment 20

[Daniel Wang]

comment #18
> One last resort to unite us all will be to make Ctrl+Enter an option in
> the preferences window.

Yes, that will be a good description for the new bug.
btw, I'd suggest use check boxes :)

Comment 21

[http://tinymailto.com/oliversl]

comment #19
Yes, I agree. I was confused and posted the patch incorrectly here.
I have already posted the patch for auto-completion in bug #37867.
The current patch in this bug does what the original description
ask for.
It just ignores the Ctrl+Enter in the URL Bar.

comment #20
mmm, thats a nice Idea. Maybe I will open such request, because some
people are 100% for open a new window and also there are people that
100% for the autocompletion.
Since this bug was closed, maybe a new one sugesting the radio buttons
should be the one we need.

Comment 22

[http://tinymailto.com/oliversl]

Since bug #164323 blocks (you can't use autocompletion if Ctrl+Enter 
is already taken for open new window) bug #37867 and bug #37867 is still open,
this bug #164494 can be the solution.
It makes both partys happy, but more work should be done in preference window.

Comment 23

[http://tinymailto.com/oliversl]

comment #20
The new patch that implement this checkbox option is up.
Look at the patch dns-completion-ctrl-enter-4.patch in bug #37867

You can configure your prefs if you want bug #37867 to work.
Also, now only a GUI change in the preference window is needed
for bug #164494.

Comment 24

[Jonas Jørgensen]

removing dependencies: bug 37867 can't depend on this if this is a dupe of
37867, contrary to bug 70501 this makes ctrl+enter/click less consistent instead
of more, bug 162189 can and will be fixed without this one, bug 162807 likewise.
those bugs had no place in the otherbugsdependingonthis field of this bug anyway.

and verified dupe.