1659241 - Cannot add new mail account from account settings UI

Status: VERIFIED FIXED

(Thunderbird :: General, defect, P1)

Description

[Asif Youssuff]

Steps to reproduce:

1. Have at least one account set up
2. Navigate to account settings
3. click "account actions" button menu
4. select "add mail account"

What happens:

Nothing.

Expected result:

Add mail account UI window appears.

--

2020-08-15T02:25:30.783000: DEBUG : Found commit message:
Bug 1655289 - Fix UI issues with tooltips and opening dialogs in new Account Central. r=Paenglab

2020-08-15T02:25:30.783000: DEBUG : Did not find a branch, checking all integration branches
2020-08-15T02:25:30.783000: INFO : The bisection is done.
2020-08-15T02:25:30.798000: INFO : Stopped

Comment 1

[Wayne Mery (:wsmwk)]

Asif, thanks for finding the regression.
This will block release of 78.2

Comment 3

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

Attachment: Fix

There is a logged exception in TB 78.2.0-pre build 1:

[Exception... "Illegal value" nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)" location: "JS frame :: chrome://messenger/content/accountUtils.js :: msgNewMailAccount :: line 523" data: no]

accountUtils.js:523 uses the raw account manager window

window.openDialog(

but it should probably be

window.docShell.rootTreeItem.domWindow.openDialog(

See attached patch for the trivial fix (relative to comm-central for convenience, but I did not actually build comm-central).

Comment 4

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

Attachment: Fix v2, comm-central

Sorry, wrong branch – the previous patch was not suitable for comm-central, as rootTree has since been obsoleted in bug 1638153. The new convention there is

window.browsingContext.topChromeWindow.openDialog(

So this is the patch for comm-central, and I'll provide the original patch with the correct comm-esr78 header once the source tree finishes downloading...

Comment 5

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

Attachment: Fix v2, comm-esr78

Patch for comm-esr78. This is essentially the original fix posted earlier, but with the correct header for comm-esr78.

Again sorry for the confusion!

Comment 7

[Wayne Mery (:wsmwk)]

Are we able to add an automated test?

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9170206 [details] [diff] [review]
Fix v2, comm-central

Review of attachment 9170206 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch! r=mkmelin

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/956e5e6501b3
Fix new mail account dialog, r=mkmelin

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9170207 [details] [diff] [review]
Fix v2, comm-esr78

[Approval Request Comment]
Regression caused by (bug #): bug 1655289
User impact if declined: can't add an account from within the account manager
Testing completed (on c-c, etc.): yes - but this patch is different on trunk/78 due to m-c changes
Risk to taking this patch (and alternatives if risky): not risky but should be verified once landed

Comment 11

[Magnus Melin [:mkmelin]]

To clarify, since beta 78 are different testing on beta wouldn't have helped here.

Comment 12

[Jorg K (CEST = GMT+2)]

Comment on attachment 9170206 [details] [diff] [review]
Fix v2, comm-central

We should still fix beta. Is this the right patch or the other one?

Comment 13

[Magnus Melin [:mkmelin]]

Yes trunk and beta would have the same fix. The incompatibility is from bug 1639107 (version 79)

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9170206 [details] [diff] [review]
Fix v2, comm-central

[Triage Comment]
Approved for beta

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9170207 [details] [diff] [review]
Fix v2, comm-esr78

[Triage Comment]
Approved for esr78

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 80.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/319fac6c3985

Comment 18

[WaltS48 [:walts48]]

I created my Comcast account, then used Account Settings > Account Actions > Add Mail Account to add my Gmail account in my test of the 80.0b5 release candidate on Ubuntu 18.04.5 LTS.

No problems encountered.

Comment 19

[Rob Lemley [:rjl]]

Thunderbird 78.2.0:
https://hg.mozilla.org/releases/comm-esr78/rev/79026cb30306

Comment 20

[WaltS48 [:walts48]]

Another one not working in my testing of the 78.2.0 release candidate on Ubuntu 18.04.5 LTS. New profile.

Works when testing the correct build.

Comment 21

[klaus]

is this available somewhere for testing 78.2 pre? (as installable version?).

Otherwise, no testing of 78,2pre is possible, I am not able to add any account

The link in planning still points to a version where this does not work

Comment 22

[Magnus Melin [:mkmelin]]

https://archive.mozilla.org/pub/thunderbird/candidates/78.2.0-candidates/build1/

Comment 23

[klaus]

please reopen, this is still broken in 78RC1 on win10 64bit

Comment 24

[Magnus Melin [:mkmelin]]

This is WFM at least on linux using one the candidates from comment 23.
If you see a problem, please post details STR in a new bug.

Comment 25

[rsjtdrjgfuzkfg (Dirk Steinmetz)]

(In reply to klaus from comment #23)

please reopen, this is still broken in 78RC1 on win10 64bit

WFM on Windows 10 x64 with Thunderbird 78.2.0-rc1 x64. Either "78RC1" refers to an old build, or you found a different bug.
In the latter case, please open a new bug with your STR as indicated by mkmelin.

Comment 26

[klaus]

what is WFM and STR?
I mean 78.2 RC1 as linked on planning

Comment 27

[Magnus Melin [:mkmelin]]

Works for me and Step to reproduce.

Which planning link? Is it the same as comment 22?

Comment 28

[klaus]

Thanks.
yes that link. Downloaded this morning.
As Wayne implied elsewhere, works after TB restart (same for folder pane, calendar display)