Thunderbird: install option `/RemoveDistributionDir=false` fails for setup.exe (and REMOVE_DISTRIBUTION_DIR wrapper via MSI)
Categories
(Thunderbird :: Installer, defect, P3)
Tracking
(thunderbird_esr78 fixed, thunderbird86 affected)
People
(Reporter: guser, Assigned: rjl)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-esr78+
|
Details | Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0
Steps to reproduce:
Run msiexec /i "Thunderbird Setup 78.2.1.msi" REMOVE_DISTRIBUTION_DIR=false
Actual results:
C:\Program Files\Mozilla Thunderbird\distribution folder is removed.
Expected results:
Do not remove existing C:\Program Files\Mozilla Thunderbird\distribution folder.
Comment 2•3 years ago
|
||
Reporter appears to be gone. I have not verified steps, nor whether this should work.
Comment 3•3 years ago
|
||
(In reply to Wayne Mery (:wsmwk) from comment #2)
Reporter appears to be gone. I have not verified steps, nor whether this should work.
This should work in Thunderbird.
- Bug 1538218 has been fixed on mozilla-central 2 years back.
- Correctly seen in Thunderbird code base:
https://searchfox.org/comm-central/search?path=&q=REMOVE_DISTRIBUTION_DIR - Referenced in FF support documentation:
https://support.mozilla.org/en-US/kb/deploy-firefox-msi-installers#w_firefox-custom-msi-options
Would be nice to have a Thunderbird-branded copy of that support document, will look into that.
Updated•3 years ago
|
Comment 4•3 years ago
|
||
(In reply to Thomas D. (:thomas8) from comment #3)
https://support.mozilla.org/en-US/kb/deploy-firefox-msi-installers#w_firefox-custom-msi-options
Would be nice to have a Thunderbird-branded copy of that support document, will look into that.
I've recently created a completely overhauled edition for Thunderbird@work:
https://app.gitbook.com/@thunderbird/s/enterprise-docs/deploy/deploy-thunderbird-with-msi-installers
Comment 5•3 years ago
•
|
||
From my own tests, confirming this bug exactly as described.
This will be an annoying fallout for enterprise admins deploying Thunderbird using /distribution subfolder with policies.json configuration file.
Rob, would you be able to look into this?
-
The MSI option gets internally translated to an option for the full installer (setup.exe):
https://searchfox.org/comm-central/search?path=&q=REMOVE_DISTRIBUTION_DIR
setup.exe... /RemoveDistributionDir=[REMOVE_DISTRIBUTION_DIR]
-
The setup.exe command line option of full installer fails:
"Thunderbird Setup 78.7.1.en.64.exe" /RemoveDistributionDir=false /s
I verified that the /distribution subfolder folder inside TB app folder gets removed anyway. -
So the MSI wrapper option is also bound to fail (and so it does):
msiexec /i "Thunderbird Setup 78.7.1.msi" REMOVE_DISTRIBUTION_DIR=false
Pertinent documentation:
Thunderbird: Deploy Thunderbird with MSI installers, which lists the options for MSI install.
Firefox: Full Installer Configuration, which lists the command line options for setup.exe (by analogy for TB).
Assignee | ||
Comment 7•3 years ago
|
||
The block of code in the installer that looks for that argument is missing. Was added to the Firefox installer in bug 1425468.
Here's a try build with a fixed installer. I'm crossing fingers that I don't need to update the self-extract stub as well. I'm pretty sure we've updated ours between then and now.
Assignee | ||
Comment 8•3 years ago
|
||
This was added for Firefox in bug 1425468.
Updated•3 years ago
|
Assignee | ||
Comment 9•3 years ago
|
||
Of course the build broke for other reasons just as I submitted that try build...
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/3f1c2fbab3bd
Add missing commandline arguments to Windows installer. r=Paenglab
Assignee | ||
Comment 11•3 years ago
|
||
Verified this works on nightly 20210217180538. Used the MSI installer with REMOVE_DISTRIBUTION_DIR=false
for testing purposes.
Assignee | ||
Comment 12•3 years ago
|
||
Comment on attachment 9202978 [details]
Bug 1663391 - Add missing commandline arguments to Windows installer. r=Paenglab
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: This mostly affects enterprise users who want to keep the distribution directory in tact when upgrading. Without this fix, the installer option to preserve the distribution directory has no effect.
Testing completed (on c-c, etc.): on nightly
Risk to taking this patch (and alternatives if risky):
Code was copied from the Firefox installer code and has been in use there for some time. It only adds the additional arguments to the installer and will not affect most users as the defaults do not change.
Comment 13•3 years ago
|
||
Comment on attachment 9202978 [details]
Bug 1663391 - Add missing commandline arguments to Windows installer. r=Paenglab
[Triage Comment]
Approved for esr
Assignee | ||
Comment 14•3 years ago
|
||
bugherder uplift |
Thunderbird 78.8.1:
https://hg.mozilla.org/releases/comm-esr78/rev/a42457a09d33
Comment 15•3 years ago
|
||
Thank you very much Rob for fixing this!
Description
•