1695292 - update tabstrip scroll buttons hover state to be consistent with Proton design

Status: VERIFIED FIXED

(Firefox :: Theme, enhancement, P3)

Description

[Will]

Attachment: tabstrip scroll button hover.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:88.0) Gecko/20100101 Firefox/88.0

Steps to reproduce:

Hover cursor over tabstrip scroll buttons and observe it isn't consistent with the rest of tabstrip hover states design, it's too tall and the corners aren't rounded. See attached screenshot

Comment 1

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

From Katie, "like a ghost button - background square with rounded corners". The button should look similar to the New Tab and All Tabs buttons, which are tracked by bug 1696535.

Comment 3

[katieC]

I'm going to update the spec in Figma because the the chevron-right should be not full square width on hover (like a ghost) but custom in width (...and with rounded corners). Jared, I'll comment at you in Figma to take a look... when it's mocked up and ready. :)

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

This is still waiting on a spec from UX.

Comment 5

[katieC]

Attachment: screesnhot_tabstrip_srollbtn_hoverstate.png

please see Figma file and attached sreenshot.
Notes:
• Same buttons states as other ghost buttons
• Same corner radius

Comment 7

[Will]

gentle reminder :)

Comment 8

[Dão Gottwald [::dao]]

Attachment: Bug 1695292 - update tabstrip scroll buttons hover state to be consistent with Proton design. r=jaws

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48c2e15e0472
update tabstrip scroll buttons hover state to be consistent with Proton design. r=jaws

Comment 10

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1695292, Bug 1696438) for causing xpcshell failures in test_trr_cancel.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/20cda15a5e4a486d289a4fcfc5ab0997789fd48c
Push with failures, failure log.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/494b00f94236
update tabstrip scroll buttons hover state to be consistent with Proton design. r=jaws

Comment 12

[Cosmin Sabou [:CosminS]]

Bugs Bug 1700076, Bug 1699691 were backed out instead: https://hg.mozilla.org/integration/autoland/rev/dae7fefaf8278e53d864391a50ae947d5ce5747a

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/494b00f94236

Comment 14

[Hani Yacoub]

Verified as fixed on Firefox Nightly 89.0a1 (2021-04-15) on Windows 10 x64, Ubuntu 20.04 x64 and on macOS 10.15.