169582 - [MSFT-6434] Mozilla windows restore when changing desktop settings (theme, appearance)

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Nicholas Allen]

Win2k 0912 trunk

Changing the system color scheme causes Mozilla to unminimize.

Steps:

1) Minimize Mozilla
2) Go to Window's Display Properties/Appearance and change the Scheme
3) Click Apply
4) Mozilla unminimizes

Comment 1

[Robert Praetorius]

also seen on NT 4.0 SP6a with Phoenix (
Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.2b) Gecko/20021001 Phoenix/0.2
) and Mozilla 1.2a (
Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.2a) Gecko/20020910
).  Happened to all open windows in both of these apps (but none of the many
other apps with minimized windows on my system).

This is relatively recent behavior (toggling schemes is something I have
occasion to do at least a few time a month, as my default scheme,
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=17629
is easy on my eyes but some text or icons become invisible 'cause they are
written black on black 'cause some software ignores the prefs)

Comment 2

[Boris Zbarsky [:bzbarsky]]

*** Bug 181749 has been marked as a duplicate of this bug. ***

Comment 3

[Robin Monks]

*** Bug 288336 has been marked as a duplicate of this bug. ***

Comment 4

[Bernard Alleysson]

*** Bug 291417 has been marked as a duplicate of this bug. ***

Comment 5

[Bernard Alleysson]

*** Bug 195738 has been marked as a duplicate of this bug. ***

Comment 6

[Bernard Alleysson]

Changing summary to "unminimize when changing desktop settings (system color
scheme, appearance)" to better find dupes

Comment 7

[mmortal03]

This is still present in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007112505 Firefox/3.0a6pre ID:2007112505.

Comment 9

[Jim Mathies [:jimm]]

Attachment: theme change popup patch v.1

Just a slight touch up here. We need to confirm windows wants us to activate the window before do so when checking the results of GetWindowPlacement.

Comment 10

[Ere Maijala (slow)]

Comment on attachment 361315 [details] [diff] [review]
theme change popup patch v.1

Nice :)

Comment 11

[Jim Mathies [:jimm]]

pushed to mozilla-central:

http://hg.mozilla.org/mozilla-central/rev/7b06fd9d1dd9

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

This will be fixed in Firefox 3.5. Do we want to back-port to Firefox 3.1 for correctness?

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 361315 [details] [diff] [review]
theme change popup patch v.1

Does this apply cleanly to branch? Cause any compatibility issues (we're changing nsWindow.cpp?)

Comment 15

[Jim Mathies [:jimm]]

(In reply to comment #14)
> (From update of attachment 361315 [details] [diff] [review])
> Does this apply cleanly to branch? Cause any compatibility issues (we're
> changing nsWindow.cpp?)

It's a one line change, I'm pretty sure it will. It's been on trunk now for two months with no issues.

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 361315 [details] [diff] [review]
theme change popup patch v.1

a191=beltzner

Comment 17

[Jim Mathies [:jimm]]

Attachment: landed 1.9.1

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/45a0acdba4fd