Closed Bug 1700487 Opened 1 year ago Closed 9 months ago

Open Account Provisioner dialog in a Tab

Categories

(Thunderbird :: Account Manager, task, P1)

Tracking

(thunderbird_esr91 wontfix)

RESOLVED FIXED
95 Branch
Tracking Status
thunderbird_esr91 --- wontfix

People

(Reporter: aleca, Assigned: aleca)

References

Details

Attachments

(2 files)

This bug will only deal with the following changes:

  • Open the Account Provisioner dialog in a Tab.

The following aspects will not be touched and will be tackled in follow up bugs:

  • Refreshing UI.
  • Removing jQuery in favor of vanilla JS.
  • String changes.

This is to keep the patches as small as possible and follow an incremental implementation path.

Adding an initial mock-up for the provisioner in a tab.
This needs more work but it's a start.

Adding bug 942615 as blocker for this since that patch is changing the startup stack, which consequentially affects this section.
Waiting for that bug to land before working on this to avoid dealing with constant merge conflicts.

Depends on: 942615
Keywords: leave-open

Would be possible to add a type attribute to the list of providers we're returning from this URL? https://broker.thunderbird.net/provider/list

That attribute would be useful to split the providers between the two forms, one for mail providers and the other for domain providers.
I think it would be nice to have that separation in order to make more clear the difference between services, and it would look nicer once we get more partners.

Flags: needinfo?(mkmelin+mozilla)

It should be possible to add something. Note that gandi does provide mail hosting of the domain you buy. So the distinction is more of sellsDomain vs not.

Flags: needinfo?(mkmelin+mozilla)

I talked to Andrei and he updated it with the new sells_domain boolean attribute.

No need to review this WIP patch, I pushed to phabricator as it's easier for me to quickly load it and push changes from multiple OSs.

Status: NEW → ASSIGNED

Comment on attachment 9242161 [details]
Bug 1700487 - Open Account Provisioner dialog in a Tab. r=mkmelin, ui-r=Paenglab

Still working on this as there are many moving pieces and a lot of things to consider.
So, I'm asking an early quick feedback/review to see if I'm going in the right direction.
Things are still partially broken, just FYI.

Here's a list of questions:

  • As we now have the mail and mail+domain provider split in 2 searches, does it make sense to have the checkboxes to enable/disable searchable providers? It might make sense if we expect to expand the list of providers soon, but we could live it like this if they're fairly static.
  • We used to prioritize the results matching the language of the user, but only for Gandi. Does this make sense to keep?
  • At the end of a successful account creation, we are currently reopening the Account Provisioner to show a "Success" page. I'd like to actually open the Account Setup Tab and show the final success page in order to reuse all the code to fetch connected calendars and address books. Dos this sound good?
  • We're currently storing the searched providers in a storedData object in order to append to the URL a bunch of possibly useful extra attributes. So far, those attributes are not used at all and the API call only expects a few attributes. Are we expecting to have extra attributes coming from other account providers? I'd like to remove that storedData object if it's not necessary.
  • Current providers don't seem to have a provider.search_engine attribute, are we still expecting to be using that?
Attachment #9242161 - Flags: feedback?(mkmelin+mozilla)
Attachment #9242161 - Flags: feedback?(mkmelin+mozilla)
Attachment #9242161 - Attachment description: WIP: Bug 1700487 - Open Account Provisioner dialog in a Tab. → Bug 1700487 - Open Account Provisioner dialog in a Tab. r=mkmelin, ui-r=Paenglab

This patch will also make bug 1694266 obsolete as the test causing the intermittent failure won't exist anymore.

See Also: → 1694266
Blocks: 1734484
Target Milestone: --- → 95 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/064e369ca9ee
Open Account Provisioner dialog in a Tab. r=mkmelin,Paenglab, ui-r=Paenglab

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/a98739fcb62e
follow-up - Stop redefining MailServices and Services in accountSetup.js. rs=bustage-fix
Regressions: 1735287
You need to log in before you can comment on or make changes to this bug.