171756 - add Confirmation dialog for Remove All passwords

Status: VERIFIED DUPLICATE of bug 390025

(SeaMonkey :: Passwords & Permissions, defect)

Description

[parish]

On clicking the Remove All button in Password Manager a confirmation dialogue
should pop-up to help prevent accidentally deleting all saved passwords (I've
just discovered the hard way that this doesn't happen :-( )

Comment 1

[Brant Gurganus]

[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.

Comment 2

[Michael Lefevre]

seems to me to be a legitimate RFE... confirming.

Comment 3

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Reassigning to new owner.

Comment 4

[Lord Kimberley]

Please provide this. It caught me out yesterday, when I clicked on the wrong
button. Either a confirmation, or a select All and then remove, as that is at
least two steps.

Comment 5

[parish]

That is a better idea; get rid of the Remove All button and force the user to
select all (Shift-click or Ctrl-A, on Windows) and then click Remove.

Is there any good reason for having a Remove All button?

This solution will also have the added benefit of /reducing/ the Mozilla code
rather than adding even more.

If there are no objections to this idea then I'll whip up a patch.

Comment 6

[parish]

Attachment: Get rid of the Remove All buttons

Patch that gets rid of the Remove All buttons on all the Manager windows (for
UI consistency).

Comment 7

[parish]

Attachment: Remove clearTree()

popupManager.js:clearTree() is now obsolete.

Comment 8

[u60234]

*** Bug 207371 has been marked as a duplicate of this bug. ***

Comment 9

[Matthias Versen [:Matti]]

*** Bug 208790 has been marked as a duplicate of this bug. ***

Comment 10

[Matthias Versen [:Matti]]

*** Bug 215410 has been marked as a duplicate of this bug. ***

Comment 11

[Stefan Borggraefe]

*** Bug 234731 has been marked as a duplicate of this bug. ***

Comment 12

[Matt]

Even with the confirm dialog, there should be an undo command in case of rushed
accidents. I just lost some passwords too. ;_;

Comment 13

[Tim Ramsey (he/him)]

And I just lost passwords.  Why hasn't this been rolled out yet, after 2.5
years?  What needs to happen to get this problem fixed?

I'd hoped that clicking on 'cancel' in the parent window, the main Preferences
dialogue, would cancel my oops.  No such luck.

Comment 14

[[e-mail]]

Comment on attachment 115981 [details] [diff] [review]
Remove clearTree()

This stuff looks good but as IanN moved everything around recently someone will
need to fix this up before requesting review from mvl or dwitte or whomever.

Comment 15

[Shriramana Sharma]

Why isn't the status of this changed to verified?

I lost my passwords like this too. Please include this feature as soon as possible.

I don't think including an undo feature (as someone else requested) is a must,
but it would certainly be an added plus. But undo should not be possible after
one has hit "OK" in the password manager window.

And Select All > Remove seems a good idea, as is making it the same for all the
Manager (I assume Cookie Manager too) windows. Though I have used Remove All in
the cookie manager window often, I can sacrifice that to get some other
advantage - namely of avoiding accidental erasure.

Comment 16

[Shriramana Sharma]

I request change of priority to normal, since losing vital information such as
passwords is hardly an "enhancement" issue. Hopefully this change will also
prompt someone to come up with a fix for this bug which lies unattended for
about at least two and a half years. Please guys, help us simple end-users who
don't know to create a fix ourselves. Thanks!

Comment 17

[Worcester12345]

This should not be in a release version. Requesting a block on final.

Comment 18

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

It's too late now, and there isn't any (recent) patch.  You can nominate this for SM1.1 in bug 315312 if you'd like. 

Comment 19

[Worcester12345]

(In reply to comment #18)
> It's too late now, and there isn't any (recent) patch.  You can nominate this
> for SM1.1 in bug 315312 if you'd like. 
> 

"You tried to change the Blocks field , but only the assignee or reporter of the bug, or a sufficiently empowered user may change that field."

Comment 20

[Thomas D. (:thomas8)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090913 Shredder/3.1a1pre

Current Thunderbird 3 nightly has the behaviour requested by this bug.
Maybe SeaMonkey happens to share the same code?
Do you still see this bug in current SeaMonkey nightlies? (Please mention your version)

Comment 21

[Jens Hatlak (:InvisibleSmiley)]

This has been fixed in SM 2 (through the switch to satchel and the new Password Manager dialog, bug 390025).

Comment 22

[Serge Gautherie (:sgautherie)]

V.Duplicate