Closed Bug 1720257 Opened 3 years ago Closed 1 year ago

macOS Address book integration not working with OSX 10.15, 11.4 big sur and newer. Works on OSX 10.14.6 with Thunderbird 78.x

Categories

(Thunderbird :: Address Book, defect)

Product:
Thunderbird
Component:
Address Book
Version:
Thunderbird 90
Platform:
Desktop
macOS
Type:
defect

Tracking

(thunderbird_esr91+ affected, thunderbird_esr102+ fixed)

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
thunderbird_esr91 + affected
thunderbird_esr102 + fixed

People

(Reporter: mitra_lists, Assigned: d)

References

(Blocks 1 open bug,
URL
)

Details

Attachments

(3 files)

System preferences screenshot showing no Thunderbird request
21.02 KB, image/png
Details
image.png
12.11 KB, image/png
Details
1720257-macos-addrbook-permission.patch
659 bytes, patch
aleca
: review+
wsmwk
: approval-comm-esr102+
Details | Diff | Splinter Review

The Address book integration seems to have broken in OSX 11.4

I have two laptops, both running TB 90.0b3 .

In the version on OSX 10.14.6 Window>AddressBook>Mac OS Address Book shows all my contacts

On OSX 11.4 that same spot says "Mac OS X Address Book" but no contacts are shown.

I'm not aware of any setting that could cause this with the AddressBook window open there is a checkbox "File > Use Mac OS X Address Book" which is checked.

I notice in System Preferences > Security > Contacts that Thunderbird has not requested access to contacts, while it has in 10.14.6 so I'm wondering if this is the problem - i.e. that TB has never requested permission, or that process that previously requested permission is now broken.

Are you reporting a regression (which version worked?) or that it doesn't work with that particular OSX version?

The latter - same version of TB - works on OSX 10.14.6 fails on OSX 11.4

Summary: OSX Address book integration not working → OSX Address book integration not working with OSX 11.4

Calum, are you on OSX 11 and can reproduce this?

Flags: needinfo?(calum.mackay)

Sorry, I'm using MacOS 10.15.7.

So that's a MacOS regression, rather than a TB regression? :)

Flags: needinfo?(calum.mackay)

Looks like it - this is the first major release number change in twenty years (10.0.0 was 2001), and it looks like a few API's changed slightly.

Nomis, are you on macOS 11, and can reproduce this?

Flags: needinfo?(Nomis101)

(In reply to Wayne Mery (:wsmwk) from comment #6)

Nomis, are you on macOS 11, and can reproduce this?

Yes, I am on macOS 11. And I also can see this issue on my Thunderbird 87. Since macOS 11 you need to give every application access to the system addressbook. I have enabled this in System Preferences > Security > Contacts. But my contacts still don't show up in Thunderbird.

Flags: needinfo?(Nomis101)

I'm on macOS 11, TB 91.0b1 and Daily and see the contacts in the AB. I had to enable both versions manually.

TB 87 could be a problem as Darktrojan fixed in a later version an AB integration bug.

I'm fine with MacOS 11, TB 91.0b2.

Mitra, please retest after checking application access in Mac preferences

Flags: needinfo?(mitra_lists)

Wayne, TB just updated to 91.0b2, but there is no change.

Specifically - Thunderbird does not appear in System Preferences -> Security -> Contacts, so there is no way to give it permission.

For other applications, I'm pretty sure I've seen them pop up a dialog requesting permission.

@Richard - how did you "enable both versions manually" as there doesn't seem to be a way to manually add an application that hasn't requested access to the System Preferences

I also tried going to Address Book -> File -> Use MacOSX address book, disabling and reenabling it - but that didn't fix it either.

Flags: needinfo?(mitra_lists)

They there in the system preferences and enabled them. They there already in with older Mac versions. So maybe they are migrated from then.

Sorry Richard, I can't parse that sentence. Let me guess.

On old mac 10.14.6, it shows TB, with permissions granted.
On new mac 11.4, nothing shows up.

I did NOT migrate anything across, I'm guessing that its possible that if someone had installed 11.4 on top of an existing 10.14.6 it might have migrated the permissions, but I'm not in a position to test this as I need to keep the old mac on 10.14

Has anyone figured out how to make address books work yet on current OSX ?

Blocks: tb-mac

(In reply to Mitra Ardron from comment #14)

Has anyone figured out how to make address books work yet on current OSX ?

Do you get a prompt if you close Thunderbird, add the NSAppleEventsUsageDescription key to Thunderbirds Info.plist and then open Thunderbird again?
https://indiestack.com/2018/08/apple-events-usage-description/

<key>NSAppleEventsUsageDescription</key>
<string>Thunderbird needs to access your Address book</string>

No

To be clear ....

Closed TB
Went to /Applications/Thunderbird/Info.plist in Finder
Edited in TextEdit
added this key/string pair at top of the dict (consistent with other key/string pairs.
Reopened TB

No change

I then tried TB/Window/AddressBook/File/Use Address Book (turning it off)
Exited TB
Edited the file again, so I knew its date would update
Restarted TB
Still no prompt

Is there something else you'd like me to try

@nomis101 - were you able to repeat this?

status-thunderbird_esr91: --- → affected
Summary: OSX Address book integration not working with OSX 11.4 → OSX Address book integration not working with OSX 11.4 big sur

Someone could find the regression range using https://mozilla.github.io/mozregression/documentation/usage.html

Severity: -- → S2
tracking-thunderbird_esr91: --- → +
Keywords: regression, regressionwindow-wanted

I would imagine this is not a regression per se, but incompatibility with this OSX version. Per comment 2.

Good point.

This needs attention, now that we will be unthrottling Mac updates to version 91.

Keywords: regression, regressionwindow-wanted

Well, there's a big note at https://developer.apple.com/documentation/addressbook

Important
Do not use the AddressBook framework in macOS 10.11 and later. Use the APIs defined in the Contacts framework instead.

See Also: → 1739579

If we're not going to support it, then let's at least relnote it

Flags: needinfo?(rob)

That would be a pity - I don't know how many Mac users there are left for TB. I've never been a fan of Apple Mail, but not working with the Contacts would probably be the one thing that would finally push me over to it (now I've done the horrendous hack to make Lightning and Calendar work together) since currently I have to cut and paste addresses from my Mac Address book to Thunderbird to email people ! I had hoped that was only temporary.

As a workaround, you may be able to access the address book from iCloud, using TbSync and the DAV-4-TbSync provider.

@Magnus - I have no idea how to do what you suggested.

A set of instructions would be super useful, as the ones for integrating Calendar with Lightning/TB were for me - (though mere mortals will have difficulty following the steps required).

Magnus said "may", so it doesn't sound like he has instructions. But he is pointing you in the direction to investigate, and it can't be that difficult to make your own instructions if you invest a few minutes of your time:

  1. tbsync states it support icloud
  2. Mac clearly supports iclould, and setup is easily found with google.
  3. Marry the two pieces and you should have a solution

Hi there, I would also really appreciate the native OSX address book integration working in OSX 11. I am on OSX 11.6.1 and really miss the integration. Even if there were ways through iCloud it doesn't seem to make sense to sync through another online access if I have all the data already locally on the computer.
Thanks!

Wayne, I took a look, it looks like Tbsync isn't maintained - it says it only works with 91.0a1 - 91.*

@Mitra Ardron: Calling it unmaintained even thou it is running in latest ESR does not sound right to me.

It is maintained - it fully works with version 91 - but you are correct it doesn't work with beta always, which is not unusual for add-ons.

Sorry - didn't realize there was that much of a numeric gap between ESR 91 and beta 95 . I remember there used to be a way to trick an extension to see if it works with the current Beta, but I forget what that was.

Added a note to 91.0 release notes.

Flags: needinfo?(rob)
See Also: → 1662759

Hi, I was led here after filing a duplicate bug (thanks Magnus).
I'd like to emphasize once more the importance of an active connection between local Contacts and TB Address Book.
thanks

I would like to add my voice to this bug.

Using Montery 12.1 - Thunderbird 91.5.1 on a Macbook Pro M1.

Thunderbird doesn't connect the Mac addressbook and hasn't asked to do so when installing it. TB doesn't appear in System Preferences > Security > Contacts. No TB, no checkbox, not even a + sign to add a new app.

Any updates? Any hope?

Thanks.

Summary: OSX Address book integration not working with OSX 11.4 big sur → OSX Address book integration not working with OSX 11.4 big sur, works on OSX 10.14.6

For me a temporary downgrading to an old Thunderbird Version (for example 78.1.1) on MacOS 12.2.1 works! It asks again for permission and I accepted that. Then I upgraded to back to a new Version like 91.6.0 - and the permissions are still there and the MacOS Address Book works :)

Maybe it also works for you!

@cmueller Thank you so much for sharing, this worked perfect for me! The older version asked for permission, I accepted and now it can access the MacOS addressbook. This takes a pebble out of my shoe!

Can you confirm that when using the method from comment #39 that the address book in Thunderbird 91.6.0 stays in sync with OS X. I.e. it is not using a cached created by TB 78?

(In reply to Richard van den Berg from comment #41)

Can you confirm that when using the method from comment #39 that the address book in Thunderbird 91.6.0 stays in sync with OS X. I.e. it is not using a cached created by TB 78?

There is no sync. Thunderbird simply shows the MacOS Addressbook, which could have several backends. In my case my own CardDav server, but also local addressbooks or other sources. Therefore this question is not relevant.

Maybe this also points at what the problem is - as suspected in the Original Report - that the problem is that Thunderbird 90 etc aren't requesting permission, or are doing so wrongly.

A question for @Cmueller or @Jean-Francois - how did you do the downgrade and back again in such a way that OSX thinks its still the same application and so you didn't lose your profile ?

(In reply to Mitra Ardron from comment #44)

A question for @Cmueller or @Jean-Francois - how did you do the downgrade and back again in such a way that OSX thinks its still the same application and so you didn't lose your profile ?

I did it like so:

The first point is only recommended if you have previously used Thunderbird with a newer version.

1.) move/rename your Thunderbird profile folder /Users/YOURUSER/Library/Thunderbird to something like /Users/YOURUSER/Library/Thunderbird.bak
2.) download old Thunderbird Version (DMG File)
3.) open, drag and drop it to your Program folder, accept overwriting
4.) start old version and accept the requested permissions
5.) close old Thunderbird
6.) download new Release and overwrite it in the program folder
7.) rename or move the old profile folder back
8.) start new Version
9.) be happy ; )

It seems we have 2 issues here:

A) Thunderbird is no longer requesting access to the macOS Address Book. When this is restored using the method in comment #39 this seems to fix things.
B) Thunderbird is using the old macOS ABAddressBook API as mentioned in comment #22 see https://hg.mozilla.org/comm-central/file/tip/mailnews/addrbook/src/nsAbOSXCard.mm

This bug seems to be regarding issue A. Is there already a Bugzilla bug filed for issue B ?

In reply to @Mitra and @cmueller:

Thank you @cmueller for the precise instructions. I did exactly the same and it worked perfect. You just want to launch an older version (78) to make it do the permission work and install it in the settings. The next upgrades will use the same settings and therefore have access permission to your addressbook.

I confirm the workaround provided by @cmueller is working on my system (MacOS 12.1 on M1 MacBookPro17,1).
New Contacts.app entries are displayed in TB AddressBook and deleted entries are removed after an application re-open.
Thanks @cmueller!

(In reply to cmueller from comment #45)

Great, thanks so much for the workaround! Works flawlessly also on macOS 11.6.2 :)

Cheers!

I can confirm that @cmueller's instructions worked for me on MacOs 12.2.1.

Its probably worth adding to the instructions that the old version can be found for example at: https://ftp.mozilla.org/pub/thunderbird/releases/78.9.1/mac/en-US/ since there is no link to this from the main Thunderbird page and its non obvious how to find these.

As expected it seems to be a problem with newer TB's not asking permission for access to the OSX Address Book.

Its a pity there are no installation instructions with TB as pretty much any Mac user is going to want to do this hack, and also the even nastier hack that enables Lightning to talk to the OSX Calendar. (https://frightanic.com/apple-mac/thunderbird-icloud-calendar-sync/ )

@cmueller: Thanks a lot for this solution! I had the same issue, previous TB version installed a long time ago and it became necessary to move to a new machine now.
The bug "not asking for permission to access contacts" seems to be new in TB versions 90 and higher.
Following Your instructions, I downloaded the last previous official Version of 78.x from the Mozilla Archive:
https://ftp.mozilla.org/pub/thunderbird/releases/78.14.0/mac/en-US/

Then I startet the 78 TB version once, and thus got the redemptive prompt, that was asking for access to the contacts! Phew!
I could then remove the old version and installed the latest TB version over it. Quickly verified that the iCloud contacts (Mac OS X Address Book) can now be accessed - success!

To complete the TB migration from the old machine, I closed TB, cleaned all contents inside of the folder
~/Library/Thunderbird

and replaced the folder's contents with those from the old machine.

Mission accomplished! I hope that the "no-iCloud-contacts" bug gets resolved really soon so that this workaround will no longer be a requirement.
Big thanks guys, You saved the day! ;-)

(In reply to Magnus Melin [:mkmelin] from comment #20)

I would imagine this is not a regression per se, but incompatibility with this OSX version. Per comment 2.

I claim not. This is indeed a regression, in at least the sense that a previous version of Thunderbird correctly requests the appropriate permissions on launch. Clearly something got lost, perhaps as indicated in comment #15, which I did not test.

However, I can validate that the workaround outlined in comment #39, and again in #45, works just fine to get the permissions requested / registered.

FWIW, this was on a completely new install, M1Max, MacOS Monterey, 12.3.1, with no use of migration assistant, and thus no settings carried forward. Instead, opening Thunderbird 78.9.1 first requests the permissions needed and now on Thunderbird 91.8.1, all still works just fine.

Thank god I found this thread... The proposed solution did work for me, but this should be fixed really soon...

Issue is not fixed as of 102.0.

(In reply to aiden.woodruff from comment #56)

Issue is not fixed as of 102.0.

https://support.mozilla.org/en-US/questions/1381680 also reports this for 102

Summary: OSX Address book integration not working with OSX 11.4 big sur, works on OSX 10.14.6 → OSX Address book integration not working with OSX 11.4 big sur, works on OSX 10.14.6 / Thunderbird 78.x

This issue has not been fixed because no-one has found the faulty code yet. I have searched for it but did not find why in TB 78 it works but in TB 90 and onwards it does not.

Can't find it myself either. For posterity, accessing sharedAddressBook should activate the permission popup [1]. There's also some indication that it requires NSContactsUsageDescription to be set in Info.plists [2].

[1] https://developer.apple.com/documentation/addressbook/abaddressbook/1458758-sharedaddressbook/
[2] Mac developer documentation, subheading Other Features: https://developer.apple.com/library/archive/documentation/UserExperience/Conceptual/AddressBook/Concepts/WhatsInAB.html#//apple_ref/doc/uid/20001021-133803

Attached image image.png —

Aiden!

Adding that key to the Info.Plist file seems to have sort of worked! Could you try it? https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/MYROgChfQ1yFkMOOpSu4LA/runs/0/artifacts/public/build/target.pkg

That's not a properly signed build; I was able to run it after going into the "Security & Privacy" settings and allowing it.

It's not quite right, but a popup asks for permission to access Contacts (with the message "Testing"). Unfortunately, on my machine it prompts multiple times and it doesn't persist between Thunderbird restarts, despite an entry for Thunderbird Daily being added to the Privacy panel.

Info.plist is not an easily localized file unfortunately, but perhaps just a single space character would suffice as the prompt clearly is for Thunderbird.

I built with it modified in Info.plists.in and there was no change. Nor was there any when merely updating the package in Applications. I also noticed that in 78 the Thunderbird Address Book is in a separate window which has a different menu -- importantly one with an option to "Use Mac OS X Address Book". Don't think the plist entry is absolutely necessary if it worked in 78.

PS for lurkers: I used tccutil reset AddressBook to reset Security & Privacy status.

Per a request in a previously linked issue, I am confirming that the issue is still present in Thunderbird 102.2.0 on macOS 12.5.1.

See Also: → 1785280

(In reply to cmueller from comment #45)

(In reply to Mitra Ardron from comment #44)

A question for @Cmueller or @Jean-Francois - how did you do the downgrade and back again in such a way that OSX thinks its still the same application and so you didn't lose your profile ?

I did it like so:

The first point is only recommended if you have previously used Thunderbird with a newer version.

1.) move/rename your Thunderbird profile folder /Users/YOURUSER/Library/Thunderbird to something like /Users/YOURUSER/Library/Thunderbird.bak
2.) download old Thunderbird Version (DMG File)
3.) open, drag and drop it to your Program folder, accept overwriting
4.) start old version and accept the requested permissions
5.) close old Thunderbird
6.) download new Release and overwrite it in the program folder
7.) rename or move the old profile folder back
8.) start new Version
9.) be happy ; )

I tried this and though I was prompted for permission to contacts, it didnt work for me when I went back to 102

Thanks - there should be documentation in the file that pops up when you start TB to explain this nastiness, and the even worse hack to get Lightning to play nice with the calendar :-(

(In reply to cmueller from comment #45)

The above instructions worked perfectly for me.

I'm on Monterey 12.6.1

Thanks heaps for this! I was almost about to reluctantly switch to Apple Mail - phew! ;- )

n=1, but I had success with macOS 13.0 and TB 102.???. I found this thread, made a copy of my profile folder(s) [*more on this, below], and installed 78.9.1 overwriting whatever version of TB I had before.

TB launched, asked to create a new profile, and then asked for permission to access Contacts.

I quit TB and installed 102.7.2 overwriting 78.9.1, and copied my old profile back on top of the new profile folder.

TB threw the dreaded, "Your Thunderbird profile cannot be loaded. It may be missing or inaccessible" error, and refused to launch. I followed some online instructions to run:

/Applications/Thunderbird.app/Contents/MacOS/thunderbird-bin -ProfileManager

from the command line, and created a new profile (006de91c.MyName) there.

Then once TB had launched, I imported from my saved copy of my TB profile, and it appears that everything is there, and I have access to the macOS Address Book. Whew!

@Waterbug Good to know - though that is a really nasty, geek-only, set of steps.

Since this is now open 2 years - does anyone know how to edit the splash screen that comes up on install, and put instructions there so OSX users can work around a bug that looks like it will never get to the top of the list, and makes TB pretty much unusable for non-geeks (lack of access to contact book is pretty serious)

I'm running into the same bug (Thunderbird 102.8.0 doesn't ask for permission on macOS Ventura 13.2.1) and did some digging. Here's what I found.

When I launch Thunderbird, Console.app shows that tccd logs these messages:

tccd AUTHREQ_PROMPTING: msgID=3248.3, service=kTCCServiceAddressBook, subject=Sub:{org.mozilla.thunderbird}Resp:{TCCDProcess: identifier=org.mozilla.thunderbird, pid=3248, auid=501, euid=501, binary_path=/Applications/Thunderbird.app/Contents/MacOS/thunderbird},

tccd Refusing authorization request for service kTCCServiceAddressBook and subject Sub:{org.mozilla.thunderbird}Resp:{TCCDProcess: identifier=org.mozilla.thunderbird, pid=3248, auid=501, euid=501, binary_path=/Applications/Thunderbird.app/Contents/MacOS/thunderbird} without NSContactsUsageDescription key

macOS wants to see a NSContactsUsageDescription key in Thunderbird's Info.plist before it prompts the user for permission.

Now for the question of why older versions of Thunderbird seem to work while newer versions don't: I'm an iOS developer and don't know whether this is necessarily transferrable to macOS, but at least on iOS, Apple often tightens requirements with newer SDKs/Xcode versions, meaning that some functionality could be blocked from apps that are built with later versions of the iOS SDK, but - for backwards compatibility reasons - the same functionality is still accessible to apps that are built with older SDK versions. iOS system libraries often do runtime checks to look at the SDK version an app was built with and then change their behavior accordingly.

In the Address Book case, my guess would be that the working older Thunderbird versions were built with an old macOS SDK that still accepted Address Book access without a NSContactsUsageDescription, but that newer Thunderbird versions are built with a newer SDK that doesn't do so.

Long story short: I think it would be worth a try adding a NSContactsUsageDescription to the app's Info.plist and see if it fixes the issue.

A more future-proof solution would probably be to migrate from the deprecated Address Book framework to the Contacts framework. The latter is available since macOS 10.11 and Thunderbird only supports macOS 10.12+, so that would be a good match. I haven't looked at the APIs though, so this might be a bigger lift (definitely bigger than adding a NSContactsUsageDescription).

I can confirm that adding a NSContactsUsageDescription does indeed work! This is the diff for comm-central (no localization):

diff --git a/mail/app/macbuild/Contents/Info.plist.in b/mail/app/macbuild/Contents/Info.plist.in
--- a/mail/app/macbuild/Contents/Info.plist.in
+++ b/mail/app/macbuild/Contents/Info.plist.in
@@ -137,5 +137,7 @@
                        <string>Viewer</string>
                </dict>
        </array>
+       <key>NSContactsUsageDescription</key>
+       <string>To make your macOS address book available in @MAC_APP_NAME@</string>
 </dict>
 </plist>

To test this,

  1. rebuild Thunderbird,
  2. quit all instances of Thunderbird,
  3. run tccutil reset AddressBook to clear out existing permissions,
  4. run the Thunderbird build, but not through ./mach run but by opening the .app file directly: open obj-*/dist/Thunderbird\ DailyDebug.app (otherwise macOS will ask whether Terminal should be granted access to contacts),
  5. switch to the Address Book tab, and
  6. notice the macOS contacts permission window that pops up.

After granting this permission, the Mac OS X Address Book will contain all contacts from the macOS contacts app.

For localization of the usage description string, NSContactsUsageDescription must be added with adequate translations to comm/mail/app/macbuild/Contents/Resources/*.lproj/InfoPlist.strings.in, but I don't know how this works in Mozilla/Thunderbird code.

If someone who is more familiar with the Thunderbird codebase and the build system wants to run with this and create a proper patch to be included into Thunderbird, please do! Otherwise, I can try to get it done myself and would appreciate some pointers towards how to get localization set up.

Daniel, you are awesome! Since none of the other elements in Info.plist.in (like CFBundleTypeName) are currently localised, I think it is ok to just add NSContactsUsageDescription for now. Can you submit that patch?

(In reply to Daniel Seither from comment #74)

+++ b/mail/app/macbuild/Contents/Info.plist.in
@@ -137,5 +137,7 @@
<string>Viewer</string>
</dict>
</array>

  •   <key>NSContactsUsageDescription</key>

  •   <string>To make your macOS address book available in @MAC_APP_NAME@</string>

</dict>
</plist>

If I just edit this into the Info.plist in my TBird 110.0b4 on OSX 13.2.1 it doesn't seem to work. Adding the lines in Info.plist causes TBird to freeze for maybe 30secs before UI populates with actual emails. I see a spurt of entries in the log but nothing that asks for access, no entries in system settings have changed, etc. If I remove the lines in Info.plist the freezing goes away.

(In reply to Chris Andrichak from comment #76)

If I just edit this into the Info.plist in my TBird 110.0b4 on OSX 13.2.1 it doesn't seem to work. Adding the lines in Info.plist causes TBird to freeze for maybe 30secs before UI populates with actual emails. I see a spurt of entries in the log but nothing that asks for access, no entries in system settings have changed, etc. If I remove the lines in Info.plist the freezing goes away.

I'm guessing that just editing the Info.plist in the delivered binary pkg breaks something since the only way I can get it to work is if I launch the program through the Terminal, in which case Terminal shows has having been granted Contacts permission. Console shows MacOS error: -67030 which is a code signing error. Various permutations of steps to edit the plist and launch the app just cause the delay but don't give Contacts access.

So i guess i have to wait for this to be baked into the app via an official release...

If I just edit this into the Info.plist in my TBird 110.0b4 on OSX 13.2.1 it doesn't seem to work.

Yes, Info.plist seems to be included in code signing, leading to all kinds of weird errors if it is changed without resigning the app.

Since none of the other elements in Info.plist.in (like CFBundleTypeName) are currently localised, I think it is ok to just add NSContactsUsageDescription for now.

Agreed, especially since Firefox has unlocalized usage description strings for camera and microphone access. I tested this on my German macOS running a German Firefox: the camera access prompt comes up in English (just the Firefox-provided usage description, not the system-provided text in the prompt, which is in German). I'd say, if Firefox ships unlocalized usage description strings, so can Thunderbird.

Can you submit that patch?

Done!

Thanks! Who can get this into a TB nightly?

Flags: needinfo?(bwerth)

Tiny patch, but someone on mac needs to test it.

Assignee: nobody → d
Status: NEW → ASSIGNED
status-thunderbird_esr102: --- → affected
tracking-thunderbird_esr102: --- → +
Flags: needinfo?(bwerth) → needinfo?(alessandro)

Daniel, thanks for the patch!

Comment on attachment 9321203 [details] [diff] [review]
1720257-macos-addrbook-permission.patch

Review of attachment 9321203 [details] [diff] [review]:
-----------------------------------------------------------------

Nice work, this works very well.
I get prompted about the macOS Address Book on startup directly with a new profile even before the main application window is loaded, which I guess it's fine.

Can you update the commit message to "Bug 1720257 - Fix macOS Contacts permission request. r=aleca"

Thank you so much!
Attachment #9321203 - Flags: review+
Flags: needinfo?(alessandro)

I'll update the commit message and land.

Target Milestone: --- → 112 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/60825663bba9
Fix macOS Contacts permission request. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

I only noticed today that Bugzilla wasn't able to deliver email to my address because its mail server was on a block list, so I didn't get any notifications after my last post.

Thank you for updating the commit message for me and landing this patch!

Comment on attachment 9321203 [details] [diff] [review]
1720257-macos-addrbook-permission.patch

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: can't use osx ab
Testing completed (on c-c, etc.): beta
Risk to taking this patch (and alternatives if risky): There is a risk it exposes other bugs; bad interaction with tb and mac ab (IIRC we have seen reports where it causes huge startup delay / hang).

Attachment #9321203 - Flags: approval-comm-esr102?
Duplicate of this bug: 1827087

Comment on attachment 9321203 [details] [diff] [review]
1720257-macos-addrbook-permission.patch

[Triage Comment]
approved for esr102

Attachment #9321203 - Flags: approval-comm-esr102? → approval-comm-esr102+
Duplicate of this bug: 1830455
Summary: OSX Address book integration not working with OSX 11.4 big sur, works on OSX 10.14.6 / Thunderbird 78.x → macOS Address book integration not working with OSX 10.15, 11.4 big sur and newer. Works on OSX 10.14.6 with Thunderbird 78.x

It might be worth explaining here how to get the macOS address book working again in an existing profile:

  1. Using the Thunderbird config editor set ldap_2.servers.osx.dirType to 3 (default seems to be -1)
  2. Quit Thunderbird
  3. mv ~/Library/Thunderbird ~/Library/Thunderbird.bak
  4. mv ~/Library/Caches/Thunderbird ~/Library/Caches/Thunderbird.bak
  5. Start Thunderbird
  6. Give Thunderbird permission to read the Address Book when asked about this in the pop-up
  7. Quit Thunderbird
  8. rm -rf ~/Library/Thunderbird ~/Library/Caches/Thunderbird
  9. mv ~/Library/Thunderbird.bak ~/Library/Thunderbird
  10. mv ~/Library/caches/Thunderbird.bak ~/Library/caches/Thunderbird
  11. Start Thunderbird

The "Mac OS X Address Book" section should now appear in the Thunderbird Address Book. It is step 1 that took me way too long to figure out last night. Come to think of it, I'm not entirely sure step 3 - 10 are actually required.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: