1729587 - Preferences UI tweaks for Firefox Suggest

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

The description string under the main checkbox should not be shown in the offline scenario: "Firefox will have access to your location, search queries, and visited sites.", addressbar-locbar-firefox-suggest-description in the FTL

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1729587 - Tweaks to the Firefox Suggest preferences UI.

Per spec, the informational description about data collection under the main
Firefox Suggest checkbox should be hidden except for the "online" scenario,
since only the online scenario sends data to Mozilla.

Depends on D125024

Comment 2

[Drew Willcoxon :adw]

We have some last minute changes described in the phabricator, not a big deal.

Comment 3

[Drew Willcoxon :adw]

Attachment: Offline screenshot

STR for QA

Offline scenario

1. Start Firefox in an en-* build so that the offline scenario is enabled by default (this assumes bug 1729776 lands first, which is my plan)
2. Open about:preferences#privacy, scroll down to the address bar section, and verify that it looks like the attached offline screenshot. Note especially the two Firefox Suggest checkboxes at the bottom and the lack of text below the first textbox.

Online scenario

You can verify this either by setting a pref in Firefox or by actually testing the scenario using Nimbus. The pref is browser.urlbar.quicksuggest.scenario="online".

Open about:preferences#privacy, scroll down to the address bar section, and verify that it looks like the attached online screenshot. The only difference from the offline UI is that the first checkbox now has text under it: "Firefox/Nightly will have access to your location, search queries, and visited sites."

Comment 4

[Drew Willcoxon :adw]

Attachment: Online screenshot

Comment 5

[Drew Willcoxon :adw]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=40029381a3fbe94d70d426c8852bc6d0ad696464

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2437b6208eb4
Tweaks to the Firefox Suggest preferences UI. r=mak,preferences-reviewers,jaws,fluent-reviewers

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2437b6208eb4

Comment 8

[Drew Willcoxon :adw]

Comment on attachment 9240425 [details]
Offline screenshot

There was a last-minute cosmetic fix for the indentation of the text under the sponsored checkbox. I'll attach new screenshots.

Comment 9

[Drew Willcoxon :adw]

Attachment: Offline screenshot v2

Comment 10

[Drew Willcoxon :adw]

Attachment: Online screenshot v2

Comment 11

[Drew Willcoxon :adw]

Attachment: 93/mozilla-beta & 92/mozilla-release patch

Approval Request Comment
[Feature/Bug causing the regression]: Firefox Suggest offline/online rollouts
[User impact if declined]: Needed for important rollouts on 93 and 92
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: Yes, please see comment 3
[List of other uplifts needed for the feature/fix]: See uplift coordination spreadsheet
[Is the change risky?]: Low risk relative to other uplifts needed in the patch stack
[Why is the change risky/not risky?]: This patch changes two strings for checkboxes in the preferences UI and adds a new string under one of the checkboxes (none of these strings are exposed to localizers)
[String changes made/needed]:

Comment 12

[Drew Willcoxon :adw]

Comment on attachment 9240773 [details] [diff] [review]
93/mozilla-beta & 92/mozilla-release patch

Beta/Release Uplift Approval Request

• User impact if declined: Needed for important rollouts on 93 and 92
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Yes, please see comment 3
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch changes two strings for checkboxes in the preferences UI and adds a new string under one of the checkboxes (none of these strings are exposed to localizers)
• String changes made/needed:

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9240773 [details] [diff] [review]
93/mozilla-beta & 92/mozilla-release patch

Needed for experiments targeting Fx92. Approved for 93.0b4.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3916e953c5ba

Comment 15

[Carmen Fat [:cfat] - Ecosystem QA]

• I have verified this issue using the latest Nightly 94.0a1 (Build ID: 20210912213037) and Beta 93.0b4 (Build ID: 20210912185727) builds on Windows 10 x64, macOS 11.5.2, and Linux Mint 20.

Offline scenario:

• I have verified that the offline scenario is enabled by default.
• I have verified that there are 2 Firefox Suggest checkboxes in the "about:preferences#privacy" page.

1. "Contextual suggestions" main checkbox (enabled by default).

• Learn more link that opens the "Navigate the Web faster with Firefox Suggest" page.

2. "Include occasional sponsored suggestions" checkbox (enabled by default).

• "Helps fund Nightly/Firefox development and optimization" text under the 2nd checkbox.

Online scenario:

• I have set the browser.urlbar.quicksuggest.scenario pref to online.
• I have verified that there are 2 Firefox Suggest checkboxes in the "about:preferences#privacy" page.

1. "Contextual suggestions" main checkbox (enabled by default).

• Learn more link that opens the "Navigate the Web faster with Firefox Suggest" page.
• "Nightly/Firefox will have access to your location, search queries, and visited sites." text under the 1st checkbox.

2. "Include occasional sponsored suggestions" checkbox (enabled by default).

• "Helps fund Nightly/Firefox development and optimization" text under the 2nd checkbox.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9240773 [details] [diff] [review]
93/mozilla-beta & 92/mozilla-release patch

Approved for 92.0.1.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/7fb4afa62465

Comment 18

[Carmen Fat [:cfat] - Ecosystem QA]

• I have verified this issue using the Candidate 92.0.1 build (Build ID: 20210920202613) on Windows 10 x64, macOS 10.15.7 and Linux Ubuntu 20.04 x64.

Offline scenario:

• I have verified that the offline scenario is enabled by default.
• I have verified that there are 2 Firefox Suggest checkboxes in the "about:preferences#privacy" page.

1. "Contextual suggestions" main checkbox (enabled by default).

• Learn more link that opens the "Navigate the Web faster with Firefox Suggest" page.

2. "Include occasional sponsored suggestions" checkbox (enabled by default).

• "Helps fund Nightly/Firefox development and optimization" text under the 2nd checkbox.

Online scenario:

• I have set the browser.urlbar.quicksuggest.scenario pref to online.
• I have set the browser.urlbar.quicksuggest.enabled pref to true.
• I have allowed the suggestions through the Onboarding modal.
• I have verified that there are 2 Firefox Suggest checkboxes in the "about:preferences#privacy" page.

1. "Contextual suggestions" main checkbox (enabled).

• Learn more link that opens the "Navigate the Web faster with Firefox Suggest" page.
• "Nightly/Firefox will have access to your location, search queries, and visited sites." text under the 1st checkbox.

2. "Include occasional sponsored suggestions" checkbox (enabled).

• "Helps fund Nightly/Firefox development and optimization" text under the 2nd checkbox.