1730692 - The Firefox Suggest onboarding dialog/modal is cut off when a larger system font size is set while the dialog is open

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Maria Heres, inactive, contact Ecosystem QA]

Attachment: larger system text.gif

[Affected Versions]:

• Firefox Beta 93.0b4 (Build ID: 20210912185727)
• Firefox Nightly 94.0a1 (Build ID: 20210913213224)

[Affected Platforms]:

• Windows 10

[Prerequisites]:

• Have Firefox installed and opened.
• Have the following preferences set:
  • browser.urlbar.quicksuggest.enabled = true
• browser.urlbar.quicksuggest.scenario = online
• browser.urlbar.quicksuggest.shouldShowOnboardingDialog = true
• browser.urlbar.suggest.quicksuggest = false
• browser.urlbar.suggest.quicksuggest.sponsored = false

[Steps to reproduce]:

1. Restart the browser after setting prerequisite preferences.
2. Dismiss the Make Firefox default message if it is displayed to trigger the Suggestions modal.
3. Open System Settings > Ease of Access > Display.
4. Set the “Make text bigger” slider to a larger value (e.g. 135% ).
5. Observe the modal.

[Expected result]:

• The text and buttons of the modal are still readable/clickable with a larger system text.

[Actual result]:

• The text and buttons are cut off when a larger system text is set and are unreachable.

[Notes]:

• The issue does not seem reproducible for the accessibility options of the tested Linux Mint and macOS devices (“Scale” and “Large text”).
• Attached is a screen recording of the issue.

Comment 1

[Drew Willcoxon :adw]

Dao, do you have time to look at this? Of the three onboarding bugs QA filed today (bug 1730702, bug 1730691, this one), this seems like the worst one. Can the dialog grow with the text and/or scroll? Or maybe just force a fixed text size for now.

Comment 2

[Dão Gottwald [:dao]]

Do you see the same issue when changing display settings before the modal comes up? Changing settings while the modal is open seems like an edge case.

Comment 3

[Maria Heres, inactive, contact Ecosystem QA]

I checked and it seems that the modal is correctly displayed if the setting is changed before it is triggered. The buttons are accessible.

Comment 4

[Drew Willcoxon :adw]

Great question. In that case, I think it's safe to say this doesn't need to block the offline/online rollouts. Might even be a wontfix, but ideally it would be fixed I guess.

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1730692: Make dialog be appropriate size when the system font size changes on windows.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fa76d9dc3dd
Make dialog be appropriate size when the system font size changes on windows. r=adw

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3fa76d9dc3dd

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 9

[Drew Willcoxon :adw]

No need to fix this on 95, marking wontfix

Comment 10

[Maria Heres, inactive, contact Ecosystem QA]

I have verified that the issue is no longer reproducible. All the text and buttons of the modal are now visible if the user changes the text settings to a larger size while the prompt is displayed. Tested using Firefox Nightly 96.0a1 (Build ID: 20211201214955) on Windows 10.