1726437 - Add new monochromatic themes

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[Harry Twyford]

This bug entails adding the JSON files containing the colors UX provides.

Comment 1

[Harry Twyford]

Attachment: Bug 1726437 - Add new monochromatic themes. r?dao!

This is pretty much impossible to review as-is, so it may be more useful to review the script that made them. The repo is at https://github.com/htwyford/create-theme-script. parse-themes-script.js is the main script. It reads input.json. input.json is pulled from https://github.com/FirefoxUX/themes/blob/main/tokens/color/base.json, with some light edits to fix inconsistencies. The file in the FirefoxUX repo is an export of the colors in the Figma file: https://www.figma.com/file/xaRff6432QsirRftX8NZgb/MR2-Themes?node-id=86%3A17747.

The themes aren't perfect yet. For example, the text color in the Urlbar chiclet is sometimes wrong. They also don't consider the UX spec on badge colors, since UX is still actively updating that part of the spec. Since these themes are behind a pref, I think we should land it and fix the issues in followups. It will make it more clear what is changing when they're not being added en masse like this. Getting them in the tree ASAP also lets UX and QA get a head start on testing them.

Depends on D125283

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01f90db715a7
Add new monochromatic themes. r=dao,mixedpuppy

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1730262 for causing backout conflicts.

Please see this comment here

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f7d37986a52
Add new monochromatic themes. r=dao,mixedpuppy

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0f7d37986a52