Closed Bug 1726437 Opened 1 year ago Closed 1 year ago

Add new monochromatic themes

Categories

(Firefox :: Theme, enhancement, P1)

enhancement
Points:
2

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-theme])

Attachments

(1 file)

This bug entails adding the JSON files containing the colors UX provides.

Blocks: 1726438
Whiteboard: [fidefe-theme]
Blocks: 1729535
Blocks: 1728186
Blocks: 1730262
No longer blocks: 1730262
Depends on: 1730262

This is pretty much impossible to review as-is, so it may be more useful to review the script that made them. The repo is at https://github.com/htwyford/create-theme-script. parse-themes-script.js is the main script. It reads input.json. input.json is pulled from https://github.com/FirefoxUX/themes/blob/main/tokens/color/base.json, with some light edits to fix inconsistencies. The file in the FirefoxUX repo is an export of the colors in the Figma file: https://www.figma.com/file/xaRff6432QsirRftX8NZgb/MR2-Themes?node-id=86%3A17747.

The themes aren't perfect yet. For example, the text color in the Urlbar chiclet is sometimes wrong. They also don't consider the UX spec on badge colors, since UX is still actively updating that part of the spec. Since these themes are behind a pref, I think we should land it and fix the issues in followups. It will make it more clear what is changing when they're not being added en masse like this. Getting them in the tree ASAP also lets UX and QA get a head start on testing them.

Depends on D125283

Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Blocks: 1731652
Blocks: 1731660
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01f90db715a7
Add new monochromatic themes. r=dao,mixedpuppy
Blocks: 1731666

Backed out along with Bug 1730262 for causing backout conflicts.

Please see this comment here

Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f7d37986a52
Add new monochromatic themes. r=dao,mixedpuppy
Blocks: 1731791
Blocks: 1731798
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.