1734948 - Bad contrast with Elemental-Balanced theme for Windows checkboxes on customize page and Find toolbar

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Mathew Hodson]

(In reply to Monica Chiorean from comment #7)

Created attachment 9244952 [details]
screenTheme - Title bar - Checkbox

Please add an uplift request as this impacts the Customize page on Beta as well.

The issue there is that the checkbox for 'Title Bar' from Customize page is not visible while using one of the new themes (Elemental-Balanced theme). After a quick investigation using mozregression, the push log that fixed the issue is this https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ef7b596bb385f46280eb1492009bf8fb541e17db&tochange=8ad879d71dc3f5a69275aa2eb28ba74a492135c5

For more details please see the latest attachment.

Last good revision: 56a4ee0d10655c7cca53ef9aaa14da5ef88bb9c0
First bad revision: 06d6b39b2638e83e2eb62c381e31552fa5281cb0
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=56a4ee0d10655c7cca53ef9aaa14da5ef88bb9c0&tochange=06d6b39b2638e83e2eb62c381e31552fa5281cb0

Comment 1

[Mathew Hodson]

Reported in bug 1734226 comment #7

Comment 2

[Mathew Hodson]

This impacts the Customize page on Beta for some monochromatic themes.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1731660

Comment 4

[Harry Twyford]

I can't reproduce this on Mac. The screenshot looks like Windows 7. Is this issue reproducible on Linux or Windows 10?

Comment 5

[Mathew Hodson]

It reproduces for me on Windows 10. It's probably Windows only, because the changes in the push log that fixed it only affected Windows right?

Comment 6

[Harry Twyford]

Fixing this would require uplifting several risky Windows patches. Since this is a minor element in a low-traffic part of the UI, and it is fixed in Fx95, I'm inclined to close this bug. A similar decision was made in bug 1734655 comment 7. Romain, are you okay with me closing this one?

Comment 7

[Romain Testard [:RT]]

I agree there, no uplift sdhould be made if this is risky given low discoverability of this area. Closing now.

Comment 8

[Mathew Hodson]

(In reply to Romain Testard [:RT] from comment #7)

I agree there, no uplift sdhould be made if this is risky given low discoverability of this area. Closing now.

I think WONTFIX is the wrong status. This bug is fixed but only in Firefox 95 and later.

Comment 9

[Romain Testard [:RT]]

Apologies you're right. I'm marking as fixed and tracking help clarify the fix version

Comment 10

[Timea Cernea [:tbabos][inactive]]

Attachment: Screenshot of Find toolbar

Please note that this issue also affected the checkmarks from the Find toolbar - Elemental (Balanced) - Windows 7. Can also confirm that this is also fixed on the latest Nightly.

Comment 11

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: Title Bar Checkbox .png

On macOS and Ubuntu is still reproducible this issue, tested on latest nightly (95.0a1), the Title Bar checkbox on customize page is still invisible or have bad contrast, using all soft themes.

Comment 12

[Mathew Hodson]

(In reply to Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA from comment #11)

On macOS and Ubuntu is still reproducible this issue, tested on latest nightly (95.0a1), the Title Bar checkbox on customize page is still invisible or have bad contrast, using all soft themes.

You should file a new bug. This was originally reported on Windows, and that fix only affected Windows.

Comment 13

[Monica Chiorean]

This is fixed on Win7 and Win10(using 95.0b2) and for Mac and Ubuntu logged bug 1739416.