1757647 - Use overlay scrollbars in Windows 11 if possible

Status: RESOLVED FIXED

(Core :: Widget: Win32, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1757647 - Simplify WindowsUIUtils tablet mode stuff. r=cmartin,saschanaz

No need for it to use so much XPCOM.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1757647 - Implement Windows 11 overlay scrollbars. r=cmartin,saschanaz

Put it behind a pref for nightly and early beta for now.

Depends on D139986

Comment 3

[Emilio Cobos Álvarez (:emilio)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Jamie, so this patch causes a lint failure like:

New calls to CoInitialize, CoInitializeEx, OleInitialize, RoInitialize, CoUninitialize, OleUninitialize, or RoUninitialize are forbidden. If you have questions, please consult a peer of the IPC: MSCOM module.

That comes from bug 1715650. Locally, it seems just removing that call works, but I want to confirm either that or adding the file to the whitelist works. This code runs on the parent process main thread only. Do we have the guarantee of COM stuff being initialized? I was following code like this (also main-thread, parent-process-only).

How should I proceed, should I remove the call, add it to the whitelist of files? Something else?

Thanks.

Comment 4

[James Teh [:Jamie]]

You should remove the call. COM gets initialised in mscom::ProcessRuntime, which now happens very early in startup in mozglue. I'm assuming this new code happens much later than that, but if you do need COM initialised earlier, we'll need to move ProcessRuntime construction; we don't want other stuff initialising COM first.

Some older code does still call CoInitialize/RoInitialize, but that should be considered legacy, hence the whitelist.

As a side note, calling RoInitialize with RO_INIT_MULTITHREADED is an error here anyway because the parent process main thread is (and must be) a single threaded apartment (STA).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d15ff6c47643
Simplify WindowsUIUtils tablet mode stuff. r=saschanaz
https://hg.mozilla.org/integration/autoland/rev/21553c91b278
Implement Windows 11 overlay scrollbars. r=cmartin

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d15ff6c47643
https://hg.mozilla.org/mozilla-central/rev/21553c91b278