1761782 - Use new tab colours for background/foreground of My Firefox page

Status: RESOLVED FIXED

(Firefox :: Firefox View, defect, P2)

Description

[:Gijs (he/him)]

The current page is just always blank; it should have the same foreground/background colours as the new tab page

Comment 1

[Mark Striemer [:mstriemer]]

Setting priority based on JIRA

Comment 2

[Sam Foster [:sfoster] (he/him)]

about:newtab uses 2 colors for its main and 2ndary background colors:

• --newtab-background-color
  • this is off-white (#F9F9FB) in light theme
  • and dark grey (#2B2A33) in dark theme
  • and maps to ntp_background property` in light-weight themes
• --newtab-background-color-secondary
  • this is white (#fff) in light theme
  • and less dark (#42414d) in dark theme
  • and maps to ntp_card_background property in light-weight themes

For our other privileged in-content pages we have these variables defined for use in-content/common-shared.css which I think are the equivalent(?):

• --in-content-page-background
  • this is white (#fff) in light theme.
  • and v. dark grey rgb(28,27,34) in dark theme
• --in-content-box-background
  • this is also white (#fff) in light theme
  • and less dark grey rgb(35, 34, 43); in dark theme

The design in figma doesn't have this differentiation between the page background color and the content area background color FWIW, so I believe this would be a visual design change.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::New Tab Page' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[:Gijs (he/him)]

Bad bot, no botsnack for you.

Comment 5

[:Gijs (he/him)]

Unassigning per meeting conversation.

Comment 6

[Sarah Clements [:sclements]]

Attachment: Bug 1761782 - Firefox View colors update in response to theme changes r=dao,sfoster

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/735074a636a4
Firefox View colors update in response to theme changes r=dao

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/735074a636a4

Comment 9

[Sören Hentzschel]

The title and description of this bug as well as the last comments in bug 1783274 sounds to me that that Firefox View should use the same background color as the new tab page. But at least on macOS it doesn't (#f9f9fb on the new tab page, #ffffff on Firefox View). Can you clarify what the expected behaviour is?

Comment 10

[:Gijs (he/him)]

(In reply to Sören Hentzschel from comment #9)

The title and description of this bug as well as the last comments in bug 1783274 sounds to me that that Firefox View should use the same background color as the new tab page. But at least on macOS it doesn't (#f9f9fb on the new tab page, #ffffff on Firefox View). Can you clarify what the expected behaviour is?

The expected behaviour changed in this bug is specifically about colourways/themes that change these colours so the entire browser has a green/red/whatever hue, not the default theme. bug 1783274 is probably closer to the issue you're raising. It's interesting because per that bug, this apparently used to match, but doesn't anymore (but does match the design specs...). Let's continue the conversation there.