1762085 - Add PiP Video-Adapter for handling Funimation Subtitles

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, enhancement)

Description

[Max]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

1. Went of funimation.com
2. Select a video (some can be played without an account)
3. Enable subtitles on built-in video player
4. Click on PiP button
5. Subtitles do not appear in PiP, only appear in built-in video player

Actual results:

Subtitles did not properly work on funimation.com

Expected results:

Subtitles should appear in PiP

Comment 1

[Max]

Since encountering this issue, I have added support for funimation on my local instance of FF Nightly.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Video/Audio Controls' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Max]

Attachment: Bug 1762085 - Add video wrapper with subtitle support for funimation.com. r=#pip-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1236a6f789f2
Add video wrapper with subtitle support for funimation.com. r=niklas,kpatenio

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/1236a6f789f2

Comment 6

[Daniel Bodea [:danibodea]]

This fix was verified on Nightly v102.0a1 and Beta v101.0b3 (20220504181604) on Windows 10, Ubuntu 20.04.4 LTS, Windows 7 and Mac OS 11.
The subtitles are now displaying correctly while on Release v100, they don't show at all.

Comment 7

[Ania]

Release Note Request (optional, but appreciated)

[Why is this notable]: Subtitles support has been added for a large number of streaming services with large viewership. Please note, this request is just for beta rel notes for now.
[Affects Firefox for Android]: No
[Suggested wording]: Subtitles and captions for Picture-in-Picture are now available at HBO Max, Funimation, Dailymotion, Tubi, Disney+ Hotstar, and SonyLIV.
[Links (documentation, blog post, etc)]: The rel note also includes these four tickets:
Dailymotion
Tubi
HBO MAX
Hotstar
SonyLIV