1792102 - POP3 Mailbox Messages Not Being Deleted After Delete or Move

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect, P2)

Description

[Bill Bach]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:103.0) Gecko/20100101 Firefox/103.0

Steps to reproduce:

Thunderbird 102.3.0 was recently released and installed today. When I read my messages and delete them from my account, they disappear as expected from TB. However, they do not get deleted from the POP3 Rackspace Email Server.

Actual results:

As of today, when I delete a message from my POP3 account in TB, the message remains active on the POP3 mail server. This causes me to have to delete every message a second time from either the web Email client or my Android Email client.

Expected results:

As of yesterday (prior to 102.3.0), when I delete a message in TB, it removed it automatically from my POP3 EMail account. I tried changing the mail.pop3.deleteFromServerOnMove from FALSE to TRUE, but this had no impact.

Comment 1

[Ping Chen [:rnons] (away)]

When deleting a pop3 message, TB only toggles a flag in popstate.dat. And when TB connects to the server next time (e.g. Get Messages), the actual DELE command is sent. If the message is still not deleted from server after clicking Get Messages, then it's a bug.

I just tested TB91, seems to be the same as 102.

Comment 3

[Ping Chen [:rnons] (away)]

Seems to work for me, would be great if you can provide popstate.dat and some debug logs.

When deleting a pop3 message, TB only toggles a flag in popstate.dat

Go to your profile directory (can be found on Help > More Troubleshooting Info), open Mail/pop3.<hostname>, there should be a popstate.dat file. After deleting a message, popstate.dat should have a line like this

d 000003fe5f7aa7cb 1663994639

d means to be deleted.

Then go to Config Editor (can be found on Settings page), set mailnews.pop3.loglevel to All. Click Get Messages, should see logs in the Error Console

mailnews.pop3.3: C: UIDL 
mailnews.pop3.3: S: +OK
1 000003fd5f7aa7cb
2 000003fe5f7aa7cb
.
mailnews.pop3.3: C: DELE 1 
mailnews.pop3.3: S: +OK Marked to be deleted.

After C: DELE, the message should be removed from the server, and the lines starting with d in popstate.dat should be removed.

Comment 4

[Laurent Grenet]

Hi,

I confirm it DOESN'T work, but bug is very recent, since in TB 102.2.1, bug wasn't present, and it worked fine. (I just did a test in TB 102.2.1)

I have had a look on popstate.dat file, and the problem is that, when deleting a mail, it is NOT marked as 'd', but remains 'k' (which explain that no DELE command is sent to the server at next refresh ;-)
Then I have had also a look at error console... and bingo, there is a systematic error each time I delete a mail :

TypeError: this._server.wrappedJSObject is undefinedPop3Client.jsm:66:5
    Pop3Client resource:///modules/Pop3Client.jsm:66
    markMessages resource:///modules/Pop3IncomingServer.jsm:235

Pls take note that I have this error

• whatever the POP3 server
• whatever the Thunderbird install

In particular, the test in TB 102.2.1 I mention above, I ran it on a Virtualbox VM. On this instance, I had several mails in my mailbox, all of them already locally downloaded. I was able to delete some of them (no error in error console, and popstate.dat was marked with 'd', and the mail was deleted on the server at next refresh.)
I have then "only" forced update of TB to 102.3.0
This obliged me to close and reopen TB (to apply the update - Std behaviour)
This (and only this) was enough to have the bug : error message in error console, and popstate.dat not updated, when deleting a mail.

I hope these supplementary informations help !

Comment 5

[Laurent Grenet]

I just did a supplementary test, in TB 102.2.2 and in this version, bug is NOT present.
Clearly bug comes from 102.3.0
According to Change log, this version (102.3.0) comes with three fixes relative to POP servers :

fixed  Delete from POP Server mail filter rule intermittently failed to trigger
fixed  Connections to POP3 servers without UIDL support failed
fixed  Pop accounts with "Fetch headers only" set downloaded complete messages if server did not advertise TOP capability

The most likely is that the new bug is a side effect of one of these fixes.

Personally, I downgraded my "operational" TB to 102.2.2 until new fix

Comment 6

[EarlgreyTea]

(In reply to Laurent Grenet from comment #4)

Then I have had also a look at error console... and bingo, there is a systematic error each time I delete a mail :

TypeError: this._server.wrappedJSObject is undefinedPop3Client.jsm:66:5
    Pop3Client resource:///modules/Pop3Client.jsm:66
    markMessages resource:///modules/Pop3IncomingServer.jsm:235

I also confirmed the exact same error.
Debugger says "this._server.wrappedJSObject is undefined" at the code below:

    this._server.wrappedJSObject.runningClient = this;

According to below, the above code seems to have been added to Pop3Client.jsm:66 in bug 1789418.
https://hg.mozilla.org/releases/comm-esr102/annotate/04f60827c1b53ab86121c7d122d3a8216219ff9f/mailnews/local/src/Pop3Client.jsm
https://hg.mozilla.org/releases/comm-esr102/diff/863061b010be0780d0c4a39955ae5b94c281673c/mailnews/local/src/Pop3Client.jsm#l1.12

Comment 9

[Ping Chen [:rnons] (away)]

Thanks, will be fixed by the patch in bug 1786920 comment 13. Missed a few lines when uplifting bug 1789418.