The default bug view has changed. See this FAQ.

Add Date & Time for started (or added) download

VERIFIED FIXED in seamonkey2.0b2

Status

SeaMonkey
Download & File Handling
--
enhancement
VERIFIED FIXED
15 years ago
8 years ago

People

(Reporter: Nicolas Miceli, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.0b2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

9.67 KB, patch
InvisibleSmiley
: review+
InvisibleSmiley
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

15 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021115
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3a) Gecko/20021115

Following bug 148650, Mozilla should record date and time a download has been
started, and have a corresponding column in Download Manager for better
organizing downloads.


Reproducible: Always

Steps to Reproduce:

Comment 1

14 years ago
Would be good, but we already have time elapsed/past and if you knew math you
could figure out when you started.

I wouldn''t even care when I started.
(Reporter)

Comment 2

14 years ago
This is not about math. Pham.

It would give a the user a clue about when he downloaded what.

Time elapsed is a totally different thing. Try sorting all your downloads with
that column, a you have nothing usefull in your hands.

Updated

14 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 3

14 years ago
*** Bug 193374 has been marked as a duplicate of this bug. ***
*** Bug 207598 has been marked as a duplicate of this bug. ***

Updated

14 years ago
Summary: [RFE] Add Date & Time for started (or added) download → Add Date & Time for started (or added) download

Comment 5

14 years ago
*** Bug 209156 has been marked as a duplicate of this bug. ***
*** Bug 212812 has been marked as a duplicate of this bug. ***
*** Bug 213579 has been marked as a duplicate of this bug. ***
*** Bug 213697 has been marked as a duplicate of this bug. ***

Comment 9

14 years ago
I've just added my vote for this bug.  I'm tempted to call it a bug instead of
an enhancement since it really is a core part of what makes a download manager
useful.  Adding "Time Started" and "Time Finished" columns should be pretty easy.

I'd suggest including the start time by default as well.  This would really be
useful as I have a list of about a hundred downloads and I'm curious when they
went off.

Comment 10

14 years ago
Since some of the dupes included the word "column" it would probably be better
to rename the summary of this bug to "Add Date & Time columns for started (or
added) download". This would make it easier for users to find this bug and would
help prevent additional dupes.

Prog.
Product: Browser → Seamonkey

Comment 11

12 years ago
I have voted for both this and bug 148650 in hope that one of them is
implemented.  For any log, the date and time of the log entry should always be
part of the entry.  

Comment 12

11 years ago
Given that this [simple to resolve] bug/omission has been around for several years with repetitive requests for resolution could someone please address the issue.

Mozilla do a lot of good work but if no one addresses annoying issues it tends to indicate that Open Source does not work so well when it comes to support.

Thanks
Assignee: bross2 → download-manager
QA Contact: chrispetersen

Updated

10 years ago
Duplicate of this bug: 402739

Updated

8 years ago
Duplicate of this bug: 148650

Comment 15

8 years ago
The new download manager UI introduced by bug 472001 is now aware of that data (both start and end timestamps), as the toolkit download manager records it. We do not expose it in UI yet and have no immediate plans for it, but we possibly would take a patch that adds it in the optional non-default set of available columns.
Depends on: 472001

Updated

8 years ago
Assignee: download → nobody
QA Contact: download
(Assignee)

Comment 16

8 years ago
Created attachment 394723 [details] [diff] [review]
proposed patch
Assignee: nobody → jh
Status: NEW → ASSIGNED
Attachment #394723 - Flags: review?(neil)

Updated

8 years ago
Attachment #394723 - Flags: review?(neil) → review+
Comment on attachment 394723 [details] [diff] [review]
proposed patch

>       <treecol id="TimeElapsed" hidden="true"
>                label="&col.timeelapsed.label;"
>                tooltiptext="&col.timeelapsed.tooltip;"
>                class="sortDirectionIndicator" flex="1"
>                persist="width hidden ordinal sortActive sortDirection"/>
>       <splitter class="tree-splitter"/>
>+      <treecol id="StartTime" hidden="true"
>+               label="&col.starttime.label;"
>+               tooltiptext="&col.starttime.tooltip;"
>+               class="sortDirectionIndicator" flex="1"
>+               persist="width hidden ordinal sortActive sortDirection"/>
>+      <splitter class="tree-splitter"/>
>+      <treecol id="EndTime" hidden="true"
>+               label="&col.endtime.label;"
>+               tooltiptext="&col.endtime.tooltip;"
>+               class="sortDirectionIndicator" flex="1"
>+               persist="width hidden ordinal sortActive sortDirection"/>
>+      <splitter class="tree-splitter"/>
>       <treecol id="Source" hidden="true"
>                label="&col.source.label;"
>                tooltiptext="&col.source.tooltip;"
>                class="sortDirectionIndicator" flex="1"
>                persist="width hidden ordinal sortActive sortDirection"/>
[Strange that this list is in a slightly different order to the other three...]
(Assignee)

Updated

8 years ago
Attachment #394723 - Flags: superreview?(neil)

Updated

8 years ago
Attachment #394723 - Flags: superreview?(neil) → superreview+
Comment on attachment 394723 [details] [diff] [review]
proposed patch

[I wonder whether any of our columns should be right-aligned?]

>+      case "StartTime":
>+        if (dl.startTime)
>+          return new Date(dl.startTime).toLocaleString();
>+        return "";
>+      case "EndTime":
>+        if (dl.endTime)
>+          return new Date(dl.endTime).toLocaleString();
>+        return "";
I've just remembered that we don't use toLocaleString on dates. Instead I'd do something similar to what we do for History. sr=me with that fixed.

Comment 19

8 years ago
(In reply to comment #18)
> (From update of attachment 394723 [details] [diff] [review])
> [I wonder whether any of our columns should be right-aligned?]

You could have to columns left aligned by default but when a user right clicks on the columns they can select left or right alignment.
(Assignee)

Comment 20

8 years ago
Created attachment 394868 [details] [diff] [review]
patch v2

(In reply to comment #18)
> (From update of attachment 394723 [details] [diff] [review])
> [I wonder whether any of our columns should be right-aligned?]
> 
> >+      case "StartTime":
> >+        if (dl.startTime)
> >+          return new Date(dl.startTime).toLocaleString();
> >+        return "";
> >+      case "EndTime":
> >+        if (dl.endTime)
> >+          return new Date(dl.endTime).toLocaleString();
> >+        return "";
> I've just remembered that we don't use toLocaleString on dates.

Counter example (not saying it's better): abCardViewOverlay.js

> Instead I'd do something similar to what we do for History.

Probably a good idea.

(In reply to comment #19)
> (In reply to comment #18)
> > (From update of attachment 394723 [details] [diff] [review] [details])
> > [I wonder whether any of our columns should be right-aligned?]
> 
> You could have to columns left aligned by default but when a user right clicks
> on the columns they can select left or right alignment.

I guess Neil was referring to the default, static settings. Adding the ability to switch alignments seems a bit excessive to me. ;-)

Anyway, IMHO that discussion should be taken to a new bug - if anyone really cares about it.
Attachment #394723 - Attachment is obsolete: true
Attachment #394868 - Flags: superreview+
Attachment #394868 - Flags: review+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Pushed to comm-central http://hg.mozilla.org/comm-central/rev/2870eb8a8beb
Keywords: checkin-needed
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b2

Updated

8 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.