1817915 - Add context menu to "Get Messages" folder pane header button

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, task)

Description

[Alessandro Castellani [:aleca]]

We should implement a right click context menu on the "Get Messages" folder pane header button.
The context menu should list all currently available accounts and clicking on one of them should trigger the fetching of message for only that account.

Basically, identical behaviour of what we have in 102 with the Get Messages spin button.
This was the old toolbar button.

This uses the folder-menupopup class, which is a bit overkill for what we need, but some aspects of it are needed.
https://searchfox.org/comm-esr102/rev/68a40ae7eec56b5c562209fba62b80e7c9c18ffe/mailnews/base/content/folder-menupopup.js#1073
Let's sync up on this to find a good approach.

Comment 1

[Thomas D. (:thomas8)]

Add [Supernova] to Whiteboard 20230222_1327

Comment 2

[PS]

So the buttons with the drop-down menu are a thing of the past? The user now needs to "discover" the context menu? It's the same issue as for the Back/Forward buttons which now have a context menu with the history instead of a drop-down menu.

Comment 3

[Alessandro Castellani [:aleca]]

We will re-implement those spin buttons in pure HTML, but those are very very tricky.
They're not properly keyboard accessible, they don't communicate to screen readers the existence of a menupopup, and they don't allow triggering extra options via contextmenu keys, so they're a bit of a nightmare.
We need more time to properly build a semantically correct and fully accessible HTML spin button, so in the meantime we're adding the extra options that might be needed inside context menus.

Comment 4

[PS]

Thanks for the explanation. Would a custom element work?

Comment 7

[Alessandro Castellani [:aleca]]

Attachment: Bug 1817915 - Add context menu to Get Messages folder pane button to fetch all messages or per account. r=darktrojan

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/83bd374aa2da
Add context menu to Get Messages folder pane button to fetch all messages or per account. r=darktrojan

Comment 9

[Rob Lemley [:rjl]]

The migration script that landed has an error. Follow-up patch to follow.

Comment 10

[Rob Lemley [:rjl]]

Attachment: Bug 1817915 - Follow-up: Fix error in string migration script. r=#thunderbird-front-end-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/58b2fd42f331
Follow-up: Fix error in string migration script. r=aleca

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9334586 [details]
Bug 1817915 - Follow-up: Fix error in string migration script. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9333005 [details]
Bug 1817915 - Add context menu to Get Messages folder pane button to fetch all messages or per account. r=darktrojan

[Triage Comment]
Approved for beta

Comment 14

[Daniel Darnell [:dandarnell]]

Thunderbird 114.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/cf3dfafaae6e
https://hg.mozilla.org/releases/comm-beta/rev/3f3df3aca285