1840705 - Translation task queue stops running on Twitter

Status: VERIFIED FIXED

(Firefox :: Translations, defect, P2)

Description

[André Natal]

DOM mutations on Twitter are not being captured.

STR:

1 - Go to https://twitter.com/home
2 - Start a translation from a language that your tweets are usually displayed
3 - Start scrolling and note that new tweets are not translated after a while

Expected result:

All new DOM elements added to the page should be translated, in this case, new tweets.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away 4/27 - 5/6)]

I briefly checked what happens, but I'm not sure what's going on. Looks like that the MutationObserver receives the notification of the added nodes correctly. Then, they will be queued. Then, they'll be submitted as "out-of-view" nodes. Finally, they reach here and finally added a message listener and waited for the end. However, the message listener seems never kicked. So, I guess that this is caused by a bug in the module.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

My investigation showed that comment #1 is very correct, and the task queue in translations-engine-worker.js is growing forever. And then I found that there's a typo that causes a task queue to never finish: https://searchfox.org/mozilla-central/rev/e9b338c2d597067f99e96d5f20769f41f312fa8f/toolkit/components/translations/content/translations-engine-worker.js#771 (It's now .isRunning = false but it should be .#isRunning = false). I'll submit a patch.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1840705 - Fix isRunning typo in translations-engine-worker.js r=marco

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

(I'm sure we'll want to uplift this)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be3fab03251c
Fix isRunning typo in translations-engine-worker.js r=gregtatum

Comment 6

[Marco Castelluccio [:marco]]

Donal, just putting this on your radar: it'd be really nice to uplift to 119 given it is fixing an important bug in a new feature and the fix is really simple.

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/be3fab03251c

Comment 8

[Donal Meehan [:dmeehan]]

(In reply to Marco Castelluccio [:marco] from comment #6)

Donal, just putting this on your radar: it'd be really nice to uplift to 119 given it is fixing an important bug in a new feature and the fix is really simple.

Can I get an uplift request on this and I can include it for RC

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Comment on attachment 9358114 [details]
Bug 1840705 - Fix isRunning typo in translations-engine-worker.js r=marco

Beta/Release Uplift Approval Request

• User impact if declined: Users won't be able to get the translated content when the page changes.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See https://phabricator.services.mozilla.com/D190827#6321716
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's just a typo fix.
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9358114 [details]
Bug 1840705 - Fix isRunning typo in translations-engine-worker.js r=marco

Approved for 119.0 RC1

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8eac8d7bb81d

Comment 19

[Alexandru Trif, Desktop QA [:atrif]]

(In reply to Kagami [:saschanaz] (they/them) from comment #9)

Comment on attachment 9358114 [details]
Bug 1840705 - Fix isRunning typo in translations-engine-worker.js r=marco

• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See https://phabricator.services.mozilla.com/D190827#6321716

Hello and thank you for the detailed steps. I want to confirm that what I'm seeing is correct by following the next steps:

1. Open Reddit and log in.
2. Activate and open the multiprocess browser toolbox and select Debugger.
3. Go back to the Reddit page and manually translate the page (App Menu> Translate page) once to German then click Show original (this is how the translations-ending-worker.js is displayed for me in the toolbox)
4. Set the following log points: line714 on line 714, line731 on line 731 and line771 on line 771 and enable split console.
5. Manually translate the page to German and wait for the line771 message to be displayed.
6. Scroll down to the bottom of the page and observe the results
   Actual result: line714, line731 and line771 are displayed again (I get multiple messages for this).
   Note: with Firefox 118.0.2 I can only see the line714 message displayed by following the same steps.

I have also made a screen recording. Can you please confirm that the steps and expected results are accurate?

Also following the below steps will not translate the newly loaded content for me if I'm not logged in, but it seems that it is working if I'm logged in, is this expected?

1. Go to reddit.com
2. Manually translate from English to Spanish.
3. Wait until the page is fully translated.
4. Scroll down to the bottom to load in new Reddit posts.

Testing was performed with Firefox 120.0a1 (2023-10-16). Thank you in advance!

Comment 20

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: reddit_18407005.gif

Screen recording...

Comment 21

[Kagami Rosylight [:saschanaz] (they/them)]

(In reply to Alexandru Trif, Desktop QA [:atrif] from comment #19)

I have also made a screen recording. Can you please confirm that the steps and expected results are accurate?

The GIF looks good, thanks! The point is that you get the line 771, scroll down, and you get line 731 again, which is definitely happening on your screen recording 👍

Also following the below steps will not translate the newly loaded content for me if I'm not logged in, but it seems that it is working if I'm logged in, is this expected?

That's bug 1842820, because somehow Reddit renders things differently when you are not logged in.

Comment 22

[Alexandru Trif, Desktop QA [:atrif]]

(In reply to Kagami [:saschanaz] (they/them) from comment #21)

(In reply to Alexandru Trif, Desktop QA [:atrif] from comment #19)

I have also made a screen recording. Can you please confirm that the steps and expected results are accurate?

The GIF looks good, thanks! The point is that you get the line 771, scroll down, and you get line 731 again, which is definitely happening on your screen recording 👍

Also following the below steps will not translate the newly loaded content for me if I'm not logged in, but it seems that it is working if I'm logged in, is this expected?

That's bug 1842820, because somehow Reddit renders things differently when you are not logged in.

Thank you for the response!

The issue is verified fixed with Firefox 120.0a1 (2023-10-16) on Windows 10x64, macOS 12 and Ubuntu 20.04 by using steps from comment 19. After line 771 is displayed on the first page translate, scrolling down the Reddit page will display again lines 714, 731, and 771 when new Reddit content is loaded.

I will verify this again with Firefox 119.0RC1 when the official build is available. Thank you!

Comment 23

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with Firefox 119.0RC1 on Windows 10x64, macOS 12 and Ubuntu 20.04 by using steps from comment 19. Lines 714, 731, and 771 are displayed again when loading new content on Reddit while the user is logged in.