1841098 - Move mitmproxy binary out of tooltool

Status: RESOLVED WONTFIX

(Testing :: Performance, enhancement, P3)

Description

[Kash Shampur [:kshampur] ⌚EST]

I am thinking either Mitmproxy as either a toolchain task or our own mozilla fork?
This would be useful as we could pin revisions in our code (like we do with our other major tool browsertime)
which could be useful (e.g. when we uplift our changes mentioned in Bug 1821741, we could just use the revision rather than waiting for the next release version)

and also future looking, if there are any improvements, bug fixes, or even version upgrades etc. we could just change the revision hash rather than having to download and upload to tooltool.

Comment 1

[Kash Shampur [:kshampur] ⌚EST]

Try run

https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=8a025bbd4b9897ea0e82357599eb952ed82c98b6&selectedTaskRun=CS4CF_hKRmqBzFWIC2d2jQ.0

Should work for windows/linux which have python 3.9.x

but not OSX which is running 3.7

Comment 2

[Kash Shampur [:kshampur] ⌚EST]

I will close this as WONTFIX
We would basically have to upgrade the machines python version every mitmproxy upgrade if we are to use pypi installations (or even if we are building from source). This is not practical for now so we should continue using tooltool.

Comment 3

[Kash Shampur [:kshampur] ⌚EST]

If we can control the python version in Bug 1874710 (i.e. using the toolchains like i mentioned in Bug 1874710, comment 1) this bug can be worth revisiting since the major limiting factor was the system python versions being outside of our control. It would be easier to update in-tree toolchain python