1805509 - Add Set Default PDF handler action to `SpecialMessageActions` API

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Nick Alexander :nalexander [he/him]]

This ticket tracks adding a SET_DEFAULT_PDF_HANDLER action to the SpecialMessageActions API that lets users set Firefox as the default PDF handler. This should be Windows-only, at first.

The work will need to happen around SpecialMessageActions.jsm.

Comment 1

[Ed Lee :Mardak]

This might require some ShellService related changes too if we want to specifically set as default pdf without plain default browser. Bug 1790107 added setDefaultPDFHandler as an additional capability of setting default browser and bug 1761504 made it so it checks another condition.

Unclear if this bug wants to follow or override some of the additional checks if the action is "yes set Firefox as pdf handler"

Comment 2

[Beth Rennie [:beth] (she/her)]

Clearing iteration and priority to bring up in triage next week now that product is looking at using this in an experiment soon.

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: 1805509-data-review.md

Comment 4

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1805509 - Set default extension handlers via defaultagent r?nalexander

Comment 5

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1805509 - Add ShellService.setAsDefaultPDFHandler r?nalexander

Depends on D169816

Comment 6

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1805509 - Add SET_DEFAULT_PDF_HANDLER special message action r?#omc-reviewers

Depends on D169817

Comment 7

[Chris H-C :chutten]

Comment on attachment 9317546 [details]
1805509-data-review.md

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 118.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a87f459f2caa
Set default extension handlers via defaultagent r=nalexander
https://hg.mozilla.org/integration/autoland/rev/0bf2579bccd7
Add ShellService.setAsDefaultPDFHandler r=nalexander
https://hg.mozilla.org/integration/autoland/rev/1c1d335d4ef5
Add SET_DEFAULT_PDF_HANDLER special message action r=omc-reviewers,emcminn

Comment 9

[Sandor Molnar[:smolnar]]

Backed out for causing for causing node newtab failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/ba36dea109e7851e4c392dc57e6c7aada3790fbf

Push with failures

Failure log NODE NEWTAB: TEST-UNEXPECTED-FAIL karma | activity-stream:ASRTargeting docs:All targeting params documented in targeting-attributes.md should have docs and table of contents entry for isDefaultHandler: Didn't find the heading:

Failure log BROWSER-CHROME: TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_asrouter_targeting.js | Uncaught exception in test bound check_totalBookmarksCount

Failure log XPC : toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_experiments.js | test_backgroundtask_Nimbus_targeting - test_backgroundtask_Nimbus_targeting

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87641a6eee2b
Set default extension handlers via defaultagent r=nalexander
https://hg.mozilla.org/integration/autoland/rev/3dd1735b85fa
Add ShellService.setAsDefaultPDFHandler r=nalexander
https://hg.mozilla.org/integration/autoland/rev/31a8dcad0d88
Add SET_DEFAULT_PDF_HANDLER special message action r=omc-reviewers,emcminn

Comment 11

[Sandor Molnar[:smolnar]]

Backed out for causing browser-chrome and xpc failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/8ff160f42b181a2ccd2be11ca7a632c271c1b639

Push with failures

Failure log: browser-chrome -> TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_asrouter_targeting.js | Uncaught exception in test bound check_totalBookmarksCount

Failure log: xpc -> TEST-UNEXPECTED-FAIL | toolkit/components/backgroundtasks/tests/xpcshell/test_backgroundtask_experiments.js | test_backgroundtask_Nimbus_targeting - [test_backgroundtask_Nimbus_targeting : 307]

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8f7f5acc520
Set default extension handlers via defaultagent r=nalexander
https://hg.mozilla.org/integration/autoland/rev/48cb34b7d26a
Add ShellService.setAsDefaultPDFHandler r=nalexander
https://hg.mozilla.org/integration/autoland/rev/e75a7ce5891f
Add SET_DEFAULT_PDF_HANDLER special message action r=omc-reviewers,emcminn

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b8f7f5acc520
https://hg.mozilla.org/mozilla-central/rev/48cb34b7d26a
https://hg.mozilla.org/mozilla-central/rev/e75a7ce5891f

Comment 14

[Simona Rosu [:srosu], Ecosystem QA]

I’m marking this as Verified on 112 since this enhancement was part of the work done on QA-1801, for which we sent a Testing Report.