1859829 - Add search to recently closed tabs

Status: VERIFIED FIXED

(Firefox :: Firefox View, enhancement)

Description

[Sarah Clements [:sclements]]

We want to add search per the spec, and design it in a way that the search algorithm can be reused for searching other sections.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: sessionstore-1000-closedtabs.jsonlz4

I put together some session backup files to try and get some benchmarks. I'm attaching the one with 1000 recently-closed tabs. I used a top-1000 list of sites to generate tab entries. They all share the same icon, but the title and lastAccessed dates are all different to try and get something close-ish to a real scenario.

To use:

• Close the browser you want to test
• Copy in the attached sessionstore-1000-closedtabs.jsonlz4 file into the profile directory and rename it sessionstore.jsonlz4 (don't use a valuable profile, or back up your sessionstore-backups folder if you do.)
• Start the browser and open Firefox View, and click on the "Recently Closed Tabs" link on the side.

I believe we currently cap the number of entries we show in this list. This session file is to allow for exploratory performance testing if we or the user changes that cap.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Attachment: sessionstore-3500-closedtabs.jsonlz4

Same idea, this time with 3500 closed tabs.

Comment 3

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1859829 - Add search to recently closed tabs r?#fxview-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3c698fda337
Add search to recently closed tabs r=fxview-reviewers,fluent-reviewers,bolsson,sclements

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a3c698fda337

Comment 6

[Daniel Bodea [:danibodea]]

I can confirm the appearance and functionality of the search bar in the Firefox View Recently closed tabs section. Tested in Windows 10, Windows 11, MacOS 11 and Ubuntu 22 using Firefox Release v122.0.1, Beta v123.0 (RC) and Nightly v124.0a1. It is displayed by default in branch 124 and 123, but needs to be activated manually in branch 122. Thank you.