1866819 - Triggering the reply command when viewing a collapsed thread causes a composer to open for every message in the thread, with mail.operate_on_msgs_in_collapsed_threads set to true

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[Brendan Abolivier [:babolivier]]

Split out of bug 1866660

When attempting to reply on a collapsed thread (e.g. hitting the Ctrl/Cmd+R shortcut), a new composer opens with a reply for every single message in the thread.

This issue is due to how we enable the reply command. In 102 and prior, we make a specific exception for collapsed threads here - see bug 500216. Since then, the 3-pane view has been reworked, with bug 1735119 re-adding commands such as reply to the new code, although the reply command then was limited to selections of 1 message. Then bug 1855065 re-introduced the ability to reply to several messages at once but didn't implement the special case for collapsed threads.

Therefore we need to reintroduce a check around here to prevent some actions to be run when the selection is a collapsed thread (while still allowing them when selecting several individual messages).

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1866819 - Disable reply, forward, etc. for collapsed threads. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/05db9de7af25
Disable reply, forward, etc. for collapsed threads. r=aleca

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9365742 [details]
Bug 1866819 - Disable reply, forward, etc. for collapsed threads. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Risk to taking this patch (and alternatives if risky): Low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9365742 [details]
Bug 1866819 - Disable reply, forward, etc. for collapsed threads. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 121.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/1f82037d0a0c

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9365742 [details]
Bug 1866819 - Disable reply, forward, etc. for collapsed threads. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9365742 [details]
Bug 1866819 - Disable reply, forward, etc. for collapsed threads. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr115.
115.6.1 will likely ship the week of Jan 8.

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 115.6.1:
https://hg.mozilla.org/releases/comm-esr115/rev/f91473386edd