Closed Bug 1870828 Opened 10 months ago Closed 9 months ago

[wpt-sync] Sync PR 43724 - [position-fallback] Avoid two-pass without fallback styles

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
123 Branch
Tracking Flags:
Tracking Status
firefox123 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 43724 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43724
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

[position-fallback] Avoid two-pass without fallback styles

@try fallbacks are done with base computed style without animations
applied first, with animations applied in a second step. If there are no
fallback styles there is no need to do the base computed style step.

This fixes the DCHECK triggered by TryCalculateOffset mixing styles from
the LayoutInputNode and the passed in style which may be the base style.
However, it just fixes the cases where there are no position fallback
styles present. That will be fixed in a separate CL.

Bug: 1512373
Change-Id: I72de67cc0b5ffbf4208f361a2947448d876df87c
Reviewed-on: https://chromium-review.googlesource.com/5132397
WPT-Export-Revision: d5c0527e9e857be65e7f2a61fce706b9b43c2485

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f97377cbe8dd [wpt PR 43724] - [@position-fallback] Avoid two-pass without fallback styles, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3b02c2261be [wpt PR 43724] - [@position-fallback] Avoid two-pass without fallback styles, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a3b02c2261be

Status: NEW → RESOLVED
Closed: 9 months ago
status-firefox123: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
You need to log in before you can comment on or make changes to this bug.