Test function getAddonCard clicks on an addon-name-container link instead of its container
Categories
(Toolkit :: Add-ons Manager, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox124 | --- | fixed |
People
(Reporter: ayeddi, Assigned: ayeddi)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(1 file)
Test function getAddonCard clicks on an addon-name-container instead of its containing link. This triggers accessibility unit tests to fail, because it is not expected for a containing element to be interactive (which is being checked by a11y_checks). Querying for .addon-name-link would allow for a11y_checks to pass while the addon cards being activated.
Note, that the bug 1873255 and its patch ensure that there are both types of activation that are tested for add on card activation: both the click on a link and a click on the general container too (refer to the comments in the patch D197811)
|
Assignee | |
Updated•4 months ago
|
|
|
Assignee | |
Comment 1•4 months ago
|
||
To correct the approach: the function is used in many ways, not only for clicking, so I think manually adding the mix of the query for an inner link and a11y_checks exception to this function’s clicking instances would probably be the best.
|
||
Updated•4 months ago
|
|
|
Assignee | |
Comment 2•4 months ago
|
||
Adding a query from the getAddonCard to target the anchor within it.
|
||
Updated•4 months ago
|
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3a17f40b419c Update toolkit/mozapps/extensions/test/browser/browser_sidebar_categories.js to click on an addon-name-container link instead of its container. r=extension-reviewers,willdurand
|
||
Comment 4•4 months ago
|
||
| bugherder | ||
Description
•