1868568 - Update 3 mochitests that click on an <addon-card> container instead of its containing link to pass a11y-checks

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P3)

Description

[Anna Yeddi [:ayeddi]]

The test toolkit/mozapps/extensions/test/browser/browser_colorwaybuiltins_migration.js fails when the assertDetailView sends a click on the clickable but not accessible container of a card <addon-card> while there is a fully accessible link element that is included in the card and thus should be an expected target for the Details View activation to test behavior for all users is functioning.

We could update this test to query the link element and send a click to it to allow the a11y-checks to pass and to confirm the card is accessible for users of keyboards and assistive technology as well as mouse/touch users.

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1868568 - Update 3 mochitests that click on an <addon-card> container instead of its containing link to pass a11y-checks. r=rpl!

The test toolkit/mozapps/extensions/test/browser/browser_colorwaybuiltins_migration.js fails when the assertDetailView sends a click on the clickable but not accessible container of a card <addon-card> while there is a fully accessible link element that is included in the card and thus should be an expected target for the Details View activation to test behavior for all users is functioning.

We could update this test to query the link element and send a click to it to allow the a11y-checks to pass and to confirm the card is accessible for users of keyboards and assistive technology as well as mouse/touch users.

Comment 2

[Anna Yeddi [:ayeddi]]

All 3 tests that are failing (with stack trace):

toolkit/mozapps/extensions/test/browser/browser_colorwaybuiltins_migration.js
Node is not accessible via accessibility API
ADDON-CARD		
"
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:339
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:658
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:635
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleClick:751
chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_colorwaybuiltins_migration.js:assertDetailView:111
chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_colorwaybuiltins_migration.js:test_update_expired_colorways_builtins:201
chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_colorwaybuiltins_migration.js:test_colorways_builtin_theme_migration:249
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
"
toolkit/mozapps/extensions/test/browser/browser_history_navigation.js
Node is not accessible via accessibility API
ADDON-CARD	
"
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:339
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:658
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:635
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleClick:751
chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_history_navigation.js:expand_addon_element:117
chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_history_navigation.js:test_navigate_history:156
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
"
toolkit/mozapps/extensions/test/browser/browser_html_scroll_restoration.js
Node is not accessible via accessibility API
ADDON-CARD	
"
chrome://mochikit/content/browser-test.js:test_ok:1583
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:a11yFail:339
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:assertCanBeClicked:658
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:runIfA11YChecks/this.AccessibilityUtils:635
chrome://mochikit/content/tests/SimpleTest/AccessibilityUtils.js:handleClick:751
chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_html_scroll_restoration.js:test_scroll_restoration:162
chrome://mochikit/content/browser-test.js:handleTask:1134
chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1206
chrome://mochikit/content/browser-test.js:Tester_execTest:1348
chrome://mochikit/content/browser-test.js:nextTest/<:1123
chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
"

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a1d320c93ae
Update 3 mochitests that click on an <addon-card> container instead of its containing link to pass a11y-checks. r=rpl,extension-reviewers

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/4a1d320c93ae