Closed Bug 1873255 Opened 4 months ago Closed 3 months ago

Update 5 mochitests that click on an addon-name-container instead of its containing link to pass a11y-checks

Categories

(Toolkit :: Add-ons Manager, task, P3)

task

Tracking

()

RESOLVED FIXED
124 Branch
Tracking Status
firefox124 --- fixed

People

(Reporter: ayeddi, Assigned: ayeddi)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

There are following tests in toolkit/mozapps/extensions/test/browser/ that fail a11y_checks when they send a click on the clickable but not accessible container .addon-name-container in:

  1. browser_globalwarnings.js#11,
  2. browser_html_detail_view.js#346,405,
  3. browser_html_updates.js#31
  4. browser_gmpProvider.js#52
  5. switchToDetailView() in head.js#1696 in browser_html_pending_updates.js
  • while there is a fully accessible link element that is included in each card and thus should be an expected target for the Details View activation to test behavior for all users is functioning.

We could update this test to query the link element and send a click to it to simulate and confirm the card is accessible for users of keyboards and assistive technology as well as mouse/touch users, and to allow the a11y-checks to pass. In this case, we need to update the fail-if notations of the test manifest accordingly.

Summary: Update 3 mochitests that click on an addon-name-container instead of its containing link to pass a11y-checks → Update 5 mochitests that click on an addon-name-container instead of its containing link to pass a11y-checks

There are following tests in toolkit/mozapps/extensions/test/browser/ that fail a11y_checks when they send a click on the clickable but not accessible container .addon-name-container in:

  1. browser_globalwarnings.js#11,
  2. browser_html_detail_view.js#346,405,
  3. browser_html_updates.js#31
  4. browser_gmpProvider.js#52
  5. switchToDetailView() in head.js#1696 in browser_html_pending_updates.js
  • while there is a fully accessible link element that is included in each card and thus should be an expected target for the Details View activation to test behavior for all users is functioning.

We could update this test to query the link element and send a click to it to simulate and confirm the card is accessible for users of keyboards and assistive technology as well as mouse/touch users, and to allow the a11y-checks to pass. In this case, we need to update the fail-if notations of the test manifest accordingly.

Assignee: nobody → ayeddi
Status: NEW → ASSIGNED

Another test that is affected: browser_menu_button_accessibility.js#72

See Also: → 1876618
Attachment #9371341 - Attachment description: Bug 1873255 - Update 5 mochitests that click on an addon-name-container instead of its containing link to pass a11y-checks. r=rpl! → Bug 1873255 - Update 6 mochitests that click on an addon-name-container instead of its containing link to pass a11y-checks. r=rpl!
Blocks: 1877049
Blocks: 1877051
Pushed by ayeddi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0a09cf1582e
Update 6 mochitests that click on an addon-name-container instead of its containing link to pass a11y-checks. r=rpl
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: