1886132 - news: message URIs do not work anymore.

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

Steps to reproduce:

1. Create a message that contains a news: URI such as
   news://news.eternal-september.org/u9bk2v$h4v$[e-mail].
   Save it as draft and open it in the message pane.
2. Click the link.

Alternatively, start Thunderbird from the command line with the news: URI as argument.

Expected result:

A message window opens into which the message identified by the message-id is loaded from the server into.

Actual result:

Just a blank message window opens. Error console shows

Uncaught TypeError: gMessage is null
    displayMessage chrome://messenger/content/aboutMessage.js:171
    actuallyLoadMessage chrome://messenger/content/messageWindow.js:173
aboutMessage.js:171:3

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1886132 - Restore and improve functionality to open 'news' URIs. r=mkmelin

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1886132 - Open news: URIs in a new tab or window depending on preference. r=mkmelin

Depends on D205036

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1886132 - Improve handling of news: URIs. r=mkmelin

• Enable opening news: URIs that do not specify a host by using the first NNTP server found.
• Open newsgroups identified by a URI directly without opening an empty message window.

Depends on D205037

Comment 4

[Alfred Peters [:infofrommozilla]]

I have already tested the two patches. I already like it very much.
However, I have noticed two small things:

1. The link should be percent-decoded before processing.
   <news://news.solani.org:119/[e-mail]> works
   <news://news.solani.org:119/871q9ajpqx.fsf-_%40usenet.ankman.de> does not

2. The context menu does not match the link type.

Comment 5

[Hartmut Welpmann [:welpy-cw]]

(In reply to Alfred Peters [:infofrommozilla] from comment #4)

I have already tested the two patches. I already like it very much.

Thank you for your valuable feedback.

However, I have noticed two small things:

1. The link should be percent-decoded before processing.
   <news://news.solani.org:119/[e-mail]> works
   <news://news.solani.org:119/871q9ajpqx.fsf-_%40usenet.ankman.de> does not

Good catch, this should work now.

2. The context menu does not match the link type.

Yeah, as in many other cases in Thunderbird, the default action is not represented in the context menu. Maybe something for another bug?

Comment 6

[Alfred Peters [:infofrommozilla]]

(In reply to Hartmut Welpmann [:welpy-cw] from comment #5)

Good catch, this should work now.

Yes it works now.

Thank.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5dd5a6026384
Restore and improve functionality to open 'news' URIs. r=mkmelin