1886653 - Focus doesn't follow Open in new tab (since mail.tabs.loadInBackground false is now respected, change to true?)

Status: VERIFIED FIXED

(Thunderbird :: Message Reader UI, defect, P2)

Description

[David G King]

In TB 125b1 (64 bit) under Win 11 x64 when I open a mail message the message opens in a new tab (as per settings). However, the focus doesn't follow to that new tab. This worked fine in TB 124b3. In web browsers such as Firefox or Chrome, this behaviour would be controlled by a UI in Settings.

Comment 1

[Wayne Mery (:wsmwk)]

Bonus, can you find the regression range with daily builds using https://mozilla.github.io/mozregression/ ?

Comment 2

[David G King]

It's been a while since I last used moregression, but I will see what I can come up with.

Comment 3

[David G King]

Between comm-central build 2024-02-24 (bad) and comm-central build 46a93c48 (good)

mozregression points to https://phabricator.services.mozilla.com/D199905

Comment 4

[Wayne Mery (:wsmwk)]

Nice work!

Comment 5

[solange]

openMessageBehaviorPref defines how a new message will open, that being a new tab, new window or existing window. mail.tabs.loadInBackground defines how a new tab will load. Double clicking or middle clicking a message would both make the message load on the background if mail.tabs.loadInBackground is true. One can quickly open a message on the foreground by pressing shift while middle/double clicking. If one wishes to change the value of mail.tabs.loadInBackground to false then when a new tab load it would always be in fg and to make something load in the bg you would press shift while clicking.

To change this value got to settings and scroll all the way down to > config edit/advance preferences and search for mail.tabs.loadInBackground.

Comment 6

[David G King]

Changing that config setting fixed it for me. Is this a case of the setting now working and always being true? And, should there be a UI to allow easy changing of that setting?

Comment 10

[Anje]

mail.tabs.loadInBackground defines how a new tab will load. Double clicking or middle clicking a message would both make the message load on the background if mail.tabs.loadInBackground is true.
bug 1888872

Middle-click previously just failed to work - but now it is working perfectly ok.

But double click to open in anew tab - opened in new tab but no focus.
Why ? because the default is still set on 'True' which in previous versions was irrelevant because a double click to open in a new tab always worked no matter what setting was set as default. Email always opened with focus in tab. However, now that means by default will suddenly work correctly and people will find they do not have focus.
Please set the default to 'False' so that the Support Forum is not inundated with people asking why is Thunderbird not opening with focus when you double click.

OR have I misunderstood and is this an update which is not yet been uploaded 125.0b2 ?

Comment 12

[Anje]

solange - I'm using beta 125.0b5 and the default for mail.tabs.loadInBackground is still 'True' so not fixed.
Any idea which version will see the default set to 'False' ?

Comment 13

[Alessandro Castellani [:aleca]]

Assigning this to Vineet.
Let's switch that preference to false but see if we need to add a profile migration to ensure that we're not overwriting a user's modified pref.

Comment 15

[Vineet Deo]

Attachment: Bug 1886653 - Set mail.tabs.loadInBackground preference to default to false. r=#thunderbird-reviewers

How to Test

• Run a clobber do get a fresh TB profile
• Opening a message in a new tab should now focus to that tab

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/aee755377c30
Set mail.tabs.loadInBackground preference to default to false. r=aleca

Comment 18

[Wayne Mery (:wsmwk)]

V.fixed on daily.

Good for uplift to beta?

Comment 20

[Vineet Deo]

Comment on attachment 9398158 [details]
Bug 1886653 - Set mail.tabs.loadInBackground preference to default to false. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1876883
User impact if declined: The default behavior for opening a message in a new tab would be to open in the background.
Testing completed (on c-c, etc.): Tested on daily
Risk to taking this patch (and alternatives if risky): Working on follow up patch to clear up some functionality with the context menu and middle click actions with respect to the preference.

Comment 21

[Wayne Mery (:wsmwk)]

Comment on attachment 9398158 [details]
Bug 1886653 - Set mail.tabs.loadInBackground preference to default to false. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 22

[Rob Lemley [:rjl]]

Thunderbird 126.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/a42e283d9c52

Comment 23

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Managed to reproduce the issue with the affected build from 2024-03-20 (20240320102002) .

Confirming this issue as verified fixed with 126.0b3(20240506165103) using Windows 11, macOS 14 and Ubuntu 22.