1928213 - Remove stopgap MOZ_RUNINIT use in nsMsgDBView.cpp

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Ben Campbell]

After Bug 1920718, global vars that require construction must be explicitly flagged, and that was done in Bug 1928157.
But we shouldn't really have any such variables - constructing things before main() is always a little fraught.
The patch in Bug 1928157, D227403 can be used as a roadmap of what needs changing.

nsMsgDBView sets up some localised strings to share across instances. Seems like there should be a better way (I'd look at m-c code for equivalent examples).

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1928213 - Migrate properties used by nsMsgDBView to fluent. r=mkmelin,dandarnell

Migrate strings used by nsMsgDBView and nsMsgGroupView from
messenger.properties to messenger.ftl.

Strings only used in the 'Search Messages' dialog by a screen reader (via the
nsMsgDBView::GetCellValue method) are now retrieved from about3Pane.ftl,
closer matching the aria labels provided by the JS tree. Also, fix the screen
reader output for spam messages in the 'Search messages' dialog (Bug 1643467).

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1928213 - Replace MOZ_RUNINIT static strings in nsMsgDBView by StaticAutoPtr. r=#thunderbird-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5dff147d8f20
Migrate properties used by nsMsgDBView to fluent. r=mkmelin,dandarnell

Comment 4

[Takanori MATSUURA]

Reopened for the unpublished patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5d16c8cc7216
Replace MOZ_RUNINIT static strings in nsMsgDBView by StaticAutoPtr. r=BenC