1946121 - The Primary Password prompt is displayed after reopening Firefox(profile without having Sync on)

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P2)

Description

[Raluca Popovici, Desktop QA]

Found in:
Fx 136.0b2

Affected versions:
Fx 136.0b2

Tested platforms:
Affected platforms: MacOS 14.7.3, Win 10

Preconditions:
Run this test without having Sync on

Steps to reproduce:

1. Open Firefox, access the about:preferences#privacy page, and click the Use a Primary Password checkbox.
2. Enter a Primary Password and click the Ok button.
3. Exit Firefox
4. Reopen Firefox with the same profile.

Expected result:
The Primary Password prompt is not displayed.

Actual result:
The Primary Password prompt is displayed.

Regression range:
We'll try to find a regression ASAP.

Comment 1

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I have performed the regression range using Mozregression and the following results were obtained (on Windows 11 and macOS 14):

• Last good build: 2025-01-15
• First bad build: 2025-01-16
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ba5a58b8f15f8571843b348f42cd1b0ab8bf5a2e&tochange=7c648655ddeeb0a6140fd193ad835aa87c1ee4fc
• Potentially regressed by: Mozregression pointed to bug 1915672

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1915672

Comment 3

[Donal Meehan [:dmeehan]]

The bot can't set a need-info for the assignee of the regressor since their account is disabled.
:mtigley, I see you reviewed and pushed the patch. Could you take a look?

Comment 4

[Micah [:mtigley] (she/her)]

Thanks for the report! Just a few questions to narrow down the cause here: does this issue still happen when the initial loaded tab isn't about:preferences when re-opening Firefox ? Do you still get the primary password prompt if the initial loaded tab is on another page (like https://www.mozilla.org/en-CA/ for example)?

Comment 5

[Donal Meehan [:dmeehan]]

:mtigley is backing out the regressor from beta an option for now? Give some extra time for the investigation

Comment 6

[Micah [:mtigley] (she/her)]

:dmeehan It looks like this change is the cause of the regression. We shouldn't back this out since we need to be able to track metrics for the OS Auth feature.

Let me check back with the team on next steps here, thanks!

Comment 7

[Donal Meehan [:dmeehan]]

(In reply to Micah [:mtigley] (she/her) from comment #6)

:dmeehan It looks like this change is the cause of the regression. We shouldn't back this out since we need to be able to track metrics for the OS Auth feature.

Let me check back with the team on next steps here, thanks!

:mtigley any updates on the investigation? This is the last week of beta for F136
Fx136 goes to RC next week, so there is little time to address this. Could it also be triaged for severity?

Comment 8

[Micah [:mtigley] (she/her)]

:dmeehan The team won't be able to fix this regression for 136. We know what the issue is and are assessing how to address it, but we will need a bit of planning. I'll check with the team to assigned a severity and prioritization.

Comment 12

[Donal Meehan [:dmeehan]]

(In reply to Micah [:mtigley] (she/her) from comment #8)

:dmeehan The team won't be able to fix this regression for 136. We know what the issue is and are assessing how to address it, but we will need a bit of planning. I'll check with the team to assigned a severity and prioritization.

:mtigley this is picking up some dupes and I've seen a few other mentions online. Any progress on a fix?

Comment 16

[Micah [:mtigley] (she/her)]

(In reply to Donal Meehan [:dmeehan] from comment #12)

:mtigley this is picking up some dupes and I've seen a few other mentions online. Any progress on a fix?

Hey Donal! Yes, we have a quick fix for this issue. Will put up a patch shortly.

Comment 17

[:Gijs (he/him)]

Discussed this with Micah, I have a patch.

Comment 18

[:Gijs (he/him)]

Attachment: Bug 1946121 - avoid needing primary password to collect OS auth telemetry, r?mtigley

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cba736ef55b6
avoid needing primary password to collect OS auth telemetry, r=mtigley,firefox-desktop-core-reviewers ,mossop

Comment 22

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cba736ef55b6

Comment 23

[:Gijs (he/him)]

Attachment: Bug 1946121 - avoid needing primary password to collect OS auth telemetry, r?mtigley

Original Revision: https://phabricator.services.mozilla.com/D240899

Comment 24

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: unexplained primary password prompts
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: set primary password, disable "Require device sign in" for either passwords or credit cards, restart firefox, check if there is a primary password prompt immediately on start
• Risk associated with taking this patch: low
• Explanation of risk level: this only affects telemetry and primary password users
• String changes made/needed: no
• Is Android affected?: no

Comment 25

[:Gijs (he/him)]

Attachment: Bug 1946121 - avoid needing primary password to collect OS auth telemetry, r?mtigley

Original Revision: https://phabricator.services.mozilla.com/D240899

Comment 26

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: unexplained primary password prompts
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: set primary password, disable "Require device sign in" for either passwords or credit cards, restart firefox, check if there is a primary password prompt immediately on start
• Risk associated with taking this patch: low
• Explanation of risk level: this only affects telemetry and primary password users
• String changes made/needed: no
• Is Android affected?: no

Comment 27

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/63319210b82a

Comment 28

[Raluca Popovici, Desktop QA]

Verified as fixed on Windows 11 and MacOS 14.7.4 using Firefox Beta treeherder build(137.0b6) and Nightly 138.0a1(14-03-2025). The Primary password prompt is not displayed on restart with "Require device sign in..." disabled.

Comment 29

[Raluca Popovici, Desktop QA]

Verified as fixed on Windows 11 and MacOS 14.7.4 using Firefox Beta treeherder build(137.0b6) and Nightly 137.oa1(14-03-2025). The Primary password prompt is not displayed on restart with "Require device sign in..." disabled.

Comment 30

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/128aae6cedfa

Comment 32

[Raluca Popovici, Desktop QA]

Verified as fixed on Windows 11 and MacOS 13.2.1 using Firefox Release 136.0.2. The Primary password prompt is not displayed on restart with "Require device sign in..." disabled.