2023703 - Nova changes for List All Tabs menu

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task)

Description

[Stephen Thompson [:sthompson]]

UX spec: https://www.figma.com/design/XT0eDYh4RtbMNWaYQi0efM/Chrome-Sidebar-UX-Specifications--Sprint-1-?node-id=10103-557275&m=dev

List All Tabs menu/Tab Overflow Menu/Tabs Menu

This bug should be broken down further, but there are generally just a lot of small changes:

• Remove synced tabs
• Rename “Search Tabs” to “Search All Tabs”
• Tab close button should only appear on hovered tabs
  • Ania recalls there being a belief that this effect would be challenging to implement with XUL components, but we don’t have details.
• Add new “View All Tabs” item to the bottom (Opens Firefox View “Open Tabs” when clicked)
• Move tab audio icon from before close button to after favicon
• Move “New container tab” to be the first item in the list of tabs (Only shows if container tabs enabled, rename to “New Container Tab”)
• Move “Close all duplicate tabs” to be the second item in the list of tabs (Only shows when duplicate tabs are in the window, rename to “Close Duplicate Tabs”)
• Move “Hidden tabs” to be the last item in the list of tabs (Only shows when there are hidden tabs). But if any of the hidden tabs are playing audio, move "Hidden tabs" to be the first item in the list of tabs, and list each hidden tab playing audio right after "Hidden tabs" and before the first visible tab in the window
• Note the changes in the UX spec about the area of the menu that's scrollable vs. fixed

Comment 1

[Sarah Clements [:sclements]]

Note some work to convert panels to use tokens in bug 2017979.

Comment 2

[Jeremy Swinarton]

I split out some of the bigger chunks of work into their own bugs:

• bug2037515 — tab close button only appears on hovered tabs
• bug2037516 — new "View All Tabs" item directing to Firefox View
• bug2037517 — improved overflow behaviour
• bug2037519 — remove "Recent Tab Groups"

What remains in this ticket is a collection of small changes that can all be addressed at once — string changes, reordering existing menu items, etc.

Comment 3

[Jeremy Swinarton]

Attachment: Bug 2023703: Nova changes for List All Tabs menu

Comment 4

[Jeremy Swinarton]

Attachment: Bug 2023703 - List all tabs menu minor changes for Nova r?sclements,sthompson

• Remove the synced tabs menu item
• Rename 'Search tabs' to 'Search All Tabs'
• Rename 'New container tab' to 'New Container Tab' and move it to be the
  first item above the visible tab list
• Rename 'Close all duplicate tabs' to 'Close Duplicate Tabs', move it to be
  the second item above the tab list, and hide it (instead of disabling it)
  when there are no duplicate tabs

Comment 5

[Jeremy Swinarton]

Logging for posterity: after some discussions with UX, it was decided that the idea of turning the tabs in the List All Tabs menu into a "tab-like" surface (where the close and mute buttons overlay the tab, and where the close button is hidden unless hovered over) is not feasible from an a11y/UX pov in this menu. This has implications for a few of the requirements in this bug.

I also decided to split out the work of reorganizing the hidden/muted tabs into it's own bug/patch to simplify review.

Things are getting a bit hairy here, so here's a full summary of the requirements of this bug as they stand today:

In this ticket

• Remove synced tabs
• Rename “Search Tabs” to “Search All Tabs”
• Move “New container tab” to be the first item in the list of tabs (Only shows if container tabs enabled, rename to “New Container Tab”)
• Move “Close all duplicate tabs” to be the second item in the list of tabs (Only shows when duplicate tabs are in the window, rename to “Close Duplicate Tabs”)

In separate bugs

• bug2037516 — new "View All Tabs" item directing to Firefox View
• bug2037517 — improved overflow behaviour
• bug2037519 — remove "Recent Tab Groups"
• bug2046489 — improve display of hidden tabs, especially when playing audio (new bug created today)

Work that will not be done

• Tab close button only appears on hovered tabs (bug2037515 is closed)
• Move tab audio icon from before close button to after favicon

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a65e1fa23247
https://hg.mozilla.org/integration/autoland/rev/3f94e5c09a8d
List all tabs menu minor changes for Nova r=sclements,fluent-reviewers,tabbrowser-reviewers,bolsson

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/aa3d65110c97
https://hg.mozilla.org/integration/autoland/rev/52bac1a075f5
Revert "Bug 2023703 - List all tabs menu minor changes for Nova r=sclements,fluent-reviewers,tabbrowser-reviewers,bolsson" for causing bc failures at _tab_manager_close.js

Comment 8

[Silaghi Andreea]

Backed out for causing bc failures at _tab_manager_close.js
Backout Link
Push with failures
Failure Log
bc
log
Failure line TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_tab_manager_close.js | test_tab_manager_close_button - Uncaught exception in test - TypeError: can't access property "pinned", (intermediate value).tabOf(...) is undefined

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ee2d97c91a40
https://hg.mozilla.org/integration/autoland/rev/a5807f7920da
List all tabs menu minor changes for Nova r=sclements,fluent-reviewers,tabbrowser-reviewers,bolsson

Comment 10

[amarc]

https://hg.mozilla.org/mozilla-central/rev/a5807f7920da