21160 - Mac: color preferences are not hooked up

Status: VERIFIED DUPLICATE of bug 35119

(SeaMonkey :: Preferences, defect, P1)

Description

[Kathleen :Brade]

The Color preferences are not hooked up in the following ways:
 * current values are not display
 * preferences are not reflected in navigator window after dismissing pref window
 * preferences are not written to file

The particular preferences this is for include:
 * text color
 * background color
 * unvisited link color
 * visited link color

Comment 1

[don]

Not required for beta 1 (I think?).

Comment 2

[Kathleen :Brade]

actually I think Seth and I fixed this earlier this week.  (Sorry I haven't had
a chance to do a query to find all of these bugs we fixed.)

Comment 3

[sairuh (rarely reading bugmail)]

okay, am gonna verify this since color prefs are hooked in. however, i found a
bunch of other problems related to color prefs which i'll file as separate
bugs...

Comment 4

[sairuh (rarely reading bugmail)]

ugh, brain still hibernating: i'm reopening this particular one since the color
prefs don't appear to be hooked up for Windows (tested with 2000010108 on NT).
updating summary, too, to reflect platform parity.

Comment 5

[sairuh (rarely reading bugmail)]

additional info: in windows i'm essentially unable to select a color from the
color picker. click a color square and nothing happens.

Comment 6

[sairuh (rarely reading bugmail)]

bumped up to blocker since this prevents any color prefs testing on windows.
dunno if it'd be considered dogfood, tho... paul?

Comment 7

[Paul MacQuiddy]

no, probably not dogfood. If you're ever not sure, just put [DOGFOOD] in the
Summary and the PDT team will determine.

Comment 8

[Tobias Burnus]

This seems to be also partly true for the Linux version (current snapshoot).
Some colours are selectable and are saved (such as Appear|Col|Text, Composer|*),
other colour buttons open, but clicking on a colour has no effect at all (such
as A|C|Background/(Un)visited Link; )

Comment 9

[Tobias Burnus]

Concerning my problem with the
Preference|Appearance|Colours|(Background|(Un)Visited Links), here is a patch,
which doesn't seem to have any side-effects. This does probably not solve the
Win problem, but a problem for all versions.

--- chrome/pref/content/default.old/pref-colors.xul     Sat Feb  5 18:39:36 2000
+++ chrome/pref/content/default/pref-colors.xul Sat Feb  5 19:37:06 2000
@@ -61,7 +61,6 @@
           <spring flex="100%"/>
                        <menu id="backgroundmenu" allowevents="true" class="colo
                                <html:div id="browserBackgroundColorDiv" style="
-            <spring flex="100%"/>
                                <titledbutton class="popup" align="right"/>
                                <menupopup id="backgroundMenuPopup">
                                        <colorpicker allowevents="true" id="back
@@ -87,7 +86,6 @@
           <spring flex="100%"/>
                        <menu id="unvisitedlinkmenu" allowevents="true" class="c
                                <html:div id="browserUnvisitedLinksColorDiv" sty
-            <spring flex="100%"/>
                                <titledbutton class="popup" align="right" flex="
                                <menupopup id="unvisitedLinksMenuPopup">
                                        <colorpicker allowevents="true" id="unvi
@@ -101,7 +99,6 @@
           <spring flex="100%"/>
                        <menu id="visitedlinkmenu" allowevents="true" class="col
                                <html:div id="browserVisitedLinksColorDiv" style
-            <spring flex="100%"/>
                                <titledbutton class="popup" align="right"/>

Comment 10

[leger]

Bulk move of all Pref UI component bugs to new Preferences component.  Pref UI 
component will be deleted.

Comment 11

[Kathleen :Brade]

*** Bug 29196 has been marked as a duplicate of this bug. ***

Comment 12

[sairuh (rarely reading bugmail)]

removed pp keyword, since similar problems are seen on MacOS.

Comment 13

[don]

Move this to M16 ...

Comment 14

[verah (gone)]

Reassigning for Don

Comment 15

[Claudius Gayle]

*** Bug 10975 has been marked as a duplicate of this bug. ***

Comment 16

[sairuh (rarely reading bugmail)]

methinks this is cross platform...

Comment 17

[leger]

PDT need to know what is working and not working here for all platforms please? 
 Thanks!

Comment 18

[sairuh (rarely reading bugmail)]

dunno if this is an editor issue... sujay/brade?

Comment 19

[sairuh (rarely reading bugmail)]

and, this is still XP.

Comment 20

[sairuh (rarely reading bugmail)]

*** Bug 22952 has been marked as a duplicate of this bug. ***

Comment 21

[leger]

Putting on [nsbeta2+][5/16] radar.  This is a feature MUST complete work by 
05/16 or we may pull this feature for PR2.

Comment 22

[Kathleen :Brade]

These are not editor issues; these are navigator issues.  Read my initial report; 
note the reference to "navigator window."

Comment 23

[Chris McAfee]

color picker is not reading or writing pref values out, WinNT, Linux.

Comment 24

[Chris McAfee]

ah, pref is getting written out, but colorpicker isn't
picking it up and comes up white each time.

Comment 25

[Chris McAfee]

fixed.  filing another bug to use the editor colorpicker, this
one kinda sucks, sorry.

Comment 26

[sairuh (rarely reading bugmail)]

reopening because of several reasons. if any of these should go into/already
covered by separate bugs, let me know. tested using opt comm bits 2000.05.22.08
on linux, mac and winnt.

1. linux: only background_color and foreground_color are actually displayed (and
for the most part only in the chrome, but that's covered by bug 22953).
visited_color and anchor_color, while also written to prefs.js, is not displayed
at all (even after restarting the browser *and* use_document_colors set to
false).

2. winnt: even though anchor_color, visited_color, background_color and
foreground_color are written to prefs.js, they're never displayed even after
restarting the browser *and* use_document_colors set to false.

3. mac: unable to change any of the 4 color prefs in the Colors panel.

Comment 27

[Chris McAfee]

1) Linux, pref panel is reading/writing/displaying colors fine for me.
If layout ignores the colors, that's another bug.

Comment 28

[sairuh (rarely reading bugmail)]

thx, chris --i'll write up another bug in Layout to cover (1) and (2) above.
i'll keep this one open since the prefs aren't being written at all for Mac.

Comment 29

[sairuh (rarely reading bugmail)]

i've filed bug 40340 to cover color preferences not being displayed.

Comment 30

[sairuh (rarely reading bugmail)]

after chatting w/chris, i checked out the color picker on the Mac, which does
work (w/o bug 35100 interfering, too :-). so perhaps the final fix here is to
use the editor's color picker...

Comment 31

[don]

Hmmmm, so what's the bug here now and on which platforms?  Does this bug still
need to be open?

Comment 32

[don]

Move to M19.

Comment 33

[Chris McAfee]

This is now a mac bug.  Probably a modal/focus problem.
Over to pav for a look.

Comment 34

[Stuart Parmenter]

since the current state of this bug is "color pickers don't work on mac" i'm
marking this as a dup of pink's bug 35119

*** This bug has been marked as a duplicate of 35119 ***

Comment 35

[sairuh (rarely reading bugmail)]

vrfy.