224002 - double clicking tab close button creates new tab

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P2)

Description

[Asa Dotzler [:asa]]

Tested with 0.7.1 on OS X 10.2. 

Rapidly clicking the 'x' close button to close a number of tabs, serves as a
double-click on the tab-bar as well, and thus opens a new tab for every 2 clicks.

Reproducible: Always

Steps to Reproduce:
1. Open 3 (or more) tabs
2. Rapidly click the close button twice, to close 2 out of 3 tabs

Actual Results:  
After the 2 rapid clicks, the 2 tabs are closed, but an extra tab appears.

Expected Results:  
Just closed 2 tabs, not create a new extra tab. There should only be 1 tab in
the end (that is, when you try this with 3 tabs).

An issue similar to (or the same as) this has been reported and resolved fixed
as bug 216470. This may be a Mac Firebird 0.7.1 regression so I've filed this
new Mac-specific bug.

Comment 1

[James Anthony]

WFM 0.7.1 on OS X 10.3, no extensions installed, default theme. 

Comment 2

[Marco]

Confirming this bug on recent OS X nightlies (Gecko/20031207 through 20031209)

Comment 3

[Michael Kurze [:michaelk]]

Also confirming, using 2004-01-19 (OSX 10.3.2)

Comment 4

[Hiro]

It is still reproducing also by firefox which biulded from FIREBIRD_0_8_BRANCH.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; ja-JP; rv:1.6) Gecko/20040210
Firefox/0.8

Comment 5

[riscky]

WFM 
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040427
Firefox/0.8.0+

10.3.3

Comment 6

[Ian Wehrman]

confirm, firefox-0.9, mac os x 10.3.4.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040614
Firefox/0.9

Comment 7

[Ryan VanderMeulen [:RyanVM]]

I'm confirming this bug as well.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040714
Firefox/0.9.1+ (MOOX-AV)

Comment 8

[Michaël Arnauts]

have it also:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040809 Firefox/0.9.1+

Comment 9

[Anthony Lieuallen]

I notice this behavior in 0.9.3 in linux (at home don't have details), but not
in 0.9.3 in windows (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7)
Gecko/20040803 Firefox/0.9.3).

Comment 10

[Mike Kowalski]

I see this on XP using 0.9.3. If you click right above the tab, but below the
personal toolbar, it does open a new tab.

Comment 11

[Fareed Rizkalla]

i'm confirming like mike, but it's not that bad actually making it easier than
pressing ctrl+t

Comment 12

[Nick Marsh]

This is still a problem for FF 0.9.3 on Mac OS X 10.3.5. VERY annoying. Not an
issue on my Windows or Linux systems though. Any progress on this?

Comment 13

[Phillip Stewart :P]

WFM
Mozilla/5.0 (Windows; U; Windows NT 5.2; rv:1.7.3) Gecko/20040911 Firefox/0.10
(MOOX M3)

I open two blank tabs, and double click quickly on the close button on the tab
bar and no new tab opens.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

(In reply to comment #13)
> WFM
> Mozilla/5.0 (Windows; U; Windows NT 5.2; rv:1.7.3) Gecko/20040911 Firefox/0.10
> (MOOX M3)
> 
> I open two blank tabs, and double click quickly on the close button on the tab
> bar and no new tab opens.

Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040911 Firefox/0.10
(MOOX M2)

Still happening here. I opened up three tabs all with My Yahoo loaded. I closed
two and ended up with the leftmost My Yahoo tab open and a blank untitled tab
next to it.

Comment 15

[Ian Wehrman]

confirm: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3)
Gecko/20040911 Firefox/0.10.

this happens when double-clicking anywhere to the right of the last tab (in the
trough), including the tab close button. and it sucks.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

(In reply to comment #15)
> confirm: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3)
> Gecko/20040911 Firefox/0.10.
> 
> this happens when double-clicking anywhere to the right of the last tab (in the
> trough), including the tab close button. and it sucks.

It should probably be pointed out that double clicking on the tab bar to open a
new tab is behavior by design. The problem is that it also does it when clicking
on the tab close button instead of treating that as a separate entity.

Comment 17

[Asa Dotzler [:asa]]

This is a well understood problem that now only exists on Macintosh and we
intend to fix for Mac Firefox 1.0. Additional confirmation isn't necessary
unless it comes with a patch ;-)  

Comment 18

[Ryan VanderMeulen [:RyanVM]]

(In reply to comment #17)
> This is a well understood problem that now only exists on Macintosh and we
> intend to fix for Mac Firefox 1.0. Additional confirmation isn't necessary
> unless it comes with a patch ;-)  

Asa, I'm reproducing on three different Windows XP machines.

Comment 19

[Asa Dotzler [:asa]]

Ryan, what build are you using and have you installed any extensions or themes?
I cannot reproduce on current Aviary branch windows builds on XP using a stock
nightly profile, an 0.8 migrated profile, or a 0.9.3 created profile. 

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040912 Firefox/0.10
(MOOX M3) on two
Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20040912 Firefox/0.10
(MOOX M2)

Adblock .5 b39 and TBP 0.6.8 are my own two extensions.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Also, I should note that the one using moox' M2 build is a new profile I created
yesterday on the 9/11 nightly.

Comment 22

[Asa Dotzler [:asa]]

Can you reproduce this problem using an official build? If this is a problem
specific to some customized build, that's worth investigating, but probably not
in this bug.

Comment 23

[Mike Kowalski]

I'm not using any extensions (winstripe theme) and I still see this bug on 2
different XP machines. Try double clicking the small space above the tab, but
below the toolbar.

Comment 24

[Ryan VanderMeulen [:RyanVM]]

(In reply to comment #22)
> Can you reproduce this problem using an official build? If this is a problem
> specific to some customized build, that's worth investigating, but probably not
> in this bug.

I've actually narrowed it down to TBP. With it disabled, no new windows open up.

Comment 25

[Michaël Arnauts]

ok, setting os to mac is totally wrong

Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040910 Firefox/0.10

a double click on the close-button closes two tabs and opens a new one...

Comment 26

[Michaël Arnauts]

sorry, after i disabled tbp, the problem is gone... ignore me please :)

Comment 27

[Asa Dotzler [:asa]]

Kowalski, this bug has nothing to do with clicking in the tab strip. A double
click on any empty space in the tab strip is _supposed_ to create a new tab.
It's about double clicking specifically on the [X] tab close button causing a
new tab to open. 

Comment 28

[Asa Dotzler [:asa]]

Actually, upon further testing of the latest branch builds on Mac OS 10.3 I can
no longer reproduce this on Mac either. Marcia or Tracy, do you see guys this on
Mac? We may be able to just resolve this one as WFM.

Comment 29

[Bradley Chapman (not reading bugmail, still gone but not forever)]

This ought to be RESOLVED INVALID; mea culpa.

If I can figure out the cause, TBP 0.6.10 will not cause this to happen (at 
least on Win32 and Linux).

Comment 30

[Asa Dotzler [:asa]]

Actually, when I first filed this, it was a real bug. I believe that bug has
since been fixed. Resolving WFM.

Comment 31

[Tracy Walker [:tracy]]

verified. not seeing this on any platform with PR release candidates

Comment 32

[Ben Willmore]

(In reply to comment #31)
> verified. not seeing this on any platform with PR release candidates

I see it on Mac OS X 10.3.5;   Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O;
rv:1.7.3) Gecko/20040913 Firefox/0.10

Should this bug be reopened?

Comment 33

[Tracy Walker [:tracy]]

Ben, do you have the Tab Browser Preferences extension installed?

Comment 34

[Ben Willmore]

(In reply to comment #33)
> Ben, do you have the Tab Browser Preferences extension installed?

Tracy: nope.  That was a fresh profile, no extensions, no nothin'.

[I had installed tabbrowser extensions in the past, but it wasn't being used by
that profile.  Could that possibly be relevant?  I'd assumed that installing
extensions only affected your profile dir, but perhaps there's stuff left in the
Firefox.app dir too... I'll try a fresh install tonight.]

Comment 35

[Ben Willmore]

(In reply to comment #33)
> Ben, do you have the Tab Browser Preferences extension installed?

No, I don't have Tabbrowser Exts installed.

I see the bug with a fresh install, fresh profile, no extensions.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; rv:1.7.3) Gecko/20040913
Firefox/0.10 on Mac OS X 10.3.5.

Comment 36

[Marco]

Ditto, I still see this bug on  Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O;
rv:1.7.3) Gecko/20040913 Firefox/0.10

Tab Browser Extension not installed.                                   

Comment 37

[Tracy Walker [:tracy]]

ah ha!  After several attempts at this I was finally able to reproduce it, and
reproduce it consitantly with the Mac branch build from 0917 (clean install and
no extensions).  I believe that before I wasn't clicking quickly enough.  It
takes a quick double click on the tab close [X].  Two tabs with content closed
and then a new blank tab opened.

Reopening and requesting blockiing-aviary 1.0mac for this user facing bug.

Ben, thank you for your persistance on this.  :-)

Comment 38

[Michaël Arnauts]

message for non-macosx users:

i just downloaded a new version of Tabbrowser Preferences v0.6.14, and now it's
fixed!

http://www.pryan.org/mozilla/site/TheOneKEA/tabprefs/#link

Comment 39

[Asa Dotzler [:asa]]

moving blocking1.0mac bugs to Firefox1.1 Target Milestone.

Comment 40

[Asaf Romano (gone)]

WFM on the trunk.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a6) Gecko/20041229
Firefox/1.0+

Comment 41

[Wayne Woods]

It's actually still broken on the trunk, Asaf. However I can only reproduce it
if the tabs actually contain open pages. If they're blank tabs, it seems that I
can double-click on the close button as fast as I can, and it still won't create
new tabs.

Open slashdot.org in, say, 10 tabs, and then start closing them rapidly. Every
now and then you should see a blank page pop up. Maybe the extra overhead of
closing a tab that contains data, slows things down to a point where clicking
speed is more significant?

Confirmed with 20050506 trunk nightly, no extensions.

Comment 42

[Jeremy M. Dolan]

Definitely still an ugly problem on Mac trunk. Nominating for 1.1 since it had
1.0+. Asa, is there anyone who could take a look at this? Ben?

Comment 43

[Jeremy M. Dolan]

It occurs to me just now that it may not be obvious why this is particularly
problematic. An example:
 1) Have 5 tabs open.
 2) You decide you want to close tabs 2-4 (using a mouse).
 3) Click tab #2 to activate it.
 4) Start clicking the "X" to close the tabs.
 5) On your second click, you close a tab (originally #3), but you open a new
tab, appended to the END of the rest of them, and it is immediately selected.
Worse, with all those perf improvements on tab selection, the jump to this new
tab is immediate and it's very difficult at first to figure out what just
happened! Since the number of tabs in the tab bar remains the same (one closed,
one simultaneously opened), it looks as if you somehow just selected and blanked
out tab #5 (original numbering), which is the one you wanted to keep! And the
back button is greyed out! Very unfun experience.

Not to keep ranting on, but considering that, I think this bug is a pretty bad
experience for users. And if you think the above situation is pretty uncommon,
consider web searches. Google for "foo" in the first tab, and open up a bunch of
results in new tabs. Browse through them, start closing the ones you don't
need., and watch your tabs jump around.

Comment 44

[Asaf Romano (gone)]

*** Bug 296192 has been marked as a duplicate of this bug. ***

Comment 45

[José Jeria]

*** Bug 297824 has been marked as a duplicate of this bug. ***

Comment 46

[Mike Connor [:mconnor]]

stopgap is to check the event target in tabbrowser, but the tabbox check should
fix this.

Comment 47

[Asaf Romano (gone)]

Attachment: workaround

Comment 48

[Martijn Wargers (dead)]

*** Bug 299678 has been marked as a duplicate of this bug. ***

Comment 49

[Mike Connor [:mconnor]]

Comment on attachment 188107 [details] [diff] [review]
workaround

sure, it'd be nice to figure out why, but we should fix this for now (it just
got yet another dupe)

Comment 50

[Asaf Romano (gone)]

Checking in tabbrowser.xml;
/cvsroot/mozilla/toolkit/content/widgets/tabbrowser.xml,v  <--  tabbrowser.xml
new revision: 1.90; previous revision: 1.89
done

Comment 51

[Tracy Walker [:tracy]]

Verified with Win DP 2005-07-28-08-trunk

Comment 52

[Jaime Mitchell (use [e-mail] for email)]

*** Bug 302999 has been marked as a duplicate of this bug. ***