225088 - Go button shows text in icons-only mode

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Ben]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6a) Gecko/20031107 Firebird/0.7+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6a) Gecko/20031107 Firebird/0.7+

The toolbar can be customized such that the buttons (back, forward, etc) only
show the icons without the text. This works for all buttons, except the Go
button that keeps showing "Go" to the right of the button.

Reproducible: Always

Steps to Reproduce:
1. Customize the Navigation toolbar to show only icons.
2. Make sure the Go button is shown.
Actual Results:  
The text "Go" is shown to the right of the button.

Expected Results:  
Only the button should be shown, thus without the "Go" text.

Comment 1

[Jason Barnabe (np)]

Confirming, but this might be a theme issue.

Comment 2

[Mike Connor [:mconnor]]

not really a bug, since its intended behaviour

duping against bug 187096 since changing this requires changing the behaviour of
the Go button, but don't hold your breath...  individual skin designers can and
will find ways to work around this.

*** This bug has been marked as a duplicate of 187096 ***

Comment 3

[Simon Paquet [:sipaq]]

verified.

Comment 4

[Ben]

First I thought you (Mike Conner) were right, but today I browsed my bugs again
and have to disagree.

This is not a dupe of bug 187096, because 187096 is about the XUL code (that
affects the theming), while this bug is about the Firebird default theme.

This is a bug against the default theme. Although it might be intended, it
appears a bug. If it looks like a bug, smells like a bug and behaves like it
bug, it is a bug.  :-)

Comment 5

[Simon Paquet [:sipaq]]

Ben, the two issues may appear different, but they are the same. So of course
this is a bug, but a bug, which is already reported (a duplicate).

*** This bug has been marked as a duplicate of 187096 ***

Comment 6

[Simon Paquet [:sipaq]]

re-verifying.

Comment 7

[alanjstr]

I disagree with Simon and Mike here.  The other bug is about the XUL being
needlessly complex.  It does not prevent the theme from being corrected, just
makes it more difficult.

Comment 8

[Simon Paquet [:sipaq]]

Alan, you're right. After some thinking I agree that this is not a duplicate.
I'm making this bug depend on bug 187096 instead.

Comment 9

[miahz]

Attachment: patch fixing go button in icon/text modes

simple two-line theme css fix in classic/skin/classic/browser/browser.css that
makes the go button obey icons and text modes like the other buttons.

whether or not this is the intended behavior - i don't know.  but it's what
this bug is requesting.

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

patch, +ing

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Actually this is IE compatibility - they show "Go" even when in icon only mode.
"Go" is equally a convenience for novices so removing the label doesn't help. 

Comment 12

[Russ]

(In reply to comment #11)
> Actually this is IE compatibility - they show "Go" even when in icon only mode.
> "Go" is equally a convenience for novices so removing the label doesn't help. 

IE implements the Go Button with text on the Address Bar toolbar, which does not
support customization (no Customize context menu).  Therefore the Show Icons
Only setting of the Standard Buttons toolbar does not apply.  However, in
Firefox, the Navigation Toolbar contains both the buttons and the address bar,
and the entire toolbar supports customization.  It is therefore inconsistent to
have this setting only apply to some of the buttons since it is one toolbar, and
not two as it is in IE.  I agree it should be the default, but the Show icons
only setting should allow you to customize this.

Comment 13

[miahz]

See Bug 257561 for more Go Button/Address Bar related discussion, and
Bug 235277 to make the Go Button appear like the others.

Comment 14

[Frank Wein [:mcsmurf]]

*** Bug 268688 has been marked as a duplicate of this bug. ***

Comment 15

[:Gavin Sharp [email: [e-mail]]]

*** Bug 294267 has been marked as a duplicate of this bug. ***

Comment 16

[:Gavin Sharp [email: [e-mail]]]

*** Bug 304256 has been marked as a duplicate of this bug. ***

Comment 17

[Raphael Segun Awoseyin]

I was able to replicate this bug using Firefox on a Win XP Pro (Service Pack 2) system. Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060120 Firefox/1.5.0.1

Steps to Replicate:
1.	Go to View -> Toolbars -> Customize
2.	Under Show, select ‘Icons’ from the drop-down menu
3.	Select Done

Try to replicate this with other themes. This may only be an issue with the default theme. If skin designers do not experience this issue with their designs then it is likely to be just an issue with the default.

This may seem like a trivial bug or one may even argue on whether or not it is one. However, I believe it is because Firefox is meant to promote customization and creativity. However, this bug can somewhat hinder that or cause unnecessary difficulties for skin designers. On the other side, some users may be lost without the word ‘Go’ as it is one of the less intuitive icons. Overall I think fixing this bug may provide a ‘cleaner look’ for the navigation bar. 

Comment 18

[Phil Ringnalda (:philor)]

Turn, turn, turn - I'll bet that now there's a bug on the way the Go button *doesn't* have text in icons+text mode.