Closed
Bug 232467
Opened 21 years ago
Closed 20 years ago
default folder for add bookmark not remembered across sessions when it's the "Bookmarks" folder
Categories
(Firefox :: Bookmarks & History, defect, P2)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox1.0beta
People
(Reporter: netdragon, Assigned: vlad)
References
Details
(Keywords: fixed-aviary1.0)
Attachments
(2 files, 1 obsolete file)
1.83 KB,
patch
|
Details | Diff | Splinter Review | |
4.42 KB,
patch
|
shaver
:
review+
|
Details | Diff | Splinter Review |
Firebird 0.8.0+ 200401015 Windows XP When you first open the browser and go to bookmark a page, it chooses "Bookmarks Toolbar Folder" and not "Bookmarks". "Bookmarks" should be the default location for saving of bookmarks.
Comment 1•21 years ago
|
||
The dialog shows the last folder a bookmark was added to as the default. On a truly clean profile, I'd agree that the first time should default to bookmarks
Reporter | ||
Comment 2•21 years ago
|
||
Not only that, but it forgets which Bookmark folder you use when you close the browser.
Comment 3•21 years ago
|
||
(In reply to comment #2) > Not only that, but it forgets which Bookmark folder you use when you close the > browser. Most likely, you moved or removed a bookmark in the bookmarks toolbar folder. Then, this folder is considered to the most recently visited folder. That's not really by design.
Reporter | ||
Comment 4•21 years ago
|
||
It should probably only remember for the duration of the session -- no preference. When you restart the browser each time, it should go back to Bookmarks. It doesn't seem likely to me that people will be forever putting the bookmarks in the same folder. During one session, they might.
Comment 5•21 years ago
|
||
*** This bug has been marked as a duplicate of 75452 ***
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → DUPLICATE
Comment 6•21 years ago
|
||
this is separate, bookmarks has long since been forked
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment 7•21 years ago
|
||
*** Bug 233994 has been marked as a duplicate of this bug. ***
Comment 8•20 years ago
|
||
*** Bug 236330 has been marked as a duplicate of this bug. ***
Comment 9•20 years ago
|
||
Firefox will always use the last folder that a bookmark was saved in as the default, unless Firefox has been restarted and the last folder was the main Bookmarks folder, in which case, it will default to the folder last saved in before that. We should probably implement something like the following: + Within browing session - It defaults to the last folder that a bookmark was saved in. + Per restart of Firefox - Always default to main Bookmarks folder at start of session. I think this is a pretty sensible behaviour. Also updating summary.
OS: Windows XP → All
Hardware: PC → All
Summary: Bookmarks Toolbar Folder should not be default folder for placing bookmarks → Make Firefox use a sensible default folder for adding bookmarks
I discussed this with Ben -- the reason the root folder isn't remembered is that the folder to use is based on the LAST_MODIFIED date of the folder, and the "root" folder doesn't have its LAST_MODIFIED written to bookmarks.html, since there's no place to put it. 1.0beta per discussion with Ben.
Summary: Make Firefox use a sensible default folder for adding bookmarks → default folder for add bookmark not remembered across sessions when it's the "Bookmarks" folder
Target Milestone: --- → Firefox1.0beta
It's worth noting that my resummarization of the bug doesn't accurately reflect the second of the two issues here: 1. that the default folder is the "Bookmarks" folder across sessions 2. that, in a new profile, the default should be "Bookmarks" Fixing the second requires fixing the first, unless the entire folder-memory feature is dropped.
(1.) above lacks "is forgotten"
Comment 13•20 years ago
|
||
On comment 9, this does not seem to me to be sensible behaviour in practice, although your description is fine. I very, very rarely if ever want to use Cmd-D to save a bookmark to the Bookmarks Toolbar folder. I would usually edit this folder by dragging onto it or off it. Yet Firefox seems to choose this folder more often than any other. IMHO this is wrong, and it is 'in your face' because Firefox is changing something that is really my prerogative. I was happy with system whereby the root folder was marked as receiving 'Added' bookmarks, and an option (which I can't see myself using) to mark some other folder as the receiving folder. Having said that, it would be reasonable for Firefox to use a folder in the root folder with today's date on it, so one would have, um, a backlog of bookmarks to look through and dispose of in a series of folders by date. (My biggest problem with bookmarks is having them all in a heap whether in the root folder or any individual folder; using a folder by day, approaches classifying by session and gets somewhat close to classfying by content, topic or subject, which is what I realy want ...) If you really want the Bookmark Menu to have this 'Last Visited' behaviour (which I do not), please use the line just below 'Quick Searches' in a Mason-Dixon spirit, saying that folders North of that line will never be used for receiving Added Bookmarks, if one of those (and 'Quick Searches' would be a good example) ever is the most recently visited folder then the root folder should be used instead. Personally, I would really only want Added Bookmarks to go to the tail of Bookmarks menu, and I am surprised that nobody else has had the experience of chasing down where that Firefox has put my bookmarks this time. It looks as though I am in a minority of one, though the OP did ask for 'Bookmarks' to be the default location.
Comment 14•20 years ago
|
||
I typically add new bookmarks to the "Bookmarks" folder. After restarting $BROWSERNAME, and adding a new bookmark via Bookmarks->Add to Bookmarks... it always defaults to "Quick Searches", despite having not recently added a bookmark to the "Quick Searches" folder. This is quite annoying and is never what I want. I think it's the same bug.
Updated•20 years ago
|
Flags: blocking1.0+
Priority: -- → P2
Comment 15•20 years ago
|
||
I agree with most other people that like the default location to be the Bookmarks folder. It is rare that I save two bookmarks in a row to the same folder - thus the 'remember last folder' feature is rendered almost useless. I liked the idea in comment 9 and comment 13 had some good UI ideas. But what I want most is to at least have the option of *simply* (ie. without lots clicking and scrolling) saving all of my bookmarks to the main Bookmarks folder. Then I can deal with the mess that gathers there when I get spare time :)
Comment 16•20 years ago
|
||
I'm unsure, but this may be a dupe of Bug 232089. In my mind, the ideal solution to this (VERY annoying problem) is to revert to the Mozilla behavior... Have two menu options, "Add bookmark" will add the current page to the end of the bookmark list without any dialog at all. "File bookmark" would bring up the dialog, with the tree view (optionally) automatically shown (Bug 242626). This keeps the simplicity and consistency with older browsers, and has the the advantages of the dialog to file bookmarks in folders, bookmark groups of tabs, etc.
Comment 17•20 years ago
|
||
I very much agree with #16 here. Most of the time i want to add a bookmark i want to add it to the root Bookmarks folder. Maybe the add bookmark function could add the bookmark to whatever folder the user has selected to be the "default" and the file bookmark folder would ask the user where to file it, using the last modified folder as the default. To take it one step further i think the "File Bookmark" dialog should have the ability to add a keyword to the bookmark. Bookmark keywords are a great feature and i think they'd be used more frequently by end users if the file bookmark dialog has the option to add one. I find it unintuitive to have to edit a filed bookmark in order to add a keyword.
Comment 18•20 years ago
|
||
we're certainly not going to revert to Mozilla's behaviour here. We moved away from that a long time ago. There might be a case for adding a key combo to bookmark without prompting (i.e. Ctrl-Shift-D, which is an inversion of the Mozilla behaviour) What is most likely is that we'll have to find a fix for this :) everything else is unlikely to change, certainly not before 1.0.
This workaround works for me -- what it does is it sets the last modified date for the bookmarks folder to be the time that the bookmarks file is read. This means that at the start of each session, the most recently modified folder will be the "Bookmarks" folder, so it will thus show up first. This will then change if the user bookmarks into another folder. I'm not sure how well this would work if the user uses a dynamic view of system bookmarks (i.e., useDynamicSystemBookmarks is true).
Updated•20 years ago
|
Assignee: p_ch → vladimir
Status: REOPENED → NEW
Assignee | ||
Comment 20•20 years ago
|
||
k, so H1 now has a LAST_MODIFIED. Note that I don't feel bad -at all- for doing this to BookmarkParser/writer. (I also wish I'd known about this bug sooner, because you have no idea how much this drove me crazy.)
Comment 21•20 years ago
|
||
vlad, I'm adding this to the list of reviews of patches I still owe you.
Flags: blocking-aviary1.0RC1+
Comment 22•20 years ago
|
||
*** Bug 251514 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 23•20 years ago
|
||
Same as -0, but with patch to new profile bookmarks.html, making sure that the "Bookmarks" folder is the default target for new profiles.
Attachment #152167 -
Attachment is obsolete: true
Assignee | ||
Comment 24•20 years ago
|
||
*** Bug 251718 has been marked as a duplicate of this bug. ***
Comment on attachment 153383 [details] [diff] [review] bookmarks-root-last-modified-1.patch I wouldn't miss this bookmarks format at _all_, I tell ya.
Attachment #153383 -
Flags: review+
Assignee | ||
Comment 26•20 years ago
|
||
In on aviary (with small fix to not over-release kNC_BookmarksRoot, oops).
Status: NEW → RESOLVED
Closed: 21 years ago → 20 years ago
Resolution: --- → FIXED
Comment 27•20 years ago
|
||
setting fixed-aviary1.0 for bugfixes checked into branch, sorry for bugspam.
Keywords: fixed-aviary1.0
Comment 28•18 years ago
|
||
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•