Closed Bug 233712 Opened 19 years ago Closed 18 years ago

No drag-and-drop for dock icon (Other than html)

Categories

(Firefox :: General, defect, P1)

PowerPC
macOS
defect

Tracking

()

RESOLVED FIXED
Firefox1.5

People

(Reporter: resuna, Assigned: asaf)

References

Details

Attachments

(1 file, 2 obsolete files)

User-Agent:       
Build Identifier: 

Dropping an object on the dock icon should open a Firefox window with that object (link, file, etc). 
I attempted to drag a link from a Terminal window to the Dock icon, and nothing happened. 
Dragging the link to an open Firefox window opens the link as expected.

Reproducible: Always
Steps to Reproduce:
1.Select a URL in any other program.
2.drag to Firefox Dock icon.
3.drag to open Firefox window.
Actual Results:  
2.link "snapped back" to terminal window
3.link opened in existing window.

Expected Results:  
2.link opened in new window.
3.link opened in existing window.
While dropping files _does_ work for me, dropping urls onto the dock icon does
work for no osx program i know, though it sounds be nice. Perhaps its not even
possible. 

WFM (files) / Wontfix (urls), I think.
wfm per Michael Kurze's testing
Status: UNCONFIRMED → RESOLVED
Closed: 19 years ago
Resolution: --- → WORKSFORME
I think the URL's describe are desktop link/url's ".webloc"

Some files do open like .txt but not .jpg or .gif
Status: RESOLVED → UNCONFIRMED
Resolution: WORKSFORME → ---
Status: UNCONFIRMED → NEW
Ever confirmed: true
Severity: minor → normal
*** Bug 269241 has been marked as a duplicate of this bug. ***
Per reporter of bug 269241 : drag-and-drop works for HTML, fails for jpg, gif,
and xpi, but dragging images to Camino's dock icon works.
Assignee: firefox → bugs.mano
Target Milestone: --- → Firefox1.1
Shockwave Flash doesn't work for the dock icon, but does for the window.
Blocks: 266008
Blocks: macmeta
Status: NEW → ASSIGNED
Priority: -- → P1
Summary: No drag-and-drop for dock icon. → No drag-and-drop for dock icon (Other than html)
Attached patch patch (obsolete) — Splinter Review
This one should also fix bug 266008.
Attachment #167906 - Flags: review?(mconnor)
Kevin, in this patch i used document.icns for images / text; Since the icon is
generic, it's not an issue. Still, it would be nice to have differents icons for
text files and image files, feel free to attach them ;)
I'd rather have someone more Mac-familiar look at this.  Maybe Javier can look?
(In reply to comment #9)
> I'd rather have someone more Mac-familiar look at this.  Maybe Javier can 
look?

Javier is away, trying pinkerton.
Comment on attachment 167906 [details] [diff] [review]
patch

Mike, can you have a look (please note comment 8)?
Attachment #167906 - Flags: review?(mconnor) → review?(pinkerton)
Mano, can we please support txt, css, xul, js, rdf, and webloc (and xpi and swf
maybe?)

at least everything in
http://lxr.mozilla.org/mozilla/source/xpfe/bootstrap/macbuild/Contents/Info.plist
(minus mng/jng)
(In reply to comment #12)
> Mano, can we please support txt, css, xul, js, rdf, and webloc (and xpi and 
swf
> maybe?)
> at least everything in
> 
http://lxr.mozilla.org/mozilla/source/xpfe/bootstrap/macbuild/Contents/Info.plis
t
> (minus mng/jng)

Well, i did add txt, but not xul/css/js, i will add those (i don't think we 
want swf). Do we support weblocs?
Comment on attachment 167906 [details] [diff] [review]
patch

removing review request. I will add a new patch later today.
Attachment #167906 - Flags: review?(pinkerton)
Why wouldn't you want swf? You can drag swf into an open window, why wouldn't
you want to drag it into the dock.
(In reply to comment #15)
> Why wouldn't you want swf? You can drag swf into an open window, why wouldn't
> you want to drag it into the dock.

flash is a plugin, any other mentioned file type isn't.
Attached patch v2 (obsolete) — Splinter Review
Note to everyone: Commanand+Option+Drag works for ANY
I'm not including

webloc - Firefox doesn't know to handle this file type (bug #?)
swf    - plugin, needs more tought, later.
xpi    - need to decide what kind of file it is; and sync suite & tb (please
file separate "core" bug against me)
Attachment #167906 - Attachment is obsolete: true
Attached patch v2Splinter Review
Note to everyone: Commanand+Option+Drag works for ANY file type.

I'm not including (on this bug):
* webloc - Firefox doesn't know to handle this file type (bug #?)
* swf    - plugin, needs more tought, later.
* xpi    - need to decide what kind of file it is; and sync ff, tb & suite
(please file separate "core" bug against me)
Attachment #167959 - Attachment is obsolete: true
Attachment #167960 - Flags: review?(pinkerton)
Comment on attachment 167960 [details] [diff] [review]
v2

we should try to keep these in sync with the camino ones. there's an open bug
to add a few new types to camino. check there for others.

r=pink.
Attachment #167960 - Flags: review?(pinkerton) → review+
Whiteboard: ready to land
landed by smontagu.

Please file separate bugs for other file types (after disscution, we really
shoudn't enable any file type you may succeed to open) and cc me.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago18 years ago
Resolution: --- → FIXED
Whiteboard: ready to land
Blocks: 274195
No longer blocks: 266008
*** Bug 266008 has been marked as a duplicate of this bug. ***
Attachment #167960 - Flags: approval-aviary1.0.1?
Attachment #167960 - Flags: approval-aviary1.0.1?
Blocks: deermac
*** Bug 316405 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.