25425 - changing document.bgcolor creates borders

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[p@spl@]

This page consists as an image nested inside two tables.  Upon load, a Jscript
function ('CheckState()') checks for a cookie storing the current state and sets
on if there is no cookie.  The JScript function 'stateSwap()' toggles between
two states and stores the current state in a cookie.  Two properties are changed
between states:  the image src switches between an on/off image, and the
document.bgColor switches between white and grey.

2 bugs:

Changing states creates a border around the tables and image.  This border does
not appear when the code initializes with checkState().

After a state change, the bgcolor only fills the outermost table -- not the
entire document space.

Comment 1

[p@spl@]

To be more clear about bug #2, extra space in the browser window not filled by
content doesn't not change when you change states.  Also, when you switch to an
overlapping window and switch back, the overlapped area is the correct color
when focus returns to the browser (though any part still visible on the screen
stays the wrong color.)  Bug #2 warrants another report?

Comment 2

[vidur (gone)]

There are two separate bugs described here. In the future, I'd recommend that 
separate bugs be split into separate bug reports:

Problem 1 - I believe this is a style system issue. Presumably the table layout 
and painting code consults the table's style context about the existence of a 
border. The fact that a style change at the viewport level (the 
document.bgcolor) results in a style change at the table level sounds like a bug 
in the style system. Cc:ing Kevin McClusky because I heard he's seeing a similar 
problem somewhere else.

Problem 2 - A DUP of bug 1886, which, judging from its number, has been around 
for quite a while. The bug author doesn't need to file a separate bug for this, 
but should probably mention this test case in the comments for bug 1886.

Comment 3

[Kevin McCluskey (gone)]

This looks like it is probably a dup of bug 13693 which also results in borders 
being drawn around table cells. 

Comment 4

[Kevin McCluskey (gone)]

*** Bug 13693 has been marked as a duplicate of this bug. ***

Comment 5

[Marc Attinasi]

Attachment: Simplified testcase: toggles bgColor to show bug

Comment 6

[karnaze (gone)]

*** Bug 26069 has been marked as a duplicate of this bug. ***

Comment 7

[Marc Attinasi]

Checking for border width > 0 before setting the border style to 
NS_STYLE_BORDER_STYLE_BG_INSET. The problem was that the border was specified 
with a width of 0, so the check for a border attribute with a Pixel-unit was 
insufficient for determining if the cell should have a border style. 
f=nsHTMLTableElement r=karnaze

Comment 8

[karnaze (gone)]

*** Bug 25051 has been marked as a duplicate of this bug. ***

Comment 9

[karnaze (gone)]

*** Bug 24771 has been marked as a duplicate of this bug. ***

Comment 10

[karnaze (gone)]

*** Bug 18664 has been marked as a duplicate of this bug. ***

Comment 11

[karnaze (gone)]

*** Bug 27815 has been marked as a duplicate of this bug. ***

Comment 12

[Prashant Desale]

I still see the border on Win-95. I tested it with 2000-02-14-09.
Reopening bug.

Comment 13

[Marc Attinasi]

I double-checked it with chrisd on Win95 and NT and it is fine. We used the 2/13 
and 2/14 builds, pulled from Mozilla.org. Please check it again. Thanks.

Comment 14

[Prashant Desale]

Marc, I checked it again and I can still see it on windows-95. 
One thing I want to make sure, border here we are talking about si some dotted 
line we see around the image right ?

Comment 15

[Marc Attinasi]

The dotted-line is the focus indicator. The borde was a sloid line around ALL of 
the cells (not just the image). I'm guessing then that the bug is indeed fixed. 
Please verify.

Comment 16

[Prashant Desale]

You are right Marc. 
Sorry I reopened it with wrong thing in mind.
Marking fixed, and verified.

Comment 17

[Prashant Desale]

Verified with 2000-02-14-09.