256801 - After opening a new tab (Ctrl+T), Find in this Page of original page gets stuck, changing text selection color to green

Status: RESOLVED DUPLICATE of bug 209989

(Toolkit :: Find Toolbar, defect)

Description

[:deanis74]

1. Go to http://www.mozilla.org/
2. Search for 'e'
3. Ctrl+T
4. Close the Find bar
5. Go back to the tab from step 1.
6. Drag to highlight some text.

Expected Results: Text is selected using standard Windows highlight color.

Actual Results: Text is selected using green FAYT highlight color.

Comment 1

[logan]

I'm unable to reproduce this with 8/27 linux build. The first problem is that
the find toolbar doesn't stay open when creating a new tab. Is this Windows only?

Comment 2

[:deanis74]

Sorry, it's not FAYT it's when I open it using Ctrl+F.

Comment 3

[logan]

oh, yeah i see it now

Comment 4

[logan]

1.0PR is coming up, so noone will like me for this, but I'll try anyway. I see
view source (bug 250279) was -'d, so I doubt this will get in. It'd just be nice
for all the FAYT/Find Toolbar bugs to be gone, so people just see the new
toolbar, not the new bugs. ;)

thanks for cc

Comment 5

[:deanis74]

I'm going to minus the PR request myself.  They're trying to get it out the
door, and anything that isn't a localization change can wait until 1.0.  Chris,
feel free to slap me.

Comment 6

[chris hofmann]

no, thanks for the help.  now we are in that situation for 1.0..  need to focus
on hire priority fixes.   if someone comes up with a patch renominate.

Comment 7

[:deanis74]

Chris, did you mean to minus this for blocking 1.0 instead of plussing it?

Comment 8

[Justin Wood (:Callek)]

This issue seems to be that the find bar should close just before the tab
switch, doing this would accomplish the inert selection-color-revert.  I would
personally argue though (may be seperate bug all-to-gether) that ctrl+f finding
should not use the FAYT color, but that is just me and may not represent the
goals of anyone else.

Comment 9

[Evan McLain]

I have a similar case that does not involve tab switching.  It seems to be tied
to "Find Again"/Ctrl-G:
(Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:1.7.3) Gecko/20041001 Firefox/0.10.1)

1. Go to http://www.mozilla.org/
2. Ctrl-F OR
   Edit->Find in This Page... 
3. Type 'browse'            
   - highlighted in FAYT green
3. Drag-highlight some text 
   - highlighted in windows highlight color, as expected (dark blue in my case)
4. Ctrl-G  OR
   Edit->Find Again  OR
   Find Next on Find bar
5. Drag-highlight some test

   Expected: highlighted in windows highlight
  
   Actual: highlighted in FAYT green

This behavior does not occur with pure FAYT because the Find bar goes away when
you highlight text.  I think it is the combination of the persistent Find bar
and 'Find Again/Find Next'.

BTW, I disagree with the previous comment.  The Ctrl-F/Find Bar/FAYT integration
is great!

Comment 10

[Phil Ringnalda (:philor)]

*** Bug 269945 has been marked as a duplicate of this bug. ***

Comment 11

[:Gavin Sharp [email: [e-mail]]]

*** Bug 295489 has been marked as a duplicate of this bug. ***

Comment 12

[Daniel Wang]

re comment 9
text selection highlight becomes green after Find Again is bug 209989

Comment 13

[:Gavin Sharp [email: [e-mail]]]

*** Bug 315623 has been marked as a duplicate of this bug. ***

Comment 14

[Sokraates]

Can confirm.

It suffices to change to another tab, no need to open a new one. Once you go back, highlights can not be removed.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051108 Firefox/1.5 ID:2005110803

Comment 15

[Wayne Mery (:wsmwk)]

WFM - can't reproduce comment 0 nor comment 9 using current trunk.
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060629 Minefield/3.0a1

Comment 16

[Wayne Mery (:wsmwk)]

fixed by bug 209989 on trunk

*** This bug has been marked as a duplicate of 209989 ***